[GitHub] [flink] zentol commented on a change in pull request #17390: [FLINK-24275][rest] Idempotent job cancellation

[GitBox <gi...@apache.org>]

zentol commented on a change in pull request #17390:
URL: https://github.com/apache/flink/pull/17390#discussion_r720046579



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/HandlerRequest.java
##########
@@ -100,7 +100,8 @@ public HandlerRequest(
                                     + value
                                     + "\".");
                 }
-
+            }
+            if (pathParameter.isResolved()) {

Review comment:
       > This covers cases where a parameter is resolved through other means than an explicitly specified value in the request, right?
   
   Correct, however this only occurs during testing.
   
   It's not a _bug_ in that sense. But particularly in tests this behavior was not intuitive, and having to re-encode parameters into Maps we lose the benefit that these parameters provide in the first place.
   
   There are other approaches one could take, like dedicated factory methods; this was just the shortest way to implement it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org