You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "jyothsnakonisa (via GitHub)" <gi...@apache.org> on 2023/02/17 19:02:24 UTC

[GitHub] [cassandra] jyothsnakonisa commented on a diff in pull request #1706: CASSANDRA-17708 Fixing flaky tests in InternodeEncryptionEnforcementTest

jyothsnakonisa commented on code in PR #1706:
URL: https://github.com/apache/cassandra/pull/1706#discussion_r1110224116


##########
test/distributed/org/apache/cassandra/distributed/test/InternodeEncryptionEnforcementTest.java:
##########
@@ -86,8 +84,7 @@ public void testInboundConnectionsAreRejectedWhenAuthFails() throws IOException,
             // Wait for authentication to fail
             cluster.get(1).logs().watchFor("Unable to authenticate peer");
             cluster.get(1).runOnInstance(runnable);
-            cluster.get(2).logs().watchFor("Unable to authenticate peer");
-            cluster.get(2).runOnInstance(runnable);

Review Comment:
   I think we should watch for "Unable to authenticate peer" which is more specific in terms of why the connection reset happen. Also it is the log that we print after `authenticate` call fails.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org