You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2014/06/01 18:53:12 UTC
[Issue 125021] New: Descenders get cropped within OS/X widgets
https://issues.apache.org/ooo/show_bug.cgi?id=125021
Issue ID: 125021
Issue Type: DEFECT
Summary: Descenders get cropped within OS/X widgets
Product: General
Version: 4.2.0-dev
Hardware: Mac
OS: Mac OSX, 10.9
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: ui
Assignee: issues@openoffice.apache.org
Reporter: thorsten.wagner.4@gmail.com
CC: hdu@apache.org
Created attachment 83486
--> https://issues.apache.org/ooo/attachment.cgi?id=83486&action=edit
Patch
Using Mac OS/X depending on screen resolution different character heights are
calculated:
(1) The calculation of character heights in "ctfonts.cxx" works fine for laptop
screens including retina at different resolutions.
(2) For larger cinema displays characters are calculated a little bit too tall.
This causes cropping of descenders within widgets (see attached screenshot 1,
red boxes).
I supplied a patch with modified roundings. The patch causes character heights
to be rounded down to the next pixel instead of rounding to the nearest pixel.
The result is shown in attached screenshot 2.
The patch needs to be doublechecked to avoid side effects.
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125021] Descenders get cropped within OS/X widgets
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125021
--- Comment #2 from Thorsten Wagner <th...@gmail.com> ---
Created attachment 83488
--> https://issues.apache.org/ooo/attachment.cgi?id=83488&action=edit
Screenshot with patch (AOO 4.2)
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125021] Descenders get cropped within OS/X widgets
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125021
--- Comment #4 from hdu@apache.org <hd...@apache.org> ---
Forcing round-down instead of round-nearest results in worse metrics so I'd
rather avoid this. Please check whether the rounding fixes for the repaint
region (revision 1599173 and revision 1599174) already help for the displays in
question.
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125021] Descenders get cropped within OS/X widgets
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125021
hdu@apache.org <hd...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #83486|0 |1
is patch| |
--- Comment #3 from hdu@apache.org <hd...@apache.org> ---
Comment on attachment 83486
--> https://issues.apache.org/ooo/attachment.cgi?id=83486
Patch
Added "patch" flag to the attachment to allow easy diff-viewing.
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125021] Descenders get cropped within OS/X widgets
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125021
--- Comment #1 from Thorsten Wagner <th...@gmail.com> ---
Created attachment 83487
--> https://issues.apache.org/ooo/attachment.cgi?id=83487&action=edit
Screenshot without patch (AOO 4.1)
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.
[Issue 125021] Descenders get cropped within OS/X widgets
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125021
--- Comment #5 from Thorsten Wagner <th...@gmail.com> ---
Unfortunately the fixes in revision 1599173 and revision 1599174 don't solve
the problem. The result is still as shown in attached screenshot without patch.
Furthermore the attached patch doesn't solve the problem too. I discovered side
effects (characters within status bar become croped and height of tool bars is
calculated too small now).
--
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.