[GitHub] [hbase] HorizonNet commented on a change in pull request #1379: HBASE-24077 When encounter RowTooBigException, log the row info.

[GitBox <gi...@apache.org>]

HorizonNet commented on a change in pull request #1379: HBASE-24077 When encounter RowTooBigException, log the row info.
URL: https://github.com/apache/hbase/pull/1379#discussion_r399994902
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
 ##########
 @@ -635,8 +635,12 @@ public boolean next(List<Cell> outResult, ScannerContext scannerContext) throws
             scannerContext.incrementBatchProgress(1);
 
             if (matcher.isUserScan() && totalBytesRead > maxRowSize) {
-              throw new RowTooBigException(
-                  "Max row size allowed: " + maxRowSize + ", but the row is bigger than that.");
+              LOG.info("Max row size allowed: " + maxRowSize
+                + ", but the row is bigger than that, the row info: " + CellUtil
+                .toString(cell, true) + ", already have process row cells = " + outResult.size());
 
 Review comment:
   Is it necessary that we write out the log and throw the exception? With that we potentially have the same log entry twice.  Better would be to only have the exception with the full log message.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services