You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/10/10 17:41:14 UTC

[kudu-CR] [docs] a small update on RELEASING.adoc

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14411


Change subject: [docs] a small update on RELEASING.adoc
......................................................................

[docs] a small update on RELEASING.adoc

Minor clarification on the username to use for logging in at
gerrit.cloudera.com to update gerrit mirroring configuration.  Also,
fixed formatting of the numbered sub-list and added an item to verify
that gerrit has been restarted successfully.

Change-Id: I3046e24b63b1d70a0e5f4d5d28b5335a26255137
---
M RELEASING.adoc
1 file changed, 8 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/14411/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3046e24b63b1d70a0e5f4d5d28b5335a26255137
Gerrit-Change-Number: 14411
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>

[kudu-CR] [docs] a small update on RELEASING.adoc

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [docs] a small update on RELEASING.adoc
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/14411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I3046e24b63b1d70a0e5f4d5d28b5335a26255137
Gerrit-Change-Number: 14411
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [docs] a small update on RELEASING.adoc

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14411 )

Change subject: [docs] a small update on RELEASING.adoc
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3046e24b63b1d70a0e5f4d5d28b5335a26255137
Gerrit-Change-Number: 14411
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 11 Oct 2019 04:00:18 +0000
Gerrit-HasComments: No

[kudu-CR] [docs] a small update on RELEASING.adoc

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14411 )

Change subject: [docs] a small update on RELEASING.adoc
......................................................................


Patch Set 1: Verified+1

Unrelated failure in tests:
  * ClientTest.TestFailedDnsResolution


-- 
To view, visit http://gerrit.cloudera.org:8080/14411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3046e24b63b1d70a0e5f4d5d28b5335a26255137
Gerrit-Change-Number: 14411
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 10 Oct 2019 18:08:59 +0000
Gerrit-HasComments: No

[kudu-CR] [docs] a small update on RELEASING.adoc

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14411 )

Change subject: [docs] a small update on RELEASING.adoc
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/14411/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/14411/1//COMMIT_MSG@10
PS1, Line 10: gerrit.cloudera.com to update gerrit mirroring configuration.  Also,
> It's gerrit.cloudera.org
Done


http://gerrit.cloudera.org:8080/#/c/14411/1/RELEASING.adoc
File RELEASING.adoc:

http://gerrit.cloudera.org:8080/#/c/14411/1/RELEASING.adoc@80
PS1, Line 80: the 
> Nit: drop 'the'
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/14411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3046e24b63b1d70a0e5f4d5d28b5335a26255137
Gerrit-Change-Number: 14411
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 10 Oct 2019 21:12:14 +0000
Gerrit-HasComments: Yes

[kudu-CR] [docs] a small update on RELEASING.adoc

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14411 )

Change subject: [docs] a small update on RELEASING.adoc
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/14411/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/14411/1//COMMIT_MSG@10
PS1, Line 10: gerrit.cloudera.com to update gerrit mirroring configuration.  Also,
It's gerrit.cloudera.org


http://gerrit.cloudera.org:8080/#/c/14411/1/RELEASING.adoc
File RELEASING.adoc:

http://gerrit.cloudera.org:8080/#/c/14411/1/RELEASING.adoc@80
PS1, Line 80: the 
Nit: drop 'the'



-- 
To view, visit http://gerrit.cloudera.org:8080/14411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3046e24b63b1d70a0e5f4d5d28b5335a26255137
Gerrit-Change-Number: 14411
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 10 Oct 2019 18:24:00 +0000
Gerrit-HasComments: Yes

[kudu-CR] [docs] a small update on RELEASING.adoc

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14411 )

Change subject: [docs] a small update on RELEASING.adoc
......................................................................

[docs] a small update on RELEASING.adoc

Minor clarification on the username to use for logging in at
gerrit.cloudera.org to update gerrit mirroring configuration.  Also,
fixed formatting of the numbered sub-list and added an item to verify
that gerrit has been restarted successfully.

Change-Id: I3046e24b63b1d70a0e5f4d5d28b5335a26255137
Reviewed-on: http://gerrit.cloudera.org:8080/14411
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M RELEASING.adoc
1 file changed, 8 insertions(+), 6 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Adar Dembo: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/14411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3046e24b63b1d70a0e5f4d5d28b5335a26255137
Gerrit-Change-Number: 14411
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [docs] a small update on RELEASING.adoc

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/14411

to look at the new patch set (#2).

Change subject: [docs] a small update on RELEASING.adoc
......................................................................

[docs] a small update on RELEASING.adoc

Minor clarification on the username to use for logging in at
gerrit.cloudera.org to update gerrit mirroring configuration.  Also,
fixed formatting of the numbered sub-list and added an item to verify
that gerrit has been restarted successfully.

Change-Id: I3046e24b63b1d70a0e5f4d5d28b5335a26255137
---
M RELEASING.adoc
1 file changed, 8 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/14411/2
-- 
To view, visit http://gerrit.cloudera.org:8080/14411
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3046e24b63b1d70a0e5f4d5d28b5335a26255137
Gerrit-Change-Number: 14411
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)