You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by "PurelyApplied (GitHub)" <gi...@apache.org> on 2018/10/24 22:27:21 UTC

[GitHub] [geode] PurelyApplied commented on issue #2706: GEODE-5928: Refactor / rewrite of WANSSLDunitTest

See #2702 for keystore changes.  The true scope of this ticket is in reforming `WANSSLDUnitTest` so that future developers do not have to struggle as much with `WANTestBase` / `DistributedTestCase` / `JUnit4DistributedTestCase` chasing.

The actual content of this rewrite is the result of inlining methods and pushing methods down from the parent class into this test class.  Most methods and fields were renamed, statics turned to instance variables to avoid test environment leakage, and added parameterization on a previously-randomized configuration option.

Additional refactoring is certainly possible, notably that we should use the actual `MemberStarterRules` to create servers and locators, rather than these custom cache / member creation methods in otherwise empty VMs.  Additionally, this test relies heavily on internals, particularly surrounding the `InternalDistributedSystem`.

[ Full content available at: https://github.com/apache/geode/pull/2706 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org