You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "johnsolomonj (via GitHub)" <gi...@apache.org> on 2025/09/09 17:59:27 UTC
[PR] issue-16707: Add cursor based pagination support to java client [pinot]
johnsolomonj opened a new pull request, #16782:
URL: https://github.com/apache/pinot/pull/16782
Instructions:
1. The PR has to be tagged with at least one of the following labels (*):
1. `feature`
2. `bugfix`
3. `performance`
4. `ui`
5. `backward-incompat`
6. `release-notes` (**)
2. Remove these instructions before publishing the PR.
(*) Other labels to consider:
- `testing`
- `dependencies`
- `docker`
- `kubernetes`
- `observability`
- `security`
- `code-style`
- `extension-point`
- `refactor`
- `cleanup`
(**) Use `release-notes` label for scenarios like:
- New configuration options
- Deprecation of configurations
- Signature changes to public methods/interfaces
- New plugins added or old plugins removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [IN PROGRESS] issue-16707: Add cursor based pagination support to java client [pinot]
Posted by "johnsolomonj (via GitHub)" <gi...@apache.org>.
johnsolomonj commented on code in PR #16782:
URL: https://github.com/apache/pinot/pull/16782#discussion_r2338100317
##########
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/Connection.java:
##########
@@ -205,4 +204,281 @@ public void close()
public PinotClientTransport<?> getTransport() {
return _transport;
}
+
+ // ========== Cursor Methods (Default implementations for backward compatibility) ==========
+
+ /**
+ * Opens a cursor for paginated query execution using the Cursor Handle Pattern.
+ * The returned cursor starts with the first page already loaded.
+ *
+ * @param query the query to execute
+ * @param pageSize the number of rows per page
+ * @return ResultCursor with the first page loaded and ready for navigation
+ * @throws PinotClientException If an exception occurs while processing the query
+ */
+ public ResultCursor openCursor(String query, int pageSize) throws PinotClientException {
+ // Select broker for cursor operation
+ String brokerHostPort = _brokerSelector.selectBroker((String) null);
+ if (brokerHostPort == null) {
+ throw new PinotClientException("Could not find broker to execute cursor query");
+ }
+
+ try {
+ CursorAwareBrokerResponse initialResponse = _transport.executeQueryWithCursor(brokerHostPort, query, pageSize);
+ if (initialResponse.hasExceptions() && _failOnExceptions) {
+ throw new PinotClientException("Query had processing exceptions: \n" + initialResponse.getExceptions());
+ }
+
+ return new ResultCursorImpl(_transport, brokerHostPort, initialResponse, _failOnExceptions);
+ } catch (UnsupportedOperationException e) {
+ throw new UnsupportedOperationException("Cursor operations not supported by this connection type", e);
+ } catch (Exception e) {
+ throw new PinotClientException("Failed to open cursor", e);
+ }
+ }
+
+ /**
+ * Executes a query with cursor support for pagination.
+ *
+ * @deprecated Use openCursor(String, int) instead for better resource management
+ * @param query the query to execute
+ * @param numRows the number of rows per page
+ * @return CursorResultSetGroup containing the first page and cursor metadata
+ * @throws PinotClientException If an exception occurs while processing the query
+ */
+ @Deprecated
+ public CursorResultSetGroup executeCursorQuery(String query, int numRows) throws PinotClientException {
+ // Select broker for the query
+ String[] tableNames = resolveTableName(query);
+ String brokerHostPort = _brokerSelector.selectBroker(tableNames);
+ if (brokerHostPort == null) {
+ throw new PinotClientException("Could not find broker to execute cursor query");
+ }
+
+ try {
+ // Execute query with cursor support
+ CursorAwareBrokerResponse response = _transport.executeQueryWithCursor(brokerHostPort, query, numRows);
+ if (response.hasExceptions() && _failOnExceptions) {
+ throw new PinotClientException("Query had processing exceptions: \n" + response.getExceptions());
+ }
+
+ // Create cursor result set group
+ return new CursorResultSetGroup(response);
+ } catch (UnsupportedOperationException e) {
+ throw new UnsupportedOperationException("Cursor operations not supported by this connection type", e);
+ } catch (Exception e) {
+ throw new PinotClientException("Failed to execute cursor query", e);
+ }
+ }
+
+ /**
+ * Executes a query with cursor support asynchronously.
+ *
+ * @param query The SQL query to execute
+ * @param pageSize The number of rows per page
+ * @return CompletableFuture containing CursorResultSet
+ */
+ public CompletableFuture<CursorResultSetGroup> executeCursorQueryAsync(String query, int pageSize) {
Review Comment:
Resolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] issue-16707: Add cursor based pagination support to java client [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 merged PR #16782:
URL: https://github.com/apache/pinot/pull/16782
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] issue-16707: Add cursor based pagination support to java client [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on code in PR #16782:
URL: https://github.com/apache/pinot/pull/16782#discussion_r2354577677
##########
pinot-clients/pinot-java-client/src/test/java/org/apache/pinot/client/ConnectionFactoryTest.java:
##########
@@ -18,9 +18,12 @@
*/
package org.apache.pinot.client;
+import com.fasterxml.jackson.databind.JsonNode;
import com.google.common.collect.ImmutableList;
import com.google.common.collect.ImmutableMap;
+import java.lang.reflect.Method;
import java.util.List;
+import java.util.concurrent.CompletableFuture;
import java.util.Map;
import java.util.Properties;
import org.I0Itec.zkclient.ZkClient;
Review Comment:
```suggestion
import java.util.List;
import java.util.Map;
import java.util.Properties;
import java.util.concurrent.CompletableFuture;
import org.I0Itec.zkclient.ZkClient;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [IN PROGRESS] issue-16707: Add cursor based pagination support to java client [pinot]
Posted by "johnsolomonj (via GitHub)" <gi...@apache.org>.
johnsolomonj commented on code in PR #16782:
URL: https://github.com/apache/pinot/pull/16782#discussion_r2338101030
##########
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/CursorAwareBrokerResponse.java:
##########
@@ -0,0 +1,109 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.client;
+
+import com.fasterxml.jackson.databind.JsonNode;
+
+/**
+ * Extended BrokerResponse with cursor-specific fields for cursor pagination queries.
+ * This class adds cursor metadata fields while maintaining full compatibility with BrokerResponse.
+ */
+public class CursorAwareBrokerResponse extends BrokerResponse {
+ // Cursor-specific fields from Pinot documentation
+ private final Long _offset;
+ private final Integer _numRows;
+ private final Long _numRowsResultSet;
+ private Long _cursorResultWriteTimeMs;
+ private Long _submissionTimeMs;
+ private Long _expirationTimeMs;
+ private final String _brokerHost;
+ private Integer _brokerPort;
+ private Long _bytesWritten;
+ private final Long _cursorFetchTimeMs;
+
+ /**
+ * Creates a CursorAwareBrokerResponse by parsing cursor-specific fields from the JSON response.
+ */
+ public static CursorAwareBrokerResponse fromJson(JsonNode brokerResponse) {
+ return new CursorAwareBrokerResponse(brokerResponse);
+ }
+
+
+ private CursorAwareBrokerResponse(JsonNode brokerResponse) {
+ super(brokerResponse); // Initialize base BrokerResponse fields
+
+ // Parse cursor-specific fields
+ _offset = brokerResponse.has("offset") ? brokerResponse.get("offset").asLong() : null;
+ _numRows = brokerResponse.has("numRows") ? brokerResponse.get("numRows").asInt() : null;
+ _numRowsResultSet = brokerResponse.has("numRowsResultSet") ? brokerResponse.get("numRowsResultSet").asLong() : null;
+ JsonNode cursorResultWriteTimeMsNode = brokerResponse.get("cursorResultWriteTimeMs");
+ _cursorResultWriteTimeMs = cursorResultWriteTimeMsNode != null ? cursorResultWriteTimeMsNode.asLong() : null;
+ JsonNode expirationTimeMsNode = brokerResponse.get("expirationTimeMs");
+ _expirationTimeMs = expirationTimeMsNode != null ? expirationTimeMsNode.asLong() : null;
+ _submissionTimeMs = brokerResponse.has("submissionTimeMs") ? brokerResponse.get("submissionTimeMs").asLong() : null;
+ _brokerHost = brokerResponse.has("brokerHost") ? brokerResponse.get("brokerHost").asText() : null;
+ _brokerPort = brokerResponse.has("brokerPort") ? brokerResponse.get("brokerPort").asInt() : null;
+ _bytesWritten = brokerResponse.has("bytesWritten") ? brokerResponse.get("bytesWritten").asLong() : null;
+ _cursorFetchTimeMs = brokerResponse.has("cursorFetchTimeMs")
+ ? brokerResponse.get("cursorFetchTimeMs").asLong() : null;
+ }
+
+
+
Review Comment:
Resolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] issue-16707: Add cursor based pagination support to java client [pinot]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #16782:
URL: https://github.com/apache/pinot/pull/16782#discussion_r2337678255
##########
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/Connection.java:
##########
@@ -205,4 +204,281 @@ public void close()
public PinotClientTransport<?> getTransport() {
return _transport;
}
+
+ // ========== Cursor Methods (Default implementations for backward compatibility) ==========
+
+ /**
+ * Opens a cursor for paginated query execution using the Cursor Handle Pattern.
+ * The returned cursor starts with the first page already loaded.
+ *
+ * @param query the query to execute
+ * @param pageSize the number of rows per page
+ * @return ResultCursor with the first page loaded and ready for navigation
+ * @throws PinotClientException If an exception occurs while processing the query
+ */
+ public ResultCursor openCursor(String query, int pageSize) throws PinotClientException {
+ // Select broker for cursor operation
+ String brokerHostPort = _brokerSelector.selectBroker((String) null);
+ if (brokerHostPort == null) {
+ throw new PinotClientException("Could not find broker to execute cursor query");
+ }
+
+ try {
+ CursorAwareBrokerResponse initialResponse = _transport.executeQueryWithCursor(brokerHostPort, query, pageSize);
+ if (initialResponse.hasExceptions() && _failOnExceptions) {
+ throw new PinotClientException("Query had processing exceptions: \n" + initialResponse.getExceptions());
+ }
+
+ return new ResultCursorImpl(_transport, brokerHostPort, initialResponse, _failOnExceptions);
+ } catch (UnsupportedOperationException e) {
+ throw new UnsupportedOperationException("Cursor operations not supported by this connection type", e);
+ } catch (Exception e) {
+ throw new PinotClientException("Failed to open cursor", e);
+ }
+ }
+
+ /**
+ * Executes a query with cursor support for pagination.
+ *
+ * @deprecated Use openCursor(String, int) instead for better resource management
+ * @param query the query to execute
+ * @param numRows the number of rows per page
+ * @return CursorResultSetGroup containing the first page and cursor metadata
+ * @throws PinotClientException If an exception occurs while processing the query
+ */
+ @Deprecated
+ public CursorResultSetGroup executeCursorQuery(String query, int numRows) throws PinotClientException {
+ // Select broker for the query
+ String[] tableNames = resolveTableName(query);
+ String brokerHostPort = _brokerSelector.selectBroker(tableNames);
+ if (brokerHostPort == null) {
+ throw new PinotClientException("Could not find broker to execute cursor query");
+ }
+
+ try {
+ // Execute query with cursor support
+ CursorAwareBrokerResponse response = _transport.executeQueryWithCursor(brokerHostPort, query, numRows);
+ if (response.hasExceptions() && _failOnExceptions) {
+ throw new PinotClientException("Query had processing exceptions: \n" + response.getExceptions());
+ }
+
+ // Create cursor result set group
+ return new CursorResultSetGroup(response);
+ } catch (UnsupportedOperationException e) {
+ throw new UnsupportedOperationException("Cursor operations not supported by this connection type", e);
+ } catch (Exception e) {
+ throw new PinotClientException("Failed to execute cursor query", e);
+ }
+ }
+
+ /**
+ * Executes a query with cursor support asynchronously.
+ *
+ * @param query The SQL query to execute
+ * @param pageSize The number of rows per page
+ * @return CompletableFuture containing CursorResultSet
+ */
+ public CompletableFuture<CursorResultSetGroup> executeCursorQueryAsync(String query, int pageSize) {
Review Comment:
Unsafe cast without type checking. This will throw ClassCastException if _transport is not a JsonAsyncHttpPinotClientTransport. Add instanceof check before casting.
```suggestion
public CompletableFuture<CursorResultSetGroup> executeCursorQueryAsync(String query, int pageSize) {
if (!(_transport instanceof JsonAsyncHttpPinotClientTransport)) {
return CompletableFuture.failedFuture(
new UnsupportedOperationException("Cursor operations not supported by this connection type"));
}
```
##########
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/CursorAwareBrokerResponse.java:
##########
@@ -0,0 +1,109 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.client;
+
+import com.fasterxml.jackson.databind.JsonNode;
+
+/**
+ * Extended BrokerResponse with cursor-specific fields for cursor pagination queries.
+ * This class adds cursor metadata fields while maintaining full compatibility with BrokerResponse.
+ */
+public class CursorAwareBrokerResponse extends BrokerResponse {
+ // Cursor-specific fields from Pinot documentation
+ private final Long _offset;
+ private final Integer _numRows;
+ private final Long _numRowsResultSet;
+ private Long _cursorResultWriteTimeMs;
+ private Long _submissionTimeMs;
+ private Long _expirationTimeMs;
+ private final String _brokerHost;
+ private Integer _brokerPort;
+ private Long _bytesWritten;
+ private final Long _cursorFetchTimeMs;
+
+ /**
+ * Creates a CursorAwareBrokerResponse by parsing cursor-specific fields from the JSON response.
+ */
+ public static CursorAwareBrokerResponse fromJson(JsonNode brokerResponse) {
+ return new CursorAwareBrokerResponse(brokerResponse);
+ }
+
+
+ private CursorAwareBrokerResponse(JsonNode brokerResponse) {
+ super(brokerResponse); // Initialize base BrokerResponse fields
+
+ // Parse cursor-specific fields
+ _offset = brokerResponse.has("offset") ? brokerResponse.get("offset").asLong() : null;
+ _numRows = brokerResponse.has("numRows") ? brokerResponse.get("numRows").asInt() : null;
+ _numRowsResultSet = brokerResponse.has("numRowsResultSet") ? brokerResponse.get("numRowsResultSet").asLong() : null;
+ JsonNode cursorResultWriteTimeMsNode = brokerResponse.get("cursorResultWriteTimeMs");
+ _cursorResultWriteTimeMs = cursorResultWriteTimeMsNode != null ? cursorResultWriteTimeMsNode.asLong() : null;
+ JsonNode expirationTimeMsNode = brokerResponse.get("expirationTimeMs");
+ _expirationTimeMs = expirationTimeMsNode != null ? expirationTimeMsNode.asLong() : null;
+ _submissionTimeMs = brokerResponse.has("submissionTimeMs") ? brokerResponse.get("submissionTimeMs").asLong() : null;
+ _brokerHost = brokerResponse.has("brokerHost") ? brokerResponse.get("brokerHost").asText() : null;
+ _brokerPort = brokerResponse.has("brokerPort") ? brokerResponse.get("brokerPort").asInt() : null;
+ _bytesWritten = brokerResponse.has("bytesWritten") ? brokerResponse.get("bytesWritten").asLong() : null;
+ _cursorFetchTimeMs = brokerResponse.has("cursorFetchTimeMs")
+ ? brokerResponse.get("cursorFetchTimeMs").asLong() : null;
+ }
+
+
+
Review Comment:
[nitpick] The null-checking pattern for JsonNode is repeated. Consider extracting this into a helper method to reduce duplication and improve maintainability.
```suggestion
// Parse cursor-specific fields using helper methods
_offset = getLongOrNull(brokerResponse, "offset");
_numRows = getIntOrNull(brokerResponse, "numRows");
_numRowsResultSet = getLongOrNull(brokerResponse, "numRowsResultSet");
_cursorResultWriteTimeMs = getLongOrNull(brokerResponse, "cursorResultWriteTimeMs");
_expirationTimeMs = getLongOrNull(brokerResponse, "expirationTimeMs");
_submissionTimeMs = getLongOrNull(brokerResponse, "submissionTimeMs");
_brokerHost = getTextOrNull(brokerResponse, "brokerHost");
_brokerPort = getIntOrNull(brokerResponse, "brokerPort");
_bytesWritten = getLongOrNull(brokerResponse, "bytesWritten");
_cursorFetchTimeMs = getLongOrNull(brokerResponse, "cursorFetchTimeMs");
}
// Helper methods for extracting values from JsonNode with null checks
private static Long getLongOrNull(JsonNode node, String fieldName) {
JsonNode valueNode = node.get(fieldName);
return (valueNode != null && !valueNode.isNull()) ? valueNode.asLong() : null;
}
private static Integer getIntOrNull(JsonNode node, String fieldName) {
JsonNode valueNode = node.get(fieldName);
return (valueNode != null && !valueNode.isNull()) ? valueNode.asInt() : null;
}
private static String getTextOrNull(JsonNode node, String fieldName) {
JsonNode valueNode = node.get(fieldName);
return (valueNode != null && !valueNode.isNull()) ? valueNode.asText() : null;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] issue-16707: Add cursor based pagination support to java client [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #16782:
URL: https://github.com/apache/pinot/pull/16782#issuecomment-3303829779
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/16782?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 56.26%. Comparing base ([`fd39662`](https://app.codecov.io/gh/apache/pinot/commit/fd39662b0832d07b6748add2e38f2026ba6e3077?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`7645669`](https://app.codecov.io/gh/apache/pinot/commit/76456693b6cdb08b6022ca748eeba62e641f36c7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
> :exclamation: There is a different number of reports uploaded between BASE (fd39662) and HEAD (7645669). Click for more details.
>
> <details><summary>HEAD has 32 uploads less than BASE</summary>
>
>| Flag | BASE (fd39662) | HEAD (7645669) |
>|------|------|------|
>|java-21|4|1|
>|unittests1|2|1|
>|unittests|4|1|
>|temurin|9|1|
>|java-11|5|0|
>|unittests2|2|0|
>|integration|5|0|
>|integration1|2|0|
>|custom-integration1|2|0|
>|integration2|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #16782 +/- ##
============================================
- Coverage 63.35% 56.26% -7.10%
+ Complexity 1410 700 -710
============================================
Files 3057 2396 -661
Lines 179272 133241 -46031
Branches 27474 21200 -6274
============================================
- Hits 113582 74970 -38612
+ Misses 56929 52007 -4922
+ Partials 8761 6264 -2497
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/16782/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/16782/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration](https://app.codecov.io/gh/apache/pinot/pull/16782/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/16782/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration2](https://app.codecov.io/gh/apache/pinot/pull/16782/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-11](https://app.codecov.io/gh/apache/pinot/pull/16782/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-21](https://app.codecov.io/gh/apache/pinot/pull/16782/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.26% <ø> (-7.07%)` | :arrow_down: |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/16782/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.26% <ø> (-7.10%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/16782/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.26% <ø> (-7.09%)` | :arrow_down: |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/16782/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.26% <ø> (-0.06%)` | :arrow_down: |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/16782/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/pinot/pull/16782?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] issue-16707: Add cursor based pagination support to java client [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on PR #16782:
URL: https://github.com/apache/pinot/pull/16782#issuecomment-3305123708
Thanks for your contribution @johnsolomonj !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org