You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by jo...@apache.org on 2004/11/02 00:39:28 UTC

cvs commit: httpd-2.0/modules/mappers mod_rewrite.c

jorton      2004/11/01 15:39:28

  Modified:    modules/mappers mod_rewrite.c
  Log:
  * modules/mappers/mod_rewrite.c (hook_uri2file): Revert r1.259 to fix
  regression in proxy and QUERY_STRING handling (though with proxy
  issues on HEAD mod_rewrite [P] stuff is still completely broken).
  
  Revision  Changes    Path
  1.263     +1 -1      httpd-2.0/modules/mappers/mod_rewrite.c
  
  Index: mod_rewrite.c
  ===================================================================
  RCS file: /home/cvs/httpd-2.0/modules/mappers/mod_rewrite.c,v
  retrieving revision 1.262
  retrieving revision 1.263
  diff -d -w -u -r1.262 -r1.263
  --- mod_rewrite.c	12 Oct 2004 11:55:30 -0000	1.262
  +++ mod_rewrite.c	1 Nov 2004 23:39:28 -0000	1.263
  @@ -4249,7 +4249,7 @@
                                             r->path_info, NULL);
               }
               if (r->args != NULL &&
  -                r->uri != r->unparsed_uri) {
  +                r->uri == r->unparsed_uri) {
                   /* see proxy_http:proxy_http_canon() */
                   r->filename = apr_pstrcat(r->pool, r->filename,
                                             "?", r->args, NULL);
  
  
  

Re: cvs commit: httpd-2.0/modules/mappers mod_rewrite.c

Posted by Geoffrey Young <ge...@modperlcookbook.org>.
> (though with proxy
>   issues on HEAD mod_rewrite [P] stuff is still completely broken).

yeah.  if I have the time I'll try to track down exactly the revision that
caused this failure so it can also be added to showstoppers, if merely so
somebody takes the time to explicitly address it.  not sure if I'll be able
to get to it before apachecon, though...

--Geoff