You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2023/01/09 10:42:14 UTC
[GitHub] [kafka] fvaleri commented on a diff in pull request #13080: KAFKA-14575: Move ClusterTool to tools module
fvaleri commented on code in PR #13080:
URL: https://github.com/apache/kafka/pull/13080#discussion_r1064457544
##########
tools/src/main/java/org/apache/kafka/tools/ClusterTool.java:
##########
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.tools;
+
+import net.sourceforge.argparse4j.ArgumentParsers;
+import net.sourceforge.argparse4j.inf.ArgumentParser;
+import net.sourceforge.argparse4j.inf.Namespace;
+import net.sourceforge.argparse4j.inf.Subparser;
+import net.sourceforge.argparse4j.inf.Subparsers;
+import org.apache.kafka.clients.admin.Admin;
+import org.apache.kafka.common.errors.UnsupportedVersionException;
+import org.apache.kafka.common.utils.Exit;
+import org.apache.kafka.common.utils.Utils;
+
+import java.io.PrintStream;
+import java.util.Arrays;
+import java.util.Properties;
+import java.util.concurrent.ExecutionException;
+
+import static net.sourceforge.argparse4j.impl.Arguments.store;
+
+public class ClusterTool {
+
+ public static void main(String... args) {
+ Exit.exit(mainNoExit(args));
+ }
+
+ static int mainNoExit(String... args) {
+ try {
+ execute(args);
+ return 0;
+ } catch (TerseException e) {
+ System.err.println(e.getMessage());
+ return 1;
+ } catch (Throwable e) {
+ System.err.println(e.getMessage());
+ System.err.println(Utils.stackTrace(e));
+ return 1;
+ }
+ }
+
+ static void execute(String... args) throws Exception {
+ ArgumentParser parser = ArgumentParsers
+ .newArgumentParser("kafka-cluster")
+ .defaultHelp(true)
+ .description("The Kafka cluster tool.");
+ Subparsers subparsers = parser.addSubparsers().dest("command");
+
+ Subparser clusterIdParser = subparsers.addParser("cluster-id")
+ .help("Get information about the ID of a cluster.");
+ Subparser unregisterParser = subparsers.addParser("unregister")
+ .help("Unregister a broker.");
+ for (Subparser subpparser : Arrays.asList(clusterIdParser, unregisterParser)) {
+ subpparser.addArgument("--bootstrap-server", "-b")
+ .action(store())
+ .help("A list of host/port pairs to use for establishing the connection to the kafka cluster.");
+ subpparser.addArgument("--config", "-c")
+ .action(store())
+ .help("A property file containing configs to passed to AdminClient.");
+ }
+ unregisterParser.addArgument("--id", "-i")
+ .type(Integer.class)
+ .action(store())
+ .required(true)
+ .help("The ID of the broker to unregister.");
+
+ Namespace namespace = parser.parseArgsOrFail(args);
+ String command = namespace.getString("command");
+ String configPath = namespace.getString("config");
+ Properties properties = (configPath == null) ? new Properties() : Utils.loadProps(configPath);
+
+ String bootstrapServer = namespace.getString("bootstrap_server");
+ if (bootstrapServer != null) {
+ properties.setProperty("bootstrap.servers", bootstrapServer);
+ }
+ if (properties.getProperty("bootstrap.servers") == null) {
+ throw new TerseException("Please specify --bootstrap-server.");
+ }
+
+ switch (command) {
+ case "cluster-id": {
+ try (Admin adminClient = Admin.create(properties)) {
+ clusterIdCommand(System.out, adminClient);
+ }
+ break;
+ }
+ case "unregister": {
+ try (Admin adminClient = Admin.create(properties)) {
+ unregisterCommand(System.out, adminClient, namespace.getInt("id"));
+ }
+ break;
+ }
+ default:
+ throw new RuntimeException("Unknown command " + command);
+ }
+ }
+
+ static void clusterIdCommand(PrintStream stream, Admin adminClient) throws Exception {
+ String clusterId = adminClient.describeCluster().clusterId().get();
Review Comment:
Why don't we use Optional as in the original code?
##########
tools/src/main/java/org/apache/kafka/tools/ClusterTool.java:
##########
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.tools;
+
+import net.sourceforge.argparse4j.ArgumentParsers;
+import net.sourceforge.argparse4j.inf.ArgumentParser;
+import net.sourceforge.argparse4j.inf.Namespace;
+import net.sourceforge.argparse4j.inf.Subparser;
+import net.sourceforge.argparse4j.inf.Subparsers;
+import org.apache.kafka.clients.admin.Admin;
+import org.apache.kafka.common.errors.UnsupportedVersionException;
+import org.apache.kafka.common.utils.Exit;
+import org.apache.kafka.common.utils.Utils;
+
+import java.io.PrintStream;
+import java.util.Arrays;
+import java.util.Properties;
+import java.util.concurrent.ExecutionException;
+
+import static net.sourceforge.argparse4j.impl.Arguments.store;
+
+public class ClusterTool {
+
+ public static void main(String... args) {
+ Exit.exit(mainNoExit(args));
+ }
+
+ static int mainNoExit(String... args) {
Review Comment:
Why not simply embed this logic inside the main method to have one less stack frame?
##########
tools/src/main/java/org/apache/kafka/tools/ClusterTool.java:
##########
@@ -0,0 +1,134 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.tools;
+
+import net.sourceforge.argparse4j.ArgumentParsers;
+import net.sourceforge.argparse4j.inf.ArgumentParser;
+import net.sourceforge.argparse4j.inf.Namespace;
+import net.sourceforge.argparse4j.inf.Subparser;
+import net.sourceforge.argparse4j.inf.Subparsers;
+import org.apache.kafka.clients.admin.Admin;
+import org.apache.kafka.common.errors.UnsupportedVersionException;
+import org.apache.kafka.common.utils.Exit;
+import org.apache.kafka.common.utils.Utils;
+
+import java.io.PrintStream;
+import java.util.Arrays;
+import java.util.Properties;
+import java.util.concurrent.ExecutionException;
+
+import static net.sourceforge.argparse4j.impl.Arguments.store;
+
+public class ClusterTool {
+
+ public static void main(String... args) {
+ Exit.exit(mainNoExit(args));
+ }
+
+ static int mainNoExit(String... args) {
+ try {
+ execute(args);
+ return 0;
+ } catch (TerseException e) {
+ System.err.println(e.getMessage());
+ return 1;
+ } catch (Throwable e) {
+ System.err.println(e.getMessage());
+ System.err.println(Utils.stackTrace(e));
+ return 1;
+ }
+ }
+
+ static void execute(String... args) throws Exception {
+ ArgumentParser parser = ArgumentParsers
+ .newArgumentParser("kafka-cluster")
+ .defaultHelp(true)
+ .description("The Kafka cluster tool.");
+ Subparsers subparsers = parser.addSubparsers().dest("command");
+
+ Subparser clusterIdParser = subparsers.addParser("cluster-id")
+ .help("Get information about the ID of a cluster.");
+ Subparser unregisterParser = subparsers.addParser("unregister")
+ .help("Unregister a broker.");
+ for (Subparser subpparser : Arrays.asList(clusterIdParser, unregisterParser)) {
+ subpparser.addArgument("--bootstrap-server", "-b")
+ .action(store())
+ .help("A list of host/port pairs to use for establishing the connection to the kafka cluster.");
+ subpparser.addArgument("--config", "-c")
+ .action(store())
+ .help("A property file containing configs to passed to AdminClient.");
Review Comment:
```suggestion
.help("A property file containing custom configs for the AdminClient.");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org