You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@plc4x.apache.org by GitBox <gi...@apache.org> on 2019/04/10 08:38:25 UTC
[GitHub] [incubator-plc4x] chrisdutz opened a new pull request #59:
Feature/alternate plc4 x 108
chrisdutz opened a new pull request #59: Feature/alternate plc4 x 108
URL: https://github.com/apache/incubator-plc4x/pull/59
Hi,
in this alternate implementation, I added a "ping" method to the default API and moved the code for the TCP ping into the classes actually involved in TCP (with options for other base types - serial, udp, raw-socket, test, ...).
Please review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
Re: [GitHub] [incubator-plc4x] chrisdutz opened a new pull request
#59: Feature/alternate plc4 x 108
Posted by Christofer Dutz <ch...@c-ware.de>.
Ok ... so as there were no real objections, I'll merge this to develop ...
Chris
Am 10.04.19, 10:38 schrieb "GitBox" <gi...@apache.org>:
chrisdutz opened a new pull request #59: Feature/alternate plc4 x 108
URL: https://github.com/apache/incubator-plc4x/pull/59
Hi,
in this alternate implementation, I added a "ping" method to the default API and moved the code for the TCP ping into the classes actually involved in TCP (with options for other base types - serial, udp, raw-socket, test, ...).
Please review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services