You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "davidyuan1223 (via GitHub)" <gi...@apache.org> on 2023/11/17 10:13:04 UTC
[PR] [#5396] SBT build support [kyuubi]
davidyuan1223 opened a new pull request, #5721:
URL: https://github.com/apache/kyuubi/pull/5721
# :mag: Description
## Issue References ๐
<!-- Append the issue number after #. If there is no issue for you to link create one or -->
<!-- If there are no issues to link, please provide details here. -->
This pull request fixes #5396
## Describe Your Solution ๐ง
Currently maven build is slowly, we need a faster tool to build, so we can support sbt in project, it's quickly than maven
## Types of changes :bookmark:
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
## Test Plan ๐งช
#### Behavior Without This Pull Request :coffin:
#### Behavior With This Pull Request :tada:
#### Related Unit Tests
---
# Checklists
## ๐ Author Self Checklist
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [ ] My code follows the [style guidelines](https://kyuubi.readthedocs.io/en/master/contributing/code/style.html) of this project
- [ ] I have performed a self-review
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] This patch was not authored or co-authored using [Generative Tooling](https://www.apache.org/legal/generative-tooling.html)
## ๐ Committer Pre-Merge Checklist
- [ ] Pull request title is okay.
- [ ] No license issues.
- [ ] Milestone correctly set?
- [ ] Test coverage is ok
- [ ] Assignees are selected.
- [ ] Minimum number of approvals
- [ ] No changes are requested
**Be nice. Be informative.**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5396] SBT build support [kyuubi]
Posted by "davidyuan1223 (via GitHub)" <gi...@apache.org>.
davidyuan1223 commented on PR #5721:
URL: https://github.com/apache/kyuubi/pull/5721#issuecomment-1816099351
The main error in package is the scala plugin's args in kyuubi parent pom
```
<arg>-P:silencer:globalFilters=.*deprecated.*</arg>
<arg>-P:silencer:globalFilters=.*Could not find any member to link for.*</arg>
<arg>-P:silencer:globalFilters=.*undefined in comment for class.*</arg>
```
The sbt error info is if we not override the plugin in pom
```
[error] bad option: -P:silencer:globalFilters=.*deprecated.*
[error] bad option: -P:silencer:globalFilters=.*Could not find any member to link for.*
[error] bad option: -P:silencer:globalFilters=.*undefined in comment for class.*
[error] bad option: -P:silencer:globalFilters=.*deprecated.*
[error] bad option: -P:silencer:globalFilters=.*Could not find any member to link for.*
[error] bad option: -P:silencer:globalFilters=.*undefined in comment for class.*
```
can we remove them?
@pan3793 @cfmcgrady
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5396] SBT build support [kyuubi]
Posted by "davidyuan1223 (via GitHub)" <gi...@apache.org>.
davidyuan1223 commented on PR #5721:
URL: https://github.com/apache/kyuubi/pull/5721#issuecomment-1818458016
https://github.com/ghik/silencer/tree/master
find the root cause, silencer arg is a plugin, need addin in sbtโs KyuubiBuild, I need some time to rebuild a basic KyuubiBuild similar to [SparkBuild](https://github.com/apache/spark/blob/master/project/SparkBuild.scala)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5396][WIP] SBT build support [kyuubi]
Posted by "davidyuan1223 (via GitHub)" <gi...@apache.org>.
davidyuan1223 closed pull request #5721: [KYUUBI #5396][WIP] SBT build support
URL: https://github.com/apache/kyuubi/pull/5721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5396] SBT build support [kyuubi]
Posted by "davidyuan1223 (via GitHub)" <gi...@apache.org>.
davidyuan1223 commented on PR #5721:
URL: https://github.com/apache/kyuubi/pull/5721#issuecomment-1818134892
> Cool. What's the scope of supported modules? Could you add some examples in description for clarification, for either building all modules or part of them?
currently, the main prolem is sbt package can not support some arguments, https://github.com/apache/kyuubi/pull/5721#issuecomment-1816099351 so i can not give the module scope, there hava many module can not package if their pom not override the scala plugin.
i'm not sure this will break the maven build, could you give me some suggest? @cxzl25
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5396] SBT build support [kyuubi]
Posted by "davidyuan1223 (via GitHub)" <gi...@apache.org>.
davidyuan1223 commented on code in PR #5721:
URL: https://github.com/apache/kyuubi/pull/5721#discussion_r1398576799
##########
build/sbt:
##########
@@ -0,0 +1,149 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+SELF=$(cd $(dirname $0) && pwd)
+. "$SELF/util.sh"
+
+# When creating new tests for Spark SQL Hive, the HADOOP_CLASSPATH must contain the hive jars so
+# that we can run Hive to generate the golden answer. This is not required for normal development
+# or testing.
+if [ -n "$HIVE_HOME" ]; then
Review Comment:
my bad, i forget commit the util.sh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5396] SBT build support [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #5721:
URL: https://github.com/apache/kyuubi/pull/5721#issuecomment-1816195237
remove silencer could break the Maven build. cc @cxzl25
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5396] SBT build support [kyuubi]
Posted by "davidyuan1223 (via GitHub)" <gi...@apache.org>.
davidyuan1223 commented on code in PR #5721:
URL: https://github.com/apache/kyuubi/pull/5721#discussion_r1398576799
##########
build/sbt:
##########
@@ -0,0 +1,149 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+SELF=$(cd $(dirname $0) && pwd)
+. "$SELF/util.sh"
+
+# When creating new tests for Spark SQL Hive, the HADOOP_CLASSPATH must contain the hive jars so
+# that we can run Hive to generate the golden answer. This is not required for normal development
+# or testing.
+if [ -n "$HIVE_HOME" ]; then
Review Comment:
my bad, i forget commit the util.sh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5396][WIP] SBT build support [kyuubi]
Posted by "cfmcgrady (via GitHub)" <gi...@apache.org>.
cfmcgrady commented on PR #5721:
URL: https://github.com/apache/kyuubi/pull/5721#issuecomment-1819393766
> find the root cause, silencer arg is a plugin, need added in sbtโs KyuubiBuild,
you are right.
it works after applying the following patch.
```diff
diff --git a/project/Build.scala b/project/Build.scala
index 6f728747b..bc20ebcf8 100644
--- a/project/Build.scala
+++ b/project/Build.scala
@@ -25,6 +25,8 @@ import sbtprotoc.ProtocPlugin.autoImport._
import sbtassembly.AssemblyPlugin.autoImport._
import scala.util.Properties
+import sbt.librarymanagement.{ VersionNumber, SemanticSelector }
+
object KyuubiBuild extends PomBuild {
@@ -48,6 +50,7 @@ object KyuubiBuild extends PomBuild {
val kyuubiCommon = ProjectRef(buildLocation, "kyuubi-common")
val kyuubiServer = ProjectRef(buildLocation, "kyuubi-server")
+ val kyuubiUtilScala = ProjectRef(buildLocation, "kyuubi-util-scala")
val spark3Client = ProjectRef(buildLocation, "spark-3-shaded")
@@ -56,13 +59,76 @@ object KyuubiBuild extends PomBuild {
client, server, ha, _*
) = Seq(
"kyuubi-rest-client", "kyuubi-servers", "worker"
- ).map(ProjectRef(buildLocation, _)).++(Seq(kyuubiCommon, kyuubiServer, spark3Client))
+ ).map(ProjectRef(buildLocation, _)).++(Seq(kyuubiCommon, kyuubiUtilScala, kyuubiServer, spark3Client))
- lazy val sharedSettings = Seq(
+ lazy val sharedSettings = compilerWarningSettings ++ Seq(
SbtPomKeys.profiles.:=(profiles)
)
+ val silencerVersion = "1.7.13"
+ lazy val compilerWarningSettings: Seq[sbt.Def.Setting[_]] = Seq(
+ libraryDependencies ++= {
+ if (VersionNumber(scalaVersion.value).matchesSemVer(SemanticSelector("<2.13.2"))) {
+ Seq(
+ compilerPlugin("com.github.ghik" % "silencer-plugin" % silencerVersion cross CrossVersion.full),
+ "com.github.ghik" % "silencer-lib" % silencerVersion % Provided cross CrossVersion.full
+ )
+ } else {
+ Seq.empty
+ }
+ },
+ (Compile / scalacOptions) ++= {
+ if (VersionNumber(scalaVersion.value).matchesSemVer(SemanticSelector("<2.13.2"))) {
+ Seq(
+ "-Xfatal-warnings",
+ "-deprecation",
+ "-Ywarn-unused-import",
+ "-P:silencer:globalFilters=.*deprecated.*" //regex to catch deprecation warnings and suppress them
+ )
+ } else {
+ Seq(
+ // replace -Xfatal-warnings with fine-grained configuration, since 2.13.2
+ // verbose warning on deprecation, error on all others
+ // see `scalac -Wconf:help` for details
+ "-Wconf:cat=deprecation:wv,any:e",
+ // 2.13-specific warning hits to be muted (as narrowly as possible) and addressed separately
+ "-Wunused:imports",
+ "-Wconf:cat=lint-multiarg-infix:wv",
+ "-Wconf:cat=other-nullary-override:wv",
+ "-Wconf:cat=other-match-analysis&site=org.apache.spark.sql.catalyst.catalog.SessionCatalog.lookupFunction.catalogFunction:wv",
+ "-Wconf:cat=other-pure-statement&site=org.apache.spark.streaming.util.FileBasedWriteAheadLog.readAll.readFile:wv",
+ "-Wconf:cat=other-pure-statement&site=org.apache.spark.scheduler.OutputCommitCoordinatorSuite.<local OutputCommitCoordinatorSuite>.futureAction:wv",
+ "-Wconf:cat=other-pure-statement&site=org.apache.spark.sql.streaming.sources.StreamingDataSourceV2Suite.testPositiveCase.\\$anonfun:wv",
+ // SPARK-33775 Suppress compilation warnings that contain the following contents.
+ // TODO(SPARK-33805): Undo the corresponding deprecated usage suppression rule after
+ // fixed.
+ "-Wconf:msg=^(?=.*?method|value|type|object|trait|inheritance)(?=.*?deprecated)(?=.*?since 2.13).+$:s",
+ "-Wconf:msg=^(?=.*?Widening conversion from)(?=.*?is deprecated because it loses precision).+$:s",
+ "-Wconf:msg=Auto-application to \\`\\(\\)\\` is deprecated:s",
+ "-Wconf:msg=method with a single empty parameter list overrides method without any parameter list:s",
+ "-Wconf:msg=method without a parameter list overrides a method with a single empty one:s",
+ // SPARK-35574 Prevent the recurrence of compilation warnings related to `procedure syntax is deprecated`
+ "-Wconf:cat=deprecation&msg=procedure syntax is deprecated:e",
+ // SPARK-35496 Upgrade Scala to 2.13.7 and suppress:
+ // 1. `The outer reference in this type test cannot be checked at run time`
+ // 2. `the type test for pattern TypeA cannot be checked at runtime because it
+ // has type parameters eliminated by erasure`
+ // 3. `abstract type TypeA in type pattern Seq[TypeA] (the underlying of
+ // Seq[TypeA]) is unchecked since it is eliminated by erasure`
+ // 4. `fruitless type test: a value of TypeA cannot also be a TypeB`
+ "-Wconf:cat=unchecked&msg=outer reference:s",
+ "-Wconf:cat=unchecked&msg=eliminated by erasure:s",
+ "-Wconf:msg=^(?=.*?a value of type)(?=.*?cannot also be).+$:s",
+ // TODO(SPARK-43850): Remove the following suppression rules and remove `import scala.language.higherKinds`
+ // from the corresponding files when Scala 2.12 is no longer supported.
+ "-Wconf:cat=unused-imports&src=org\\/apache\\/spark\\/graphx\\/impl\\/VertexPartitionBase.scala:s",
+ "-Wconf:cat=unused-imports&src=org\\/apache\\/spark\\/graphx\\/impl\\/VertexPartitionBaseOps.scala:s"
+ )
+ }
+ }
+ )
+
val projectsMap: Map[String, Seq[Setting[_]]] = Map.empty
def enable(settings: Seq[Setting[_]])(projectRef: ProjectRef): Any = {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5396][WIP] SBT build support [kyuubi]
Posted by "davidyuan1223 (via GitHub)" <gi...@apache.org>.
davidyuan1223 commented on PR #5721:
URL: https://github.com/apache/kyuubi/pull/5721#issuecomment-1823772322
@cfmcgrady hello, could you give me some adive, i have add the property ``` sbt.project.name ``` for every project's pom, but the sbt can not resolve all of them, i only can get thos projects
```
sbt:kyuubi-parent> projects
[info] In file:/Users/fuyuanyuan/Programs/code/github/kyuubi/
[info] integration-tests
[info] * kyuubi
[info] kyuubi-assembly
[info] kyuubi-chat-engine
[info] kyuubi-codecov
[info] kyuubi-common
[info] kyuubi-ctl
[info] kyuubi-download
[info] kyuubi-events
[info] kyuubi-extension-spark-jdbc-dialect
[info] kyuubi-flink-it
[info] kyuubi-flink-sql-engine
[info] kyuubi-ha
[info] kyuubi-hive-beeline
[info] kyuubi-hive-it
[info] kyuubi-hive-jdbc
[info] kyuubi-hive-jdbc-shaded
[info] kyuubi-hive-sql-engine
[info] kyuubi-jdbc-engine
[info] kyuubi-jdbc-it
[info] kyuubi-metrics
[info] kyuubi-rest-client
[info] kyuubi-server
[info] kyuubi-server-plugin
[info] kyuubi-spark-authz
[info] kyuubi-spark-authz-shaded
[info] kyuubi-spark-connector-common
[info] kyuubi-spark-connector-tpcds
[info] kyuubi-spark-connector-tpch
[info] kyuubi-spark-lineage
[info] kyuubi-spark-sql-engine
[info] kyuubi-trino-it
[info] kyuubi-trino-sql-engine
[info] kyuubi-util
[info] kyuubi-util-scala
[info] kyuubi-zookeeper
[info] kyuubi-zookeeper-it
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5396] SBT build support [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #5721:
URL: https://github.com/apache/kyuubi/pull/5721#discussion_r1397110504
##########
build/sbt:
##########
@@ -0,0 +1,149 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+SELF=$(cd $(dirname $0) && pwd)
+. "$SELF/util.sh"
+
+# When creating new tests for Spark SQL Hive, the HADOOP_CLASSPATH must contain the hive jars so
+# that we can run Hive to generate the golden answer. This is not required for normal development
+# or testing.
+if [ -n "$HIVE_HOME" ]; then
Review Comment:
consider copying this file from celeborn projects, we did some explores and optimization before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5396] SBT build support [kyuubi]
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on PR #5721:
URL: https://github.com/apache/kyuubi/pull/5721#issuecomment-1818111248
Cool. What's the scope of supported modules? Could you add some examples in description for clarification, for either building all modules or part of them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5396][WIP] SBT build support [kyuubi]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5721:
URL: https://github.com/apache/kyuubi/pull/5721#issuecomment-1823770917
## [Codecov](https://app.codecov.io/gh/apache/kyuubi/pull/5721?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`765cdaa`)](https://app.codecov.io/gh/apache/kyuubi/commit/765cdaa2552dbf0a4f3fbf71c376a17b07abd33d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 61.33% compared to head [(`50db01c`)](https://app.codecov.io/gh/apache/kyuubi/pull/5721?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 61.35%.
> Report is 22 commits behind head on master.
> :exclamation: Current head 50db01c differs from pull request most recent head 76ef642. Consider uploading reports for the commit 76ef642 to get more accurate results
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #5721 +/- ##
============================================
+ Coverage 61.33% 61.35% +0.01%
Complexity 23 23
============================================
Files 607 607
Lines 35817 35820 +3
Branches 4912 4912
============================================
+ Hits 21967 21976 +9
+ Misses 11466 11463 -3
+ Partials 2384 2381 -3
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/kyuubi/pull/5721?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org