[GitHub] [inlong] liangyepianzhou commented on a diff in pull request #5239: [INLONG-5238][DataProxy] Error metric params in addSendFailMetric

[GitBox <gi...@apache.org>]

liangyepianzhou commented on code in PR #5239:
URL: https://github.com/apache/inlong/pull/5239#discussion_r930896472


##########
inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/sink/pulsarzone/PulsarZoneSinkContext.java:
##########
@@ -192,7 +192,7 @@ public void addSendMetric(DispatchProfile currentRecord, String bid) {
      */
     public void addSendFailMetric() {
         Map<String, String> dimensions = new HashMap<>();
-        dimensions.put(DataProxyMetricItem.KEY_CLUSTER_ID, this.getProxyClusterId());
+        dimensions.put(DataProxyMetricItem.KEY_CLUSTER_ID, this.getClusterId());

Review Comment:
   The method `getClusterId() ` is exist in `SinkContext`.
   The `KafkaZoneSinkContext` and TubeZoneSinkContext are also using the the method `getClusterId() ` existing in `SinkContext`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org