You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "elirehema (via GitHub)" <gi...@apache.org> on 2024/03/02 10:06:00 UTC
[PR] Use Lombok Getter annotation in password on AppUserPreviousPassword [fineract]
elirehema opened a new pull request, #3777:
URL: https://github.com/apache/fineract/pull/3777
## Description
Use Lombok @Getter annotation in password on AppUserPreviousPassword POJO class
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use Lombok Getter annotation in password on AppUserPreviousPassword [fineract]
Posted by "Zeyad2003 (via GitHub)" <gi...@apache.org>.
Zeyad2003 commented on PR #3777:
URL: https://github.com/apache/fineract/pull/3777#issuecomment-1987212815
Hi @elirehema
Please refer to the [CONTRIBUTING.md](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md).
You need to mention the Jira ticket in your PR to be reviewed and track the changes.
Regards!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use Lombok Getter annotation in password on AppUserPreviousPassword [fineract]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3777:
URL: https://github.com/apache/fineract/pull/3777#issuecomment-2046232400
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use Lombok Getter annotation in password on AppUserPreviousPassword [fineract]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #3777: Use Lombok Getter annotation in password on AppUserPreviousPassword
URL: https://github.com/apache/fineract/pull/3777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org