You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by Luca Furini <lf...@cs.unibo.it> on 2005/07/29 12:58:53 UTC

Re: svn commit: r225580 - /xmlgraphics/fop/trunk/test/layoutengine/testcases/page-master4.xml

Jeremias Maerki wrote:

> Add margin on simple-page-master as additional feature.

ATM, doesn't this raise a PropertyException saying that "Border and 
padding for a region must be 0"?

The XSL 1.0 Recommendation states that "borders and padding are not 
allowed with a page-reference-area" (6.4.12 fo:simple-page-master) and 
that "the values of the padding and border-width traits must be 0." 
(6.4.13 fo:region-body and for the other regions). This is not supposed to 
change even in the upcoming 1.1 version, looking at the working 
draft.

As having a border (and a padding too, necessarily) around the page is not 
such an uncommon and unlikely situation, I was wondering if FOP should not 
allow it, just warning the user about the non-standard feature that she/he 
is using.

FWIW both xep and xslFormatter allows borders and paddings in a region; 
xep warns that they are extensions, the other says nothing.

I agree that "everybody does this, why shouldn't we" is not a good reason; 
but in this case there is a real need that cannot be satisfied in a 
standard way.

For example, I tried to achieve the same result by setting a background 
color for the page, and partially "covering" it with white regions ... but 
a simple-page-master cannot have a background-color attribute according to 
the standard! :-(

Regards
     Luca



Re: svn commit: r225580 - /xmlgraphics/fop/trunk/test/layoutengine/testcases/page-master4.xml

Posted by Christian Geisert <ch...@isu-gmbh.de>.
Jeremias Maerki schrieb:

[..]

> I think that's a feature that has been asked for many times. It would be
> totally easy to allow a background on the simple-page-master. Again, we
> can let it fail with strict validation and issue a warning about the
> non-standard feature when strict validation is off.
> 
> WDYT?

+1

Christian

Re: svn commit: r225580 - /xmlgraphics/fop/trunk/test/layoutengine/testcases/page-master4.xml

Posted by "J.Pietschmann" <j3...@yahoo.de>.
Jeremias Maerki wrote:
> I think that's a feature that has been asked for many times. It would be
> totally easy to allow a background on the simple-page-master. Again, we
> can let it fail with strict validation and issue a warning about the
> non-standard feature when strict validation is off.
> 
> WDYT?

+1

J.Pietschmann

Re: svn commit: r225580 - /xmlgraphics/fop/trunk/test/layoutengine/testcases/page-master4.xml

Posted by Jeremias Maerki <de...@greenmail.ch>.
Ahem, switching on my brain now.

Actually, there's no problem with the thing I did. There's no connection
of the margins to borders and padding in simple-page-master. These are
separate features. Still, having border and background on
simple-page-master is not a bad idea.

On 29.07.2005 13:28:54 Jeremias Maerki wrote:
> 
> On 29.07.2005 12:58:53 Luca Furini wrote:
> > Jeremias Maerki wrote:
> > 
> > > Add margin on simple-page-master as additional feature.
> > 
> > ATM, doesn't this raise a PropertyException saying that "Border and 
> > padding for a region must be 0"?
> 
> Nope. Doesn't look like it.
> 
> > The XSL 1.0 Recommendation states that "borders and padding are not 
> > allowed with a page-reference-area" (6.4.12 fo:simple-page-master) and 
> > that "the values of the padding and border-width traits must be 0." 
> > (6.4.13 fo:region-body and for the other regions). This is not supposed to 
> > change even in the upcoming 1.1 version, looking at the working 
> > draft.
> 
> Guilty as charged. I didn't remember that little detail. I did tests
> with a document that had this, so I tried it and it worked. :-)
> 
> > As having a border (and a padding too, necessarily) around the page is not 
> > such an uncommon and unlikely situation, I was wondering if FOP should not 
> > allow it, just warning the user about the non-standard feature that she/he 
> > is using.
> > 
> > FWIW both xep and xslFormatter allows borders and paddings in a region; 
> > xep warns that they are extensions, the other says nothing.
> > 
> > I agree that "everybody does this, why shouldn't we" is not a good reason; 
> > but in this case there is a real need that cannot be satisfied in a 
> > standard way.
> 
> Well, it doesn't hurt so much to do this. I think we should let this
> fail when strict validation is on, and issue a warning when strict
> validation is off. 
> 
> > For example, I tried to achieve the same result by setting a background 
> > color for the page, and partially "covering" it with white regions ... but 
> > a simple-page-master cannot have a background-color attribute according to 
> > the standard! :-(
> 
> I think that's a feature that has been asked for many times. It would be
> totally easy to allow a background on the simple-page-master. Again, we
> can let it fail with strict validation and issue a warning about the
> non-standard feature when strict validation is off.
> 
> WDYT?
> 
> 
> Jeremias Maerki



Jeremias Maerki


Re: svn commit: r225580 - /xmlgraphics/fop/trunk/test/layoutengine/testcases/page-master4.xml

Posted by Jeremias Maerki <de...@greenmail.ch>.
On 29.07.2005 12:58:53 Luca Furini wrote:
> Jeremias Maerki wrote:
> 
> > Add margin on simple-page-master as additional feature.
> 
> ATM, doesn't this raise a PropertyException saying that "Border and 
> padding for a region must be 0"?

Nope. Doesn't look like it.

> The XSL 1.0 Recommendation states that "borders and padding are not 
> allowed with a page-reference-area" (6.4.12 fo:simple-page-master) and 
> that "the values of the padding and border-width traits must be 0." 
> (6.4.13 fo:region-body and for the other regions). This is not supposed to 
> change even in the upcoming 1.1 version, looking at the working 
> draft.

Guilty as charged. I didn't remember that little detail. I did tests
with a document that had this, so I tried it and it worked. :-)

> As having a border (and a padding too, necessarily) around the page is not 
> such an uncommon and unlikely situation, I was wondering if FOP should not 
> allow it, just warning the user about the non-standard feature that she/he 
> is using.
> 
> FWIW both xep and xslFormatter allows borders and paddings in a region; 
> xep warns that they are extensions, the other says nothing.
> 
> I agree that "everybody does this, why shouldn't we" is not a good reason; 
> but in this case there is a real need that cannot be satisfied in a 
> standard way.

Well, it doesn't hurt so much to do this. I think we should let this
fail when strict validation is on, and issue a warning when strict
validation is off. 

> For example, I tried to achieve the same result by setting a background 
> color for the page, and partially "covering" it with white regions ... but 
> a simple-page-master cannot have a background-color attribute according to 
> the standard! :-(

I think that's a feature that has been asked for many times. It would be
totally easy to allow a background on the simple-page-master. Again, we
can let it fail with strict validation and issue a warning about the
non-standard feature when strict validation is off.

WDYT?


Jeremias Maerki