[GitHub] [pulsar] sijie commented on a change in pull request #6717: Avoid prefetch too much data when offloading data to HDFS

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #6717: Avoid prefetch too much data when offloading data to HDFS
URL: https://github.com/apache/pulsar/pull/6717#discussion_r407970453
 
 

 ##########
 File path: tiered-storage/file-system/src/main/java/org/apache/bookkeeper/mledger/offload/filesystem/impl/FileSystemManagedLedgerOffloader.java
 ##########
 @@ -188,13 +192,17 @@ public void run() {
                 AtomicLong haveOffloadEntryNumber = new AtomicLong(0);
                 long needToOffloadFirstEntryNumber = 0;
                 CountDownLatch countDownLatch;
+                //avoid prefetch too much data into memory
+                Semaphore semaphore = new Semaphore(1);
 
 Review comment:
   Can we make this configurable? I am worried about this will cause performance problems.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services