Re: [VOTE] Release Commons Pool 2.3 based on RC2

[Benedikt Ritter <br...@apache.org>]

Hello Phil,

builds fine on OSX with Maven 3.2.5 and JDK 1.6, 1.7, 1.8 and 1.9 EA.
Site build even works with JDK 1.8!
Signs and hashes look good.
The tests take forever, but that has been discussed on the other thread
already

one thing caught my eye. When comparing the src.tar.gz with the tag I've
found some differences. Those are all missing empty lines at EOF in the
src.tar.gz. Don't know how this is possible. Maybe it's the archiver:

$ diff -wrq commons-pool2-2.3-src POOL_2_3_RC2/
Files commons-pool2-2.3-src/RELEASE-NOTES.txt and
POOL_2_3_RC2/RELEASE-NOTES.txt differ
Only in POOL_2_3_RC2/: doap_pool.rdf
Only in POOL_2_3_RC2/: pool-RC.sh
Only in POOL_2_3_RC2/: pool-pre-RC.sh
Only in POOL_2_3_RC2/: pool-release.sh
Files commons-pool2-2.3-src/src/changes/release-notes.vm and
POOL_2_3_RC2/src/changes/release-notes.vm differ
Files commons-pool2-2.3-src/src/main/assembly/src-tar-gz.xml and
POOL_2_3_RC2/src/main/assembly/src-tar-gz.xml differ
Files
commons-pool2-2.3-src/src/main/java/org/apache/commons/pool2/KeyedPooledObjectFactory.java
and
POOL_2_3_RC2/src/main/java/org/apache/commons/pool2/KeyedPooledObjectFactory.java
differ
Files
commons-pool2-2.3-src/src/main/java/org/apache/commons/pool2/proxy/JdkProxyHandler.java
and
POOL_2_3_RC2/src/main/java/org/apache/commons/pool2/proxy/JdkProxyHandler.java
differ
Files
commons-pool2-2.3-src/src/test/java/org/apache/commons/pool2/impl/TestAbandonedObjectPool.java
and
POOL_2_3_RC2/src/test/java/org/apache/commons/pool2/impl/TestAbandonedObjectPool.java
differ
Files
commons-pool2-2.3-src/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java
and
POOL_2_3_RC2/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java
differ

+1

Benedikt


2014-12-27 0:54 GMT+01:00 Phil Steitz <ph...@gmail.com>:
>
> Changes since RC1:
> * Made POOL-259 tests less sensitive to system clock resolution
> * Moved LinkedBlockingDeque original PD license reference from
> NOTICE to LICENSE
>
> Tag: (r1648018)
> https://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_3_RC2/
>
> Release: (r7602)
> https://dist.apache.org/repos/dist/dev/commons/pool/
>
> Maven:
> https://repository.apache.org/content/repositories/orgapachecommons-1072
>
> Site:
> http://people.apache.org/~psteitz/pool/pool-2.3-rc2/
>
> Release notes:
> https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt
>
> Votes, please.  This vote will close in 72 hours (29-Dec 23:55 GMT)
>
> [ ] +1 Release this
> [ ] +0 Ok, but...
> [ ] -0  Really should fix...
> [ ] -1 We should not release this RC
>
> Thanks!
>
> Phil
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

-- 
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter