[GitHub] [arrow] nealrichardson commented on a change in pull request #7623: ARROW-9108: [C++][Dataset] Add supports for missing type in Statistics to Scalar conversion

[GitBox <gi...@apache.org>]

nealrichardson commented on a change in pull request #7623:
URL: https://github.com/apache/arrow/pull/7623#discussion_r451810399



##########
File path: python/pyarrow/_dataset.pyx
##########
@@ -881,10 +881,15 @@ cdef class RowGroupInfo:
             name = frombytes(c_statistics.type.get().field(i).get().name())
             c_minmax = <CStructScalar*> c_statistics.value[i].get()
 
-            statistics[name] = {
-                'min': pyarrow_wrap_scalar(c_minmax.value[0]).as_py(),
-                'max': pyarrow_wrap_scalar(c_minmax.value[1]).as_py(),
-            }
+            try:
+                statistics[name] = {
+                    'min': pyarrow_wrap_scalar(c_minmax.value[0]).as_py(),
+                    'max': pyarrow_wrap_scalar(c_minmax.value[1]).as_py(),
+                }
+            except ValueError:
+                # Don't treat failure to parse/convert a single Scalar as a
+                # failure. The min/max will simply be missing for this field.

Review comment:
       We should support Scalars of all types, so it should not be possible for this to error, and if it does, it's a bug. IMO we should remove the try/except and move on.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org