You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2018/05/03 17:45:00 UTC
[jira] [Commented] (ASTERIXDB-2370) Inconsistent method name
[ https://issues.apache.org/jira/browse/ASTERIXDB-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462845#comment-16462845 ]
ASF subversion and git services commented on ASTERIXDB-2370:
------------------------------------------------------------
Commit 23e1a700d7fff56e7f289f41cf8c44c472eb3f00 in asterixdb's branch refs/heads/master from [~BruceKuiLIU]
[ https://git-wip-us.apache.org/repos/asf?p=asterixdb.git;h=23e1a70 ]
[ASTERIXDB-2370][*DB] Modify the inconsistent method name "isFull"
- taken from https://github.com/apache/asterixdb/pull/7
The method is named as "isFull". However, the method does set the boolean
variable full. Thus, rename the method as "setFull" should be more
intuitive than "isFull" since "isFull" is a query asking whether the
object is full or not.
Change-Id: I99bf451367171afb3fc0511a6170eb4c492fc69f
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2629
Contrib: Michael Blow <mb...@apache.org>
Integration-Tests: Michael Blow <mb...@apache.org>
Tested-by: Michael Blow <mb...@apache.org>
Sonar-Qube: Jenkins <je...@fulliautomatix.ics.uci.edu>
Contrib: Jenkins <je...@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <je...@fulliautomatix.ics.uci.edu>
Integration-Tests: Jenkins <je...@fulliautomatix.ics.uci.edu>
Reviewed-by: Murtadha Hubail <mh...@apache.org>
> Inconsistent method name
> ------------------------
>
> Key: ASTERIXDB-2370
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-2370
> Project: Apache AsterixDB
> Issue Type: Improvement
> Reporter: KuiLIU
> Priority: Major
>
> The following method is named as "isFull".
> However, the method does set the boolean-variable full.
> Thus, rename the method as "setFull" should be more intuitive than "isFull" since "isFull" is a query asking whether the object is full or not.
> {code:java}
> public synchronized void isFull(boolean full) {
> this.full.set(full);
> this.notify();
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)