[GitHub] [pulsar] eolivelli commented on a change in pull request #12150: PIP-45: Only run ZKSessionWatcher when MetadataStoreExtended is required

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #12150:
URL: https://github.com/apache/pulsar/pull/12150#discussion_r714736077



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/common/naming/NamespaceBundleFactory.java
##########
@@ -50,7 +50,7 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-public class NamespaceBundleFactory {
+public class    NamespaceBundleFactory {

Review comment:
       nit: remove spaces

##########
File path: pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/ZKMetadataStore.java
##########
@@ -73,13 +74,15 @@ public ZKMetadataStore(String metadataURL, MetadataStoreConfig metadataStoreConf
                     .allowReadOnlyMode(metadataStoreConfig.isAllowReadOnlyOperations())
                     .sessionTimeoutMs(metadataStoreConfig.getSessionTimeoutMillis())
                     .watchers(Collections.singleton(event -> {

Review comment:
       if enableSessionWatcher is false we can skip adding the watcher at all, can't we ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org