You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/02/19 11:48:35 UTC

[GitHub] [calcite-avatica] zabetak commented on a change in pull request #105: [CALCITE-3163] AbstractCursor#convertValue() now adheres to JDBC specification

zabetak commented on a change in pull request #105:
URL: https://github.com/apache/calcite-avatica/pull/105#discussion_r579128481



##########
File path: core/src/main/java/org/apache/calcite/avatica/util/AbstractCursor.java
##########
@@ -1318,8 +1318,9 @@ private Object convertValue() throws SQLException {
         return componentAccessor.getInt();
       case Types.BIGINT:
         return componentAccessor.getLong();
-      case Types.FLOAT:
+      case Types.REAL:
         return componentAccessor.getFloat();
+      case Types.FLOAT:

Review comment:
       The fix looks reasonable but I was thinking that it would be nice to have some tests to guard against future regressions. Maybe in `ArrayTypeTest`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org