You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "linghengqian (via GitHub)" <gi...@apache.org> on 2024/02/10 16:24:37 UTC
[PR] Add GraalVM Reachability Metadata and corresponding nativeTest for Atomikos and Narayana integration [shardingsphere]
linghengqian opened a new pull request, #30085:
URL: https://github.com/apache/shardingsphere/pull/30085
For #29052.
Changes proposed in this pull request:
- Add GraalVM Reachability Metadata and corresponding nativeTest for Atomikos and Narayana integration.
- Temporarily actively hosting the GraalVM Reachability Metadata at `org.jboss.narayana.jta:jta:5.12.4.Final`.
- Temporarily actively hosting the GraalVM Reachability Metadata at `com.atomikos:transactions:6.0.0`.
- According to the convention of `examples/shardingsphere-jdbc-example-generator/src/main/resources/config.yaml`, rename `org.apache.shardingsphere.test.natived.jdbc.mode.**` to `org.apache.shardingsphere.test.natived.jdbc.modes.**`.
- Due to https://github.blog/2024-01-17-github-hosted-runners-double-the-power-for-open-source/ , GitHub-hosted runners now have 4-vCPUs, 16 GiB of memory and 150GiB storage, double the configuration. This eliminates the need to pass the `-J-Xmx7g` buildArg to the native-image constructor. GraalVM CE 23.1.2 For JDK 21.0.2 will use 75% of the system's maximum memory by default to build the GraalVM Native Image.
- Rename `<arg/>` tag to `<buildArg/>` tag following clarification from https://github.com/graalvm/native-build-tools/pull/551 .
- Temporarily actively hosting the GraalVM Reachability Metadata at `com.h2database:h2:2.2.224`. This involves multiple levels of issues.
- There are no unit tests involving the XADataSource interface for any JDBC driver in the GraalVM Reachability Metadata central repository.
- There is no unit test of the XADataSource interface for any JDBC driver in the Spring team's smoketest.
- Except for PostgreSQL and Oracle Database, there is no way to expect any JDBC driver to actively maintain its own GraalVM Reachability Metadata. We can expect that all JDBC drivers currently require manual addition of the GraalVM Reachability Metadata entry for the XADataSource. I'm only adding the GraalVM Reachability Metadata entry for H2Database here, simply meaning that the relevant JSON entries are needed for the unit tests. This does not mean that other JDBC drivers do not require additional JSON entries.
- In any case, I don’t want us to waste time on third-party dependencies of GraalVM Reachability Metadata. This should be handled on the GraalVM Reachability Metadata central repository side.
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [x] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add GraalVM Reachability Metadata and corresponding nativeTest for Atomikos and Narayana integration [shardingsphere]
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu merged PR #30085:
URL: https://github.com/apache/shardingsphere/pull/30085
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org