You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by jongyoul <gi...@git.apache.org> on 2018/07/09 06:18:16 UTC
[GitHub] zeppelin pull request #3058: [ZEPPELIN-3593] Change LuceneSearch's directory...
GitHub user jongyoul opened a pull request:
https://github.com/apache/zeppelin/pull/3058
[ZEPPELIN-3593] Change LuceneSearch's directory to file system from memory
### What is this PR for?
Reducing a usage of memory by moving Lucene search's directory to the file system
### What type of PR is it?
[Improvement]
### Todos
* [ ] - Replace `RamDirectory` to `MMapDirectory`
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3593
### How should this be tested?
It doesn't affect any current behaviors. Test search service
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jongyoul/zeppelin ZEPPELIN-3593
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3058.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3058
----
commit 154d4b4aa5b28a5ac05dd827e22a2d1e09b66438
Author: Jongyoul Lee <jo...@...>
Date: 2018-07-09T05:54:33Z
Replace `RamDirectory` to `MMapDirectory` provided by Lucene
commit e8e7589bd8c26b54d321d90056fdcbc09a876eb6
Author: Jongyoul Lee <jo...@...>
Date: 2018-07-09T06:13:12Z
Add deletion logic for the temporary directory
----
---
[GitHub] zeppelin pull request #3058: [ZEPPELIN-3593] Change LuceneSearch's directory...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/3058
---
[GitHub] zeppelin issue #3058: [ZEPPELIN-3593] Change LuceneSearch's directory to fil...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/3058
Yes, agreed at that point. But in case where users add new notes manually,
we cannot know them. It means we should read all of indexes and match them
to sync file system and indexes. So I suggest to reduce memory usage at
first and then think how to increase the performance of indexes later.
On Mon, 9 Jul 2018 at 5:37 PM Jeff Zhang <no...@github.com> wrote:
> Will zeppelin reindex all notes when zeppelin server is restarted ? If we
> store it in file system, we should be able to avoid this kind of reindex.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/zeppelin/pull/3058#issuecomment-403403584>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/ADcflpemFfrSJJ2mUONMzq-mLmAFSR05ks5uExZagaJpZM4VHIzc>
> .
>
--
이종열, Jongyoul Lee, 李宗烈
http://madeng.net
---
[GitHub] zeppelin issue #3058: [ZEPPELIN-3593] Change LuceneSearch's directory to fil...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3058
Will zeppelin reindex all notes when zeppelin server is restarted ? If we store it in file system, we should be able to avoid this kind of reindex.
---
[GitHub] zeppelin issue #3058: [ZEPPELIN-3593] Change LuceneSearch's directory to fil...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3058
Thanks @jongyoul feel free to create followup ticket.
---