You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Radim Kolar (JIRA)" <ji...@apache.org> on 2012/07/24 22:48:33 UTC
[jira] [Created] (HADOOP-8619) WritableComparator must implement
no-arg constructor
Radim Kolar created HADOOP-8619:
-----------------------------------
Summary: WritableComparator must implement no-arg constructor
Key: HADOOP-8619
URL: https://issues.apache.org/jira/browse/HADOOP-8619
Project: Hadoop Common
Issue Type: Improvement
Components: io
Affects Versions: 3.0.0
Reporter: Radim Kolar
Fix For: 3.0.0, 2.0.0-alpha, 0.23.0
Attachments: writable-comparator.txt
Because of reasons listed here: http://findbugs.sourceforge.net/bugDescriptions.html#SE_COMPARATOR_SHOULD_BE_SERIALIZABLE
comparators should be serializable. To make deserialization work, it is required that all superclasses have no-arg constructor. http://findbugs.sourceforge.net/bugDescriptions.html#SE_NO_SUITABLE_CONSTRUCTOR
Simply add no=arg constructor to WritableComparator.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8619) WritableComparator must implement
no-arg constructor
Posted by "Radim Kolar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443179#comment-13443179 ]
Radim Kolar commented on HADOOP-8619:
-------------------------------------
I need 2.1.0-alpha branch as well. I have plans to test it soon after i will fix compile error.
> WritableComparator must implement no-arg constructor
> ----------------------------------------------------
>
> Key: HADOOP-8619
> URL: https://issues.apache.org/jira/browse/HADOOP-8619
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 3.0.0
> Reporter: Radim Kolar
> Assignee: Chris Douglas
> Fix For: 0.23.0, 2.0.0-alpha, 3.0.0
>
> Attachments: 8619-0.patch, writable-comparator.txt
>
>
> Because of reasons listed here: http://findbugs.sourceforge.net/bugDescriptions.html#SE_COMPARATOR_SHOULD_BE_SERIALIZABLE
> comparators should be serializable. To make deserialization work, it is required that all superclasses have no-arg constructor. http://findbugs.sourceforge.net/bugDescriptions.html#SE_NO_SUITABLE_CONSTRUCTOR
> Simply add no=arg constructor to WritableComparator.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8619) WritableComparator must implement
no-arg constructor
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431940#comment-13431940 ]
Steve Loughran commented on HADOOP-8619:
----------------------------------------
I don't see this breaking anything, and it lets people chose how they serialise stuff, that's their choice.
+1
> WritableComparator must implement no-arg constructor
> ----------------------------------------------------
>
> Key: HADOOP-8619
> URL: https://issues.apache.org/jira/browse/HADOOP-8619
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 3.0.0
> Reporter: Radim Kolar
> Fix For: 0.23.0, 2.0.0-alpha, 3.0.0
>
> Attachments: writable-comparator.txt
>
>
> Because of reasons listed here: http://findbugs.sourceforge.net/bugDescriptions.html#SE_COMPARATOR_SHOULD_BE_SERIALIZABLE
> comparators should be serializable. To make deserialization work, it is required that all superclasses have no-arg constructor. http://findbugs.sourceforge.net/bugDescriptions.html#SE_NO_SUITABLE_CONSTRUCTOR
> Simply add no=arg constructor to WritableComparator.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8619) WritableComparator must implement
no-arg constructor
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444077#comment-13444077 ]
Hudson commented on HADOOP-8619:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #1180 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1180/])
HADOOP-8619. WritableComparator must implement no-arg constructor. Contributed by Chris Douglas. (Revision 1378120)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1378120
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/WritableComparator.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/serializer/TestWritableSerialization.java
> WritableComparator must implement no-arg constructor
> ----------------------------------------------------
>
> Key: HADOOP-8619
> URL: https://issues.apache.org/jira/browse/HADOOP-8619
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 3.0.0
> Reporter: Radim Kolar
> Assignee: Chris Douglas
> Fix For: 0.23.0, 2.0.0-alpha, 3.0.0
>
> Attachments: 8619-0.patch, writable-comparator.txt
>
>
> Because of reasons listed here: http://findbugs.sourceforge.net/bugDescriptions.html#SE_COMPARATOR_SHOULD_BE_SERIALIZABLE
> comparators should be serializable. To make deserialization work, it is required that all superclasses have no-arg constructor. http://findbugs.sourceforge.net/bugDescriptions.html#SE_NO_SUITABLE_CONSTRUCTOR
> Simply add no=arg constructor to WritableComparator.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8619) WritableComparator must implement
no-arg constructor
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443144#comment-13443144 ]
Hudson commented on HADOOP-8619:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #2649 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2649/])
HADOOP-8619. WritableComparator must implement no-arg constructor. Contributed by Chris Douglas. (Revision 1378120)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1378120
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/WritableComparator.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/serializer/TestWritableSerialization.java
> WritableComparator must implement no-arg constructor
> ----------------------------------------------------
>
> Key: HADOOP-8619
> URL: https://issues.apache.org/jira/browse/HADOOP-8619
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 3.0.0
> Reporter: Radim Kolar
> Assignee: Chris Douglas
> Fix For: 0.23.0, 2.0.0-alpha, 3.0.0
>
> Attachments: 8619-0.patch, writable-comparator.txt
>
>
> Because of reasons listed here: http://findbugs.sourceforge.net/bugDescriptions.html#SE_COMPARATOR_SHOULD_BE_SERIALIZABLE
> comparators should be serializable. To make deserialization work, it is required that all superclasses have no-arg constructor. http://findbugs.sourceforge.net/bugDescriptions.html#SE_NO_SUITABLE_CONSTRUCTOR
> Simply add no=arg constructor to WritableComparator.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8619) WritableComparator must implement
no-arg constructor
Posted by "Yanbo Liang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13423736#comment-13423736 ]
Yanbo Liang commented on HADOOP-8619:
-------------------------------------
In Hadoop, the serialization/deserialization is implemented by Writable interface. I wonder whether there are some requirements to use the Java serialization system. If all the serialization system is accomplished by Writable interface, I think this issue is not necessary.
> WritableComparator must implement no-arg constructor
> ----------------------------------------------------
>
> Key: HADOOP-8619
> URL: https://issues.apache.org/jira/browse/HADOOP-8619
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 3.0.0
> Reporter: Radim Kolar
> Fix For: 0.23.0, 2.0.0-alpha, 3.0.0
>
> Attachments: writable-comparator.txt
>
>
> Because of reasons listed here: http://findbugs.sourceforge.net/bugDescriptions.html#SE_COMPARATOR_SHOULD_BE_SERIALIZABLE
> comparators should be serializable. To make deserialization work, it is required that all superclasses have no-arg constructor. http://findbugs.sourceforge.net/bugDescriptions.html#SE_NO_SUITABLE_CONSTRUCTOR
> Simply add no=arg constructor to WritableComparator.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8619) WritableComparator must implement
no-arg constructor
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431963#comment-13431963 ]
Steve Loughran commented on HADOOP-8619:
----------------------------------------
Before committing this, I'm going to add one more bit of homework:
add a test that serializes then deserializes something of the std. writables.
Why? Your goal is to ser/deser things -the ctor is just a means to that end. Add a test of the desired behaviour and you can be confident that it doesn't break in future.
> WritableComparator must implement no-arg constructor
> ----------------------------------------------------
>
> Key: HADOOP-8619
> URL: https://issues.apache.org/jira/browse/HADOOP-8619
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 3.0.0
> Reporter: Radim Kolar
> Fix For: 0.23.0, 2.0.0-alpha, 3.0.0
>
> Attachments: writable-comparator.txt
>
>
> Because of reasons listed here: http://findbugs.sourceforge.net/bugDescriptions.html#SE_COMPARATOR_SHOULD_BE_SERIALIZABLE
> comparators should be serializable. To make deserialization work, it is required that all superclasses have no-arg constructor. http://findbugs.sourceforge.net/bugDescriptions.html#SE_NO_SUITABLE_CONSTRUCTOR
> Simply add no=arg constructor to WritableComparator.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8619) WritableComparator must implement
no-arg constructor
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443163#comment-13443163 ]
Suresh Srinivas commented on HADOOP-8619:
-----------------------------------------
Committed the patch to 0.23 and branch-2 as well.
> WritableComparator must implement no-arg constructor
> ----------------------------------------------------
>
> Key: HADOOP-8619
> URL: https://issues.apache.org/jira/browse/HADOOP-8619
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 3.0.0
> Reporter: Radim Kolar
> Assignee: Chris Douglas
> Fix For: 0.23.0, 2.0.0-alpha, 3.0.0
>
> Attachments: 8619-0.patch, writable-comparator.txt
>
>
> Because of reasons listed here: http://findbugs.sourceforge.net/bugDescriptions.html#SE_COMPARATOR_SHOULD_BE_SERIALIZABLE
> comparators should be serializable. To make deserialization work, it is required that all superclasses have no-arg constructor. http://findbugs.sourceforge.net/bugDescriptions.html#SE_NO_SUITABLE_CONSTRUCTOR
> Simply add no=arg constructor to WritableComparator.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8619) WritableComparator must implement
no-arg constructor
Posted by "Radim Kolar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13424523#comment-13424523 ]
Radim Kolar commented on HADOOP-8619:
-------------------------------------
Hadoop serialization framework aka Writable is not only possible way for serializing object. We use Thrift on top on Hadoop Writables.
Without serializable comparator its not possible to have serializable collections with ordering.
> WritableComparator must implement no-arg constructor
> ----------------------------------------------------
>
> Key: HADOOP-8619
> URL: https://issues.apache.org/jira/browse/HADOOP-8619
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 3.0.0
> Reporter: Radim Kolar
> Fix For: 0.23.0, 2.0.0-alpha, 3.0.0
>
> Attachments: writable-comparator.txt
>
>
> Because of reasons listed here: http://findbugs.sourceforge.net/bugDescriptions.html#SE_COMPARATOR_SHOULD_BE_SERIALIZABLE
> comparators should be serializable. To make deserialization work, it is required that all superclasses have no-arg constructor. http://findbugs.sourceforge.net/bugDescriptions.html#SE_NO_SUITABLE_CONSTRUCTOR
> Simply add no=arg constructor to WritableComparator.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8619) WritableComparator must implement
no-arg constructor
Posted by "Yanbo Liang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13424763#comment-13424763 ]
Yanbo Liang commented on HADOOP-8619:
-------------------------------------
@Radim Kolar
There are different ways to serialize data include Writable, Thrift and Protocol Buffer. But I don't think it's necessary to serialize and transport comparator through the wire. Because in both sides of the communication, they should have the same code which include the comparator code. I think the comparator is part of the code rather than the data.
> WritableComparator must implement no-arg constructor
> ----------------------------------------------------
>
> Key: HADOOP-8619
> URL: https://issues.apache.org/jira/browse/HADOOP-8619
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 3.0.0
> Reporter: Radim Kolar
> Fix For: 0.23.0, 2.0.0-alpha, 3.0.0
>
> Attachments: writable-comparator.txt
>
>
> Because of reasons listed here: http://findbugs.sourceforge.net/bugDescriptions.html#SE_COMPARATOR_SHOULD_BE_SERIALIZABLE
> comparators should be serializable. To make deserialization work, it is required that all superclasses have no-arg constructor. http://findbugs.sourceforge.net/bugDescriptions.html#SE_NO_SUITABLE_CONSTRUCTOR
> Simply add no=arg constructor to WritableComparator.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8619) WritableComparator must implement
no-arg constructor
Posted by "Brandon Li (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13424150#comment-13424150 ]
Brandon Li commented on HADOOP-8619:
------------------------------------
{quote}..., I think this issue is not necessary.{quote}
Agree to resolve it as "won't fix".
> WritableComparator must implement no-arg constructor
> ----------------------------------------------------
>
> Key: HADOOP-8619
> URL: https://issues.apache.org/jira/browse/HADOOP-8619
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 3.0.0
> Reporter: Radim Kolar
> Fix For: 0.23.0, 2.0.0-alpha, 3.0.0
>
> Attachments: writable-comparator.txt
>
>
> Because of reasons listed here: http://findbugs.sourceforge.net/bugDescriptions.html#SE_COMPARATOR_SHOULD_BE_SERIALIZABLE
> comparators should be serializable. To make deserialization work, it is required that all superclasses have no-arg constructor. http://findbugs.sourceforge.net/bugDescriptions.html#SE_NO_SUITABLE_CONSTRUCTOR
> Simply add no=arg constructor to WritableComparator.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8619) WritableComparator must implement
no-arg constructor
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13432072#comment-13432072 ]
Hadoop QA commented on HADOOP-8619:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12540087/8619-0.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1275//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1275//console
This message is automatically generated.
> WritableComparator must implement no-arg constructor
> ----------------------------------------------------
>
> Key: HADOOP-8619
> URL: https://issues.apache.org/jira/browse/HADOOP-8619
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 3.0.0
> Reporter: Radim Kolar
> Fix For: 0.23.0, 2.0.0-alpha, 3.0.0
>
> Attachments: 8619-0.patch, writable-comparator.txt
>
>
> Because of reasons listed here: http://findbugs.sourceforge.net/bugDescriptions.html#SE_COMPARATOR_SHOULD_BE_SERIALIZABLE
> comparators should be serializable. To make deserialization work, it is required that all superclasses have no-arg constructor. http://findbugs.sourceforge.net/bugDescriptions.html#SE_NO_SUITABLE_CONSTRUCTOR
> Simply add no=arg constructor to WritableComparator.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8619) WritableComparator must implement
no-arg constructor
Posted by "Brandon Li (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425289#comment-13425289 ]
Brandon Li commented on HADOOP-8619:
------------------------------------
Hi Radim,
Semantically, the patch is a good patch. It's not necessary to patch it for the following reason:
{quote}...all referenced objects must be deserializable, otherwise there is no way to reconstruct object tree back...{quote}
We are aware of that. One of the reasons that Interface "Writeable" was used from the early days is it's simple/lightweight. If you are interested in how it's used, you can take a look of some examples, such as org.apache.hadoop.io.WritableComparable and the classes implementing it.
Usually it may not be needed to make an interface/class be able to support several serialization approaches when one of them is sufficient for the usage. :-)
Additionally, leaving it not patched can prevent developers form using Java Serialization in Hadoop by mistake. With that said, we can always come back apply this patch when we see Java Serialization is a must in the future. Agree? :-)
> WritableComparator must implement no-arg constructor
> ----------------------------------------------------
>
> Key: HADOOP-8619
> URL: https://issues.apache.org/jira/browse/HADOOP-8619
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 3.0.0
> Reporter: Radim Kolar
> Fix For: 0.23.0, 2.0.0-alpha, 3.0.0
>
> Attachments: writable-comparator.txt
>
>
> Because of reasons listed here: http://findbugs.sourceforge.net/bugDescriptions.html#SE_COMPARATOR_SHOULD_BE_SERIALIZABLE
> comparators should be serializable. To make deserialization work, it is required that all superclasses have no-arg constructor. http://findbugs.sourceforge.net/bugDescriptions.html#SE_NO_SUITABLE_CONSTRUCTOR
> Simply add no=arg constructor to WritableComparator.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8619) WritableComparator must implement
no-arg constructor
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13421816#comment-13421816 ]
Hadoop QA commented on HADOOP-8619:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12537747/writable-comparator.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1215//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1215//console
This message is automatically generated.
> WritableComparator must implement no-arg constructor
> ----------------------------------------------------
>
> Key: HADOOP-8619
> URL: https://issues.apache.org/jira/browse/HADOOP-8619
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 3.0.0
> Reporter: Radim Kolar
> Fix For: 0.23.0, 2.0.0-alpha, 3.0.0
>
> Attachments: writable-comparator.txt
>
>
> Because of reasons listed here: http://findbugs.sourceforge.net/bugDescriptions.html#SE_COMPARATOR_SHOULD_BE_SERIALIZABLE
> comparators should be serializable. To make deserialization work, it is required that all superclasses have no-arg constructor. http://findbugs.sourceforge.net/bugDescriptions.html#SE_NO_SUITABLE_CONSTRUCTOR
> Simply add no=arg constructor to WritableComparator.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8619) WritableComparator must implement
no-arg constructor
Posted by "Radim Kolar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443155#comment-13443155 ]
Radim Kolar commented on HADOOP-8619:
-------------------------------------
I need fix in 0.23 and 2.1.0-alpha
> WritableComparator must implement no-arg constructor
> ----------------------------------------------------
>
> Key: HADOOP-8619
> URL: https://issues.apache.org/jira/browse/HADOOP-8619
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 3.0.0
> Reporter: Radim Kolar
> Assignee: Chris Douglas
> Fix For: 0.23.0, 2.0.0-alpha, 3.0.0
>
> Attachments: 8619-0.patch, writable-comparator.txt
>
>
> Because of reasons listed here: http://findbugs.sourceforge.net/bugDescriptions.html#SE_COMPARATOR_SHOULD_BE_SERIALIZABLE
> comparators should be serializable. To make deserialization work, it is required that all superclasses have no-arg constructor. http://findbugs.sourceforge.net/bugDescriptions.html#SE_NO_SUITABLE_CONSTRUCTOR
> Simply add no=arg constructor to WritableComparator.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8619) WritableComparator must implement
no-arg constructor
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Suresh Srinivas updated HADOOP-8619:
------------------------------------
Resolution: Fixed
Assignee: Chris Douglas
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
+1 for the patch.
I committed the patch to trunk. Thank you Chris.
@Radim, Fix Version/s was set to 3.0.0, 2.0.0-alpha and 0.23. I am not sure if you intended that to indicate that you need this change on those branches. If you did, let me know.
Also, in future, to indicate other branches that need a change, use Target Version/s field.
> WritableComparator must implement no-arg constructor
> ----------------------------------------------------
>
> Key: HADOOP-8619
> URL: https://issues.apache.org/jira/browse/HADOOP-8619
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 3.0.0
> Reporter: Radim Kolar
> Assignee: Chris Douglas
> Fix For: 3.0.0, 2.0.0-alpha, 0.23.0
>
> Attachments: 8619-0.patch, writable-comparator.txt
>
>
> Because of reasons listed here: http://findbugs.sourceforge.net/bugDescriptions.html#SE_COMPARATOR_SHOULD_BE_SERIALIZABLE
> comparators should be serializable. To make deserialization work, it is required that all superclasses have no-arg constructor. http://findbugs.sourceforge.net/bugDescriptions.html#SE_NO_SUITABLE_CONSTRUCTOR
> Simply add no=arg constructor to WritableComparator.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8619) WritableComparator must implement
no-arg constructor
Posted by "Radim Kolar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Radim Kolar updated HADOOP-8619:
--------------------------------
Attachment: writable-comparator.txt
> WritableComparator must implement no-arg constructor
> ----------------------------------------------------
>
> Key: HADOOP-8619
> URL: https://issues.apache.org/jira/browse/HADOOP-8619
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 3.0.0
> Reporter: Radim Kolar
> Fix For: 0.23.0, 2.0.0-alpha, 3.0.0
>
> Attachments: writable-comparator.txt
>
>
> Because of reasons listed here: http://findbugs.sourceforge.net/bugDescriptions.html#SE_COMPARATOR_SHOULD_BE_SERIALIZABLE
> comparators should be serializable. To make deserialization work, it is required that all superclasses have no-arg constructor. http://findbugs.sourceforge.net/bugDescriptions.html#SE_NO_SUITABLE_CONSTRUCTOR
> Simply add no=arg constructor to WritableComparator.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8619) WritableComparator must implement
no-arg constructor
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-8619:
----------------------------------
Attachment: 8619-0.patch
> WritableComparator must implement no-arg constructor
> ----------------------------------------------------
>
> Key: HADOOP-8619
> URL: https://issues.apache.org/jira/browse/HADOOP-8619
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 3.0.0
> Reporter: Radim Kolar
> Fix For: 0.23.0, 2.0.0-alpha, 3.0.0
>
> Attachments: 8619-0.patch, writable-comparator.txt
>
>
> Because of reasons listed here: http://findbugs.sourceforge.net/bugDescriptions.html#SE_COMPARATOR_SHOULD_BE_SERIALIZABLE
> comparators should be serializable. To make deserialization work, it is required that all superclasses have no-arg constructor. http://findbugs.sourceforge.net/bugDescriptions.html#SE_NO_SUITABLE_CONSTRUCTOR
> Simply add no=arg constructor to WritableComparator.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8619) WritableComparator must implement
no-arg constructor
Posted by "Radim Kolar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425639#comment-13425639 ]
Radim Kolar commented on HADOOP-8619:
-------------------------------------
I know how to use Writeable interface. I coded about 110k lines in hadoop of code in last 8 months. Its unusable beyond easy stuff. If Writable is that good, why you are not using it for serializing communication in YARN. You use avro and protobuf. Isnt one serialization approach sufficient for usage? It is, but its not effective. Thats why you are not using Writable everywhere.
But my point is not to discuss if Writable sucks or not. Point is why you are trying on purpose put obstacles in using other serialization frameworks. You call it "protection" but its some kind of protection as you can get by communist government. It was proved by history that communist protection failed, it created sick society where everybody were poor.
Do not try to lock developers into one right thing. Give them freedom.
I do not have infinite time in hand. I could not wait years until you guys decide, maybe we should commit these 3 lines of code. I need to act now, my project needs it.
> WritableComparator must implement no-arg constructor
> ----------------------------------------------------
>
> Key: HADOOP-8619
> URL: https://issues.apache.org/jira/browse/HADOOP-8619
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 3.0.0
> Reporter: Radim Kolar
> Fix For: 0.23.0, 2.0.0-alpha, 3.0.0
>
> Attachments: writable-comparator.txt
>
>
> Because of reasons listed here: http://findbugs.sourceforge.net/bugDescriptions.html#SE_COMPARATOR_SHOULD_BE_SERIALIZABLE
> comparators should be serializable. To make deserialization work, it is required that all superclasses have no-arg constructor. http://findbugs.sourceforge.net/bugDescriptions.html#SE_NO_SUITABLE_CONSTRUCTOR
> Simply add no=arg constructor to WritableComparator.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8619) WritableComparator must implement
no-arg constructor
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443174#comment-13443174 ]
Hudson commented on HADOOP-8619:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #2678 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2678/])
HADOOP-8619. WritableComparator must implement no-arg constructor. Contributed by Chris Douglas. (Revision 1378120)
Result = FAILURE
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1378120
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/WritableComparator.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/serializer/TestWritableSerialization.java
> WritableComparator must implement no-arg constructor
> ----------------------------------------------------
>
> Key: HADOOP-8619
> URL: https://issues.apache.org/jira/browse/HADOOP-8619
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 3.0.0
> Reporter: Radim Kolar
> Assignee: Chris Douglas
> Fix For: 0.23.0, 2.0.0-alpha, 3.0.0
>
> Attachments: 8619-0.patch, writable-comparator.txt
>
>
> Because of reasons listed here: http://findbugs.sourceforge.net/bugDescriptions.html#SE_COMPARATOR_SHOULD_BE_SERIALIZABLE
> comparators should be serializable. To make deserialization work, it is required that all superclasses have no-arg constructor. http://findbugs.sourceforge.net/bugDescriptions.html#SE_NO_SUITABLE_CONSTRUCTOR
> Simply add no=arg constructor to WritableComparator.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8619) WritableComparator must implement
no-arg constructor
Posted by "Radim Kolar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13424776#comment-13424776 ]
Radim Kolar commented on HADOOP-8619:
-------------------------------------
There is difference between think and know. To make object serialization work, all referenced objects must be deserializable, otherwise there is no way to reconstruct object tree back. You can not deserialize object if you can no create it. Plain and simple.
Lets take another approach: Hadoop is using findbugs, isnt it? It means that you guys have some trust and confidence in findbugs authors. Then trust them if they are telling you that deserialization do not works if you cant call constructor.
> WritableComparator must implement no-arg constructor
> ----------------------------------------------------
>
> Key: HADOOP-8619
> URL: https://issues.apache.org/jira/browse/HADOOP-8619
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 3.0.0
> Reporter: Radim Kolar
> Fix For: 0.23.0, 2.0.0-alpha, 3.0.0
>
> Attachments: writable-comparator.txt
>
>
> Because of reasons listed here: http://findbugs.sourceforge.net/bugDescriptions.html#SE_COMPARATOR_SHOULD_BE_SERIALIZABLE
> comparators should be serializable. To make deserialization work, it is required that all superclasses have no-arg constructor. http://findbugs.sourceforge.net/bugDescriptions.html#SE_NO_SUITABLE_CONSTRUCTOR
> Simply add no=arg constructor to WritableComparator.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8619) WritableComparator must implement
no-arg constructor
Posted by "Radim Kolar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Radim Kolar updated HADOOP-8619:
--------------------------------
Status: Patch Available (was: Open)
> WritableComparator must implement no-arg constructor
> ----------------------------------------------------
>
> Key: HADOOP-8619
> URL: https://issues.apache.org/jira/browse/HADOOP-8619
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 3.0.0
> Reporter: Radim Kolar
> Fix For: 3.0.0, 2.0.0-alpha, 0.23.0
>
> Attachments: writable-comparator.txt
>
>
> Because of reasons listed here: http://findbugs.sourceforge.net/bugDescriptions.html#SE_COMPARATOR_SHOULD_BE_SERIALIZABLE
> comparators should be serializable. To make deserialization work, it is required that all superclasses have no-arg constructor. http://findbugs.sourceforge.net/bugDescriptions.html#SE_NO_SUITABLE_CONSTRUCTOR
> Simply add no=arg constructor to WritableComparator.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8619) WritableComparator must implement
no-arg constructor
Posted by "Brandon Li (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13423527#comment-13423527 ]
Brandon Li commented on HADOOP-8619:
------------------------------------
Thanks for finding the issue. The patch should fix the problem.
Actually in Hadoop core components, instead of java Serialization, interface "Writable" is wildly used to do in-memory(or on disk persistence) serialization and Protobuf is used for remote communication.
> WritableComparator must implement no-arg constructor
> ----------------------------------------------------
>
> Key: HADOOP-8619
> URL: https://issues.apache.org/jira/browse/HADOOP-8619
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 3.0.0
> Reporter: Radim Kolar
> Fix For: 0.23.0, 2.0.0-alpha, 3.0.0
>
> Attachments: writable-comparator.txt
>
>
> Because of reasons listed here: http://findbugs.sourceforge.net/bugDescriptions.html#SE_COMPARATOR_SHOULD_BE_SERIALIZABLE
> comparators should be serializable. To make deserialization work, it is required that all superclasses have no-arg constructor. http://findbugs.sourceforge.net/bugDescriptions.html#SE_NO_SUITABLE_CONSTRUCTOR
> Simply add no=arg constructor to WritableComparator.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8619) WritableComparator must implement
no-arg constructor
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443143#comment-13443143 ]
Hudson commented on HADOOP-8619:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2713 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2713/])
HADOOP-8619. WritableComparator must implement no-arg constructor. Contributed by Chris Douglas. (Revision 1378120)
Result = SUCCESS
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1378120
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/WritableComparator.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/serializer/TestWritableSerialization.java
> WritableComparator must implement no-arg constructor
> ----------------------------------------------------
>
> Key: HADOOP-8619
> URL: https://issues.apache.org/jira/browse/HADOOP-8619
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 3.0.0
> Reporter: Radim Kolar
> Assignee: Chris Douglas
> Fix For: 0.23.0, 2.0.0-alpha, 3.0.0
>
> Attachments: 8619-0.patch, writable-comparator.txt
>
>
> Because of reasons listed here: http://findbugs.sourceforge.net/bugDescriptions.html#SE_COMPARATOR_SHOULD_BE_SERIALIZABLE
> comparators should be serializable. To make deserialization work, it is required that all superclasses have no-arg constructor. http://findbugs.sourceforge.net/bugDescriptions.html#SE_NO_SUITABLE_CONSTRUCTOR
> Simply add no=arg constructor to WritableComparator.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8619) WritableComparator must implement
no-arg constructor
Posted by "Radim Kolar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13424779#comment-13424779 ]
Radim Kolar commented on HADOOP-8619:
-------------------------------------
Java serialization do not capture constructor arguments into output stream. More detail about protocol is here http://docs.oracle.com/javase/6/docs/platform/serialization/spec/protocol.html
If you create own constructor, java will not create default zero arg constructor http://xahlee.info/java-a-day/constructer.html - section "Java Technicality: Default Constructors"
> WritableComparator must implement no-arg constructor
> ----------------------------------------------------
>
> Key: HADOOP-8619
> URL: https://issues.apache.org/jira/browse/HADOOP-8619
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 3.0.0
> Reporter: Radim Kolar
> Fix For: 0.23.0, 2.0.0-alpha, 3.0.0
>
> Attachments: writable-comparator.txt
>
>
> Because of reasons listed here: http://findbugs.sourceforge.net/bugDescriptions.html#SE_COMPARATOR_SHOULD_BE_SERIALIZABLE
> comparators should be serializable. To make deserialization work, it is required that all superclasses have no-arg constructor. http://findbugs.sourceforge.net/bugDescriptions.html#SE_NO_SUITABLE_CONSTRUCTOR
> Simply add no=arg constructor to WritableComparator.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8619) WritableComparator must implement
no-arg constructor
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444023#comment-13444023 ]
Hudson commented on HADOOP-8619:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #1149 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1149/])
HADOOP-8619. WritableComparator must implement no-arg constructor. Contributed by Chris Douglas. (Revision 1378120)
Result = FAILURE
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1378120
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/WritableComparator.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/serializer/TestWritableSerialization.java
> WritableComparator must implement no-arg constructor
> ----------------------------------------------------
>
> Key: HADOOP-8619
> URL: https://issues.apache.org/jira/browse/HADOOP-8619
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 3.0.0
> Reporter: Radim Kolar
> Assignee: Chris Douglas
> Fix For: 0.23.0, 2.0.0-alpha, 3.0.0
>
> Attachments: 8619-0.patch, writable-comparator.txt
>
>
> Because of reasons listed here: http://findbugs.sourceforge.net/bugDescriptions.html#SE_COMPARATOR_SHOULD_BE_SERIALIZABLE
> comparators should be serializable. To make deserialization work, it is required that all superclasses have no-arg constructor. http://findbugs.sourceforge.net/bugDescriptions.html#SE_NO_SUITABLE_CONSTRUCTOR
> Simply add no=arg constructor to WritableComparator.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira