You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2019/08/12 16:22:28 UTC

[GitHub] [guacamole-client] mike-jumper commented on a change in pull request #439: GUACAMOLE-234: Fix resource leaks in new LDAP code.

mike-jumper commented on a change in pull request #439: GUACAMOLE-234: Fix resource leaks in new LDAP code.
URL: https://github.com/apache/guacamole-client/pull/439#discussion_r313010549
 
 

 ##########
 File path: extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/ObjectQueryService.java
 ##########
 @@ -223,10 +224,11 @@ else if (results.isReferral() && request.isFollowReferrals()) {
                 
             }
 
+            results.close();
 
 Review comment:
   Will this still leak if an exception is thrown above?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services