You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/10/21 12:25:35 UTC
[GitHub] [hudi] mincwang opened a new pull request #3842: [MINOR] Show source table operator details on the flink web when reading hudi table
mincwang opened a new pull request #3842:
URL: https://github.com/apache/hudi/pull/3842
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3842: [MINOR] Show source table operator details on the flink web when reading hudi table
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3842:
URL: https://github.com/apache/hudi/pull/3842#issuecomment-948575260
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dd8a1a3d0ca0dc0d8b83e252227b1de25e7e17af",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dd8a1a3d0ca0dc0d8b83e252227b1de25e7e17af",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dd8a1a3d0ca0dc0d8b83e252227b1de25e7e17af UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] mincwang commented on a change in pull request #3842: [MINOR] Show source table operator details on the flink web when reading hudi table
Posted by GitBox <gi...@apache.org>.
mincwang commented on a change in pull request #3842:
URL: https://github.com/apache/hudi/pull/3842#discussion_r734175459
##########
File path: hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableSource.java
##########
@@ -180,15 +180,17 @@ public boolean isBounded() {
conf, FilePathUtils.toFlinkPath(path), maxCompactionMemoryInBytes, getRequiredPartitionPaths());
InputFormat<RowData, ?> inputFormat = getInputFormat(true);
OneInputStreamOperatorFactory<MergeOnReadInputSplit, RowData> factory = StreamReadOperator.factory((MergeOnReadInputFormat) inputFormat);
- SingleOutputStreamOperator<RowData> source = execEnv.addSource(monitoringFunction, "split_monitor")
+ SingleOutputStreamOperator<RowData> source = execEnv.addSource(monitoringFunction,
+ "split_monitor(table=[" + conf.getString(FlinkOptions.TABLE_NAME) + "], fields=" + schema.getColumnNames() + ")")
Review comment:
ok，i think it‘s a good suggestion。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] mincwang commented on a change in pull request #3842: [MINOR] Show source table operator details on the flink web when reading hudi table
Posted by GitBox <gi...@apache.org>.
mincwang commented on a change in pull request #3842:
URL: https://github.com/apache/hudi/pull/3842#discussion_r734928697
##########
File path: hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableSource.java
##########
@@ -268,6 +266,16 @@ private DataType getProducedDataType() {
return requiredPartitions;
}
+ private String getSourceOperatorName(String operatorName) {
+ String[] schemaFieldNames = this.schema.getColumnNames().toArray(new String[0]);
+ List<String> fields = Arrays.stream(Arrays.stream(this.requiredPos)
+ .mapToObj(i -> schemaFieldNames[i])
+ .toArray(String[]::new))
+ .collect(Collectors.toList());
Review comment:
Ok, I'm going to replace it with a `StringBuilder`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3842: [MINOR] Show source table operator details on the flink web when reading hudi table
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3842:
URL: https://github.com/apache/hudi/pull/3842#issuecomment-948575260
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dd8a1a3d0ca0dc0d8b83e252227b1de25e7e17af",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2774",
"triggerID" : "dd8a1a3d0ca0dc0d8b83e252227b1de25e7e17af",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dd8a1a3d0ca0dc0d8b83e252227b1de25e7e17af Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2774)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3842: [MINOR] Show source table operator details on the flink web when reading hudi table
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3842:
URL: https://github.com/apache/hudi/pull/3842#issuecomment-948575260
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dd8a1a3d0ca0dc0d8b83e252227b1de25e7e17af",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2774",
"triggerID" : "dd8a1a3d0ca0dc0d8b83e252227b1de25e7e17af",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dd8a1a3d0ca0dc0d8b83e252227b1de25e7e17af Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2774)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3842: [MINOR] Show source table operator details on the flink web when reading hudi table
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3842:
URL: https://github.com/apache/hudi/pull/3842#issuecomment-948575260
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dd8a1a3d0ca0dc0d8b83e252227b1de25e7e17af",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2774",
"triggerID" : "dd8a1a3d0ca0dc0d8b83e252227b1de25e7e17af",
"triggerType" : "PUSH"
}, {
"hash" : "a2e5859250562c77c534b5b98df177a011675c35",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a2e5859250562c77c534b5b98df177a011675c35",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dd8a1a3d0ca0dc0d8b83e252227b1de25e7e17af Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2774)
* a2e5859250562c77c534b5b98df177a011675c35 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yanghua merged pull request #3842: [MINOR] Show source table operator details on the flink web when reading hudi table
Posted by GitBox <gi...@apache.org>.
yanghua merged pull request #3842:
URL: https://github.com/apache/hudi/pull/3842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yanghua commented on a change in pull request #3842: [MINOR] Show source table operator details on the flink web when reading hudi table
Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #3842:
URL: https://github.com/apache/hudi/pull/3842#discussion_r735133252
##########
File path: hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableSource.java
##########
@@ -266,6 +266,21 @@ private DataType getProducedDataType() {
return requiredPartitions;
}
+ private String getSourceOperatorName(String operatorName) {
+ String[] schemaFieldNames = this.schema.getColumnNames().toArray(new String[0]);
+ List<String> fields = Arrays.stream(this.requiredPos)
+ .mapToObj(i -> schemaFieldNames[i])
+ .collect(Collectors.toList());
+ StringBuilder sb = new StringBuilder();
+ sb.append(operatorName)
+ .append("(")
+ .append("table=").append(Collections.singletonList(conf.getString(FlinkOptions.TABLE_NAME)))
+ .append(", ")
+ .append("fields=").append(fields)
+ .append(")");
Review comment:
s.g.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3842: [MINOR] Show source table operator details on the flink web when reading hudi table
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3842:
URL: https://github.com/apache/hudi/pull/3842#issuecomment-948575260
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dd8a1a3d0ca0dc0d8b83e252227b1de25e7e17af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2774",
"triggerID" : "dd8a1a3d0ca0dc0d8b83e252227b1de25e7e17af",
"triggerType" : "PUSH"
}, {
"hash" : "a2e5859250562c77c534b5b98df177a011675c35",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2778",
"triggerID" : "a2e5859250562c77c534b5b98df177a011675c35",
"triggerType" : "PUSH"
}, {
"hash" : "cf6826fd108bd639db7b85df7ee66144cce3ea66",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2783",
"triggerID" : "cf6826fd108bd639db7b85df7ee66144cce3ea66",
"triggerType" : "PUSH"
}, {
"hash" : "03416a0ec1874ac842c526b80d0ca7490c7ea43c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2808",
"triggerID" : "03416a0ec1874ac842c526b80d0ca7490c7ea43c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 03416a0ec1874ac842c526b80d0ca7490c7ea43c Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2808)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3842: [MINOR] Show source table operator details on the flink web when reading hudi table
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3842:
URL: https://github.com/apache/hudi/pull/3842#issuecomment-948575260
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dd8a1a3d0ca0dc0d8b83e252227b1de25e7e17af",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2774",
"triggerID" : "dd8a1a3d0ca0dc0d8b83e252227b1de25e7e17af",
"triggerType" : "PUSH"
}, {
"hash" : "a2e5859250562c77c534b5b98df177a011675c35",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2778",
"triggerID" : "a2e5859250562c77c534b5b98df177a011675c35",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dd8a1a3d0ca0dc0d8b83e252227b1de25e7e17af Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2774)
* a2e5859250562c77c534b5b98df177a011675c35 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2778)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3842: [MINOR] Show source table operator details on the flink web when reading hudi table
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3842:
URL: https://github.com/apache/hudi/pull/3842#issuecomment-948575260
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dd8a1a3d0ca0dc0d8b83e252227b1de25e7e17af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2774",
"triggerID" : "dd8a1a3d0ca0dc0d8b83e252227b1de25e7e17af",
"triggerType" : "PUSH"
}, {
"hash" : "a2e5859250562c77c534b5b98df177a011675c35",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2778",
"triggerID" : "a2e5859250562c77c534b5b98df177a011675c35",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a2e5859250562c77c534b5b98df177a011675c35 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2778)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3842: [MINOR] Show source table operator details on the flink web when reading hudi table
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3842:
URL: https://github.com/apache/hudi/pull/3842#issuecomment-948575260
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dd8a1a3d0ca0dc0d8b83e252227b1de25e7e17af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2774",
"triggerID" : "dd8a1a3d0ca0dc0d8b83e252227b1de25e7e17af",
"triggerType" : "PUSH"
}, {
"hash" : "a2e5859250562c77c534b5b98df177a011675c35",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2778",
"triggerID" : "a2e5859250562c77c534b5b98df177a011675c35",
"triggerType" : "PUSH"
}, {
"hash" : "cf6826fd108bd639db7b85df7ee66144cce3ea66",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2783",
"triggerID" : "cf6826fd108bd639db7b85df7ee66144cce3ea66",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cf6826fd108bd639db7b85df7ee66144cce3ea66 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2783)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3842: [MINOR] Show source table operator details on the flink web when reading hudi table
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3842:
URL: https://github.com/apache/hudi/pull/3842#issuecomment-948575260
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dd8a1a3d0ca0dc0d8b83e252227b1de25e7e17af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2774",
"triggerID" : "dd8a1a3d0ca0dc0d8b83e252227b1de25e7e17af",
"triggerType" : "PUSH"
}, {
"hash" : "a2e5859250562c77c534b5b98df177a011675c35",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2778",
"triggerID" : "a2e5859250562c77c534b5b98df177a011675c35",
"triggerType" : "PUSH"
}, {
"hash" : "cf6826fd108bd639db7b85df7ee66144cce3ea66",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2783",
"triggerID" : "cf6826fd108bd639db7b85df7ee66144cce3ea66",
"triggerType" : "PUSH"
}, {
"hash" : "03416a0ec1874ac842c526b80d0ca7490c7ea43c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "03416a0ec1874ac842c526b80d0ca7490c7ea43c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cf6826fd108bd639db7b85df7ee66144cce3ea66 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2783)
* 03416a0ec1874ac842c526b80d0ca7490c7ea43c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3842: [MINOR] Show source table operator details on the flink web when reading hudi table
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3842:
URL: https://github.com/apache/hudi/pull/3842#issuecomment-948575260
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dd8a1a3d0ca0dc0d8b83e252227b1de25e7e17af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2774",
"triggerID" : "dd8a1a3d0ca0dc0d8b83e252227b1de25e7e17af",
"triggerType" : "PUSH"
}, {
"hash" : "a2e5859250562c77c534b5b98df177a011675c35",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2778",
"triggerID" : "a2e5859250562c77c534b5b98df177a011675c35",
"triggerType" : "PUSH"
}, {
"hash" : "cf6826fd108bd639db7b85df7ee66144cce3ea66",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2783",
"triggerID" : "cf6826fd108bd639db7b85df7ee66144cce3ea66",
"triggerType" : "PUSH"
}, {
"hash" : "03416a0ec1874ac842c526b80d0ca7490c7ea43c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2808",
"triggerID" : "03416a0ec1874ac842c526b80d0ca7490c7ea43c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cf6826fd108bd639db7b85df7ee66144cce3ea66 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2783)
* 03416a0ec1874ac842c526b80d0ca7490c7ea43c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2808)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] mincwang commented on a change in pull request #3842: [MINOR] Show source table operator details on the flink web when reading hudi table
Posted by GitBox <gi...@apache.org>.
mincwang commented on a change in pull request #3842:
URL: https://github.com/apache/hudi/pull/3842#discussion_r734930442
##########
File path: hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableSource.java
##########
@@ -266,6 +266,21 @@ private DataType getProducedDataType() {
return requiredPartitions;
}
+ private String getSourceOperatorName(String operatorName) {
+ String[] schemaFieldNames = this.schema.getColumnNames().toArray(new String[0]);
+ List<String> fields = Arrays.stream(this.requiredPos)
+ .mapToObj(i -> schemaFieldNames[i])
+ .collect(Collectors.toList());
+ StringBuilder sb = new StringBuilder();
+ sb.append(operatorName)
+ .append("(")
+ .append("table=").append(Collections.singletonList(conf.getString(FlinkOptions.TABLE_NAME)))
+ .append(", ")
+ .append("fields=").append(fields)
+ .append(")");
Review comment:
@yanghua I think it's better this way, because we expect result something like `Source: split_monitor(table=[hoodie_sink], fields=[id, weight])`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yanghua commented on a change in pull request #3842: [MINOR] Show source table operator details on the flink web when reading hudi table
Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #3842:
URL: https://github.com/apache/hudi/pull/3842#discussion_r734173285
##########
File path: hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableSource.java
##########
@@ -180,15 +180,17 @@ public boolean isBounded() {
conf, FilePathUtils.toFlinkPath(path), maxCompactionMemoryInBytes, getRequiredPartitionPaths());
InputFormat<RowData, ?> inputFormat = getInputFormat(true);
OneInputStreamOperatorFactory<MergeOnReadInputSplit, RowData> factory = StreamReadOperator.factory((MergeOnReadInputFormat) inputFormat);
- SingleOutputStreamOperator<RowData> source = execEnv.addSource(monitoringFunction, "split_monitor")
+ SingleOutputStreamOperator<RowData> source = execEnv.addSource(monitoringFunction,
+ "split_monitor(table=[" + conf.getString(FlinkOptions.TABLE_NAME) + "], fields=" + schema.getColumnNames() + ")")
Review comment:
@mincwang Would you mind extract this part:
`table=[" + conf.getString(FlinkOptions.TABLE_NAME) + "], fields=" + schema.getColumnNames() + ")"`
into a variable to let it could be shared both in if/else block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yanghua commented on a change in pull request #3842: [MINOR] Show source table operator details on the flink web when reading hudi table
Posted by GitBox <gi...@apache.org>.
yanghua commented on a change in pull request #3842:
URL: https://github.com/apache/hudi/pull/3842#discussion_r734266798
##########
File path: hudi-flink/src/main/java/org/apache/hudi/table/HoodieTableSource.java
##########
@@ -268,6 +266,16 @@ private DataType getProducedDataType() {
return requiredPartitions;
}
+ private String getSourceOperatorName(String operatorName) {
+ String[] schemaFieldNames = this.schema.getColumnNames().toArray(new String[0]);
+ List<String> fields = Arrays.stream(Arrays.stream(this.requiredPos)
+ .mapToObj(i -> schemaFieldNames[i])
+ .toArray(String[]::new))
+ .collect(Collectors.toList());
Review comment:
Can we simply replace this snappet with a `StringBuilder` like this:
```
sb.append("[");
Arrays.stream(this.requiredPos)
.mapToObj(i -> schemaFieldNames[i])
.forEach(s -> {
sb.append(s);
sb.append(",");
});
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3842: [MINOR] Show source table operator details on the flink web when reading hudi table
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3842:
URL: https://github.com/apache/hudi/pull/3842#issuecomment-948575260
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dd8a1a3d0ca0dc0d8b83e252227b1de25e7e17af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2774",
"triggerID" : "dd8a1a3d0ca0dc0d8b83e252227b1de25e7e17af",
"triggerType" : "PUSH"
}, {
"hash" : "a2e5859250562c77c534b5b98df177a011675c35",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2778",
"triggerID" : "a2e5859250562c77c534b5b98df177a011675c35",
"triggerType" : "PUSH"
}, {
"hash" : "cf6826fd108bd639db7b85df7ee66144cce3ea66",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cf6826fd108bd639db7b85df7ee66144cce3ea66",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a2e5859250562c77c534b5b98df177a011675c35 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2778)
* cf6826fd108bd639db7b85df7ee66144cce3ea66 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3842: [MINOR] Show source table operator details on the flink web when reading hudi table
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3842:
URL: https://github.com/apache/hudi/pull/3842#issuecomment-948575260
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dd8a1a3d0ca0dc0d8b83e252227b1de25e7e17af",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2774",
"triggerID" : "dd8a1a3d0ca0dc0d8b83e252227b1de25e7e17af",
"triggerType" : "PUSH"
}, {
"hash" : "a2e5859250562c77c534b5b98df177a011675c35",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2778",
"triggerID" : "a2e5859250562c77c534b5b98df177a011675c35",
"triggerType" : "PUSH"
}, {
"hash" : "cf6826fd108bd639db7b85df7ee66144cce3ea66",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2783",
"triggerID" : "cf6826fd108bd639db7b85df7ee66144cce3ea66",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a2e5859250562c77c534b5b98df177a011675c35 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2778)
* cf6826fd108bd639db7b85df7ee66144cce3ea66 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=2783)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org