You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/08/30 16:49:57 UTC

[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #11831: [pulsar-functions] Pass `SubscriptionPosition` from `FunctionDetails` to `FunctionConfig` / `SinkConfig`

michaeljmarshall commented on a change in pull request #11831:
URL: https://github.com/apache/pulsar/pull/11831#discussion_r698646549



##########
File path: pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/FunctionConfigUtils.java
##########
@@ -373,6 +373,14 @@ public static FunctionConfig convertFromDetails(FunctionDetails functionDetails)
 
         functionConfig.setCleanupSubscription(functionDetails.getSource().getCleanupSubscription());
         functionConfig.setAutoAck(functionDetails.getAutoAck());
+
+        // Set subscription position
+        if (Function.SubscriptionPosition.EARLIEST.equals(functionDetails.getSource().getSubscriptionPosition())) {
+            functionConfig.setSubscriptionPosition(SubscriptionInitialPosition.Earliest);
+        } else {
+            functionConfig.setSubscriptionPosition(SubscriptionInitialPosition.Latest);
+        }

Review comment:
       What is the reason for this conditional? Is it because `getSubscriptionPosition` can return `null`? If we ensure that the `getSubscriptionPosition` defaults to `Latest`, we could skip this conditional and just have:
   
   ```java
   functionConfig.setSubscriptionPosition(functionDetails.getSource().getSubscriptionPosition());
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org