You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2022/05/10 10:49:38 UTC

[GitHub] [buildstream-plugins] gtristan opened a new issue, #10: Cargo plugin can't handle git sources

gtristan opened a new issue, #10:
URL: https://github.com/apache/buildstream-plugins/issues/10

   This is a clone of the same issue reported against the cargo plugin for `bst-1`: https://gitlab.com/BuildStream/bst-external/-/issues/48
   
   Some `Cargo.lock` files can specify dependencies through git repositories, but the cargo plugin is unable to handle this case.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Cargo plugin can't handle git sources [buildstream-plugins]

Posted by "sophie-h (via GitHub)" <gi...@apache.org>.
sophie-h commented on issue #10:
URL: https://github.com/apache/buildstream-plugins/issues/10#issuecomment-2253506945

   This feature is now available in [buildstream-plugins-community](https://gitlab.com/BuildStream/buildstream-plugins-community/-/merge_requests/312) as part of the `cargo2` plugin.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Cargo plugin can't handle git sources [buildstream-plugins]

Posted by "sophie-h (via GitHub)" <gi...@apache.org>.
sophie-h commented on issue #10:
URL: https://github.com/apache/buildstream-plugins/issues/10#issuecomment-1987218113

   I'm working on this now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Cargo plugin can't handle git sources [buildstream-plugins]

Posted by "sophie-h (via GitHub)" <gi...@apache.org>.
sophie-h commented on issue #10:
URL: https://github.com/apache/buildstream-plugins/issues/10#issuecomment-1825953080

   I looked into this and it seems to be a bit tricky. The problem is that `kind: cargo` can only have cargo plugin refs and not git refs.
   
   The cargo plugin has to introduce a ref format for git sources. That's not really complicated. That, however, means that for all functionality like download etc., the cargo plugin also has to implement the git functionality. It might be possible to do this by wrapping around the git plugin in these cases. But I'm not sure if that's the right way to do this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org