You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Adam Heath <do...@brainfood.com> on 2010/01/07 20:50:50 UTC
Re: svn commit: r896213 - in /ofbiz/trunk/framework/common: servicedef/services_email.xml
src/org/ofbiz/common/email/EmailServices.java
lektran@apache.org wrote:
> Author: lektran
> Date: Tue Jan 5 20:48:15 2010
> New Revision: 896213
>
> URL: http://svn.apache.org/viewvc?rev=896213&view=rev
> Log:
> Emails will now be sent to any valid recipients even if the SMTP server rejected any invalid ones. This can be turned off if desired in general.properties and also on a per service call basis.
> A failure notification will be sent to the email's "from" address, listing the failed recipients and the reason for each failure. The notification can be turned off by setting the sendFailureNotification parameter to false in the s
>
> These changes fix a problem where emails are not sent to valid recipients and users receive no feedback when emails fail to be sent, generally because of the smtp server rejecting one or more recipients.
>
> OFBIZ-3379, thanks to Pranay Pandey for the report and testing, also thanks to Tim Ruppert and Ruth Hoffman for their input into the issue.
>
> Modified:
> ofbiz/trunk/framework/common/servicedef/services_email.xml
> ofbiz/trunk/framework/common/src/org/ofbiz/common/email/EmailServices.java
>
> Modified: ofbiz/trunk/framework/common/src/org/ofbiz/common/email/EmailServices.java
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/src/org/ofbiz/common/email/EmailServices.java?rev=896213&r1=896212&r2=896213&view=diff
> ==============================================================================
> --- ofbiz/trunk/framework/common/src/org/ofbiz/common/email/EmailServices.java (original)
> +++ ofbiz/trunk/framework/common/src/org/ofbiz/common/email/EmailServices.java Tue Jan 5 20:48:15 2010
> @@ -76,6 +78,8 @@
> import org.ofbiz.widget.screen.ScreenRenderer;
> import org.xml.sax.SAXException;
>
> +import com.sun.mail.smtp.SMTPAddressFailedException;
> +
Ick, bad, please don't do this.
Re: svn commit: r896213 - in /ofbiz/trunk/framework/common: servicedef/services_email.xml src/org/ofbiz/common/email/EmailServices.java
Posted by Scott Gray <sc...@hotwaxmedia.com>.
The API says I need to look at the nested
HotWax Media
http://www.hotwaxmedia.com
On 8/01/2010, at 9:09 AM, Adam Heath wrote:
> Scott Gray wrote:
>> On 8/01/2010, at 8:50 AM, Adam Heath wrote:
>>
>>> lektran@apache.org wrote:
>>>> Author: lektran
>>>> Date: Tue Jan 5 20:48:15 2010
>>>> New Revision: 896213
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=896213&view=rev
>>>> Log:
>>>> Emails will now be sent to any valid recipients even if the SMTP
>>>> server rejected any invalid ones. This can be turned off if desired
>>>> in general.properties and also on a per service call basis.
>>>> A failure notification will be sent to the email's "from" address,
>>>> listing the failed recipients and the reason for each failure. The
>>>> notification can be turned off by setting the
>>>> sendFailureNotification
>>>> parameter to false in the s
>>>>
>>>> These changes fix a problem where emails are not sent to valid
>>>> recipients and users receive no feedback when emails fail to be
>>>> sent,
>>>> generally because of the smtp server rejecting one or more
>>>> recipients.
>>>>
>>>> OFBIZ-3379, thanks to Pranay Pandey for the report and testing,
>>>> also
>>>> thanks to Tim Ruppert and Ruth Hoffman for their input into the
>>>> issue.
>>>>
>>>> Modified:
>>>> ofbiz/trunk/framework/common/servicedef/services_email.xml
>>>>
>>>> ofbiz/trunk/framework/common/src/org/ofbiz/common/email/
>>>> EmailServices.java
>>>>
>>>>
>>>> Modified:
>>>> ofbiz/trunk/framework/common/src/org/ofbiz/common/email/
>>>> EmailServices.java
>>>>
>>>> URL:
>>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/src/org/ofbiz/common/email/EmailServices.java?rev=896213&r1=896212&r2=896213&view=diff
>>>>
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> =
>>>> ===================================================================
>>>>
>>>> ---
>>>> ofbiz/trunk/framework/common/src/org/ofbiz/common/email/
>>>> EmailServices.java
>>>> (original)
>>>> +++
>>>> ofbiz/trunk/framework/common/src/org/ofbiz/common/email/
>>>> EmailServices.java
>>>> Tue Jan 5 20:48:15 2010
>>>> @@ -76,6 +78,8 @@
>>>> import org.ofbiz.widget.screen.ScreenRenderer;
>>>> import org.xml.sax.SAXException;
>>>>
>>>> +import com.sun.mail.smtp.SMTPAddressFailedException;
>>>> +
>>>
>>> Ick, bad, please don't do this.
>>
>> I'm sorry, don't do what?
>
> Use internal sun libraries.
>
I'll have a closer look at the code today and see if there is a way
around it.
Thanks
Scott
Re: svn commit: r896213 - in /ofbiz/trunk/framework/common: servicedef/services_email.xml
src/org/ofbiz/common/email/EmailServices.java
Posted by Adam Heath <do...@brainfood.com>.
Scott Gray wrote:
> On 8/01/2010, at 8:50 AM, Adam Heath wrote:
>
>> lektran@apache.org wrote:
>>> Author: lektran
>>> Date: Tue Jan 5 20:48:15 2010
>>> New Revision: 896213
>>>
>>> URL: http://svn.apache.org/viewvc?rev=896213&view=rev
>>> Log:
>>> Emails will now be sent to any valid recipients even if the SMTP
>>> server rejected any invalid ones. This can be turned off if desired
>>> in general.properties and also on a per service call basis.
>>> A failure notification will be sent to the email's "from" address,
>>> listing the failed recipients and the reason for each failure. The
>>> notification can be turned off by setting the sendFailureNotification
>>> parameter to false in the s
>>>
>>> These changes fix a problem where emails are not sent to valid
>>> recipients and users receive no feedback when emails fail to be sent,
>>> generally because of the smtp server rejecting one or more recipients.
>>>
>>> OFBIZ-3379, thanks to Pranay Pandey for the report and testing, also
>>> thanks to Tim Ruppert and Ruth Hoffman for their input into the issue.
>>>
>>> Modified:
>>> ofbiz/trunk/framework/common/servicedef/services_email.xml
>>>
>>> ofbiz/trunk/framework/common/src/org/ofbiz/common/email/EmailServices.java
>>>
>>>
>>> Modified:
>>> ofbiz/trunk/framework/common/src/org/ofbiz/common/email/EmailServices.java
>>>
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/src/org/ofbiz/common/email/EmailServices.java?rev=896213&r1=896212&r2=896213&view=diff
>>>
>>> ==============================================================================
>>>
>>> ---
>>> ofbiz/trunk/framework/common/src/org/ofbiz/common/email/EmailServices.java
>>> (original)
>>> +++
>>> ofbiz/trunk/framework/common/src/org/ofbiz/common/email/EmailServices.java
>>> Tue Jan 5 20:48:15 2010
>>> @@ -76,6 +78,8 @@
>>> import org.ofbiz.widget.screen.ScreenRenderer;
>>> import org.xml.sax.SAXException;
>>>
>>> +import com.sun.mail.smtp.SMTPAddressFailedException;
>>> +
>>
>> Ick, bad, please don't do this.
>
> I'm sorry, don't do what?
Use internal sun libraries.
Re: svn commit: r896213 - in /ofbiz/trunk/framework/common: servicedef/services_email.xml src/org/ofbiz/common/email/EmailServices.java
Posted by Scott Gray <sc...@hotwaxmedia.com>.
On 8/01/2010, at 8:50 AM, Adam Heath wrote:
> lektran@apache.org wrote:
>> Author: lektran
>> Date: Tue Jan 5 20:48:15 2010
>> New Revision: 896213
>>
>> URL: http://svn.apache.org/viewvc?rev=896213&view=rev
>> Log:
>> Emails will now be sent to any valid recipients even if the SMTP
>> server rejected any invalid ones. This can be turned off if desired
>> in general.properties and also on a per service call basis.
>> A failure notification will be sent to the email's "from" address,
>> listing the failed recipients and the reason for each failure. The
>> notification can be turned off by setting the
>> sendFailureNotification parameter to false in the s
>>
>> These changes fix a problem where emails are not sent to valid
>> recipients and users receive no feedback when emails fail to be
>> sent, generally because of the smtp server rejecting one or more
>> recipients.
>>
>> OFBIZ-3379, thanks to Pranay Pandey for the report and testing,
>> also thanks to Tim Ruppert and Ruth Hoffman for their input into
>> the issue.
>>
>> Modified:
>> ofbiz/trunk/framework/common/servicedef/services_email.xml
>> ofbiz/trunk/framework/common/src/org/ofbiz/common/email/
>> EmailServices.java
>>
>> Modified: ofbiz/trunk/framework/common/src/org/ofbiz/common/email/
>> EmailServices.java
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/common/src/org/ofbiz/common/email/EmailServices.java?rev=896213&r1=896212&r2=896213&view=diff
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =====================================================================
>> --- ofbiz/trunk/framework/common/src/org/ofbiz/common/email/
>> EmailServices.java (original)
>> +++ ofbiz/trunk/framework/common/src/org/ofbiz/common/email/
>> EmailServices.java Tue Jan 5 20:48:15 2010
>> @@ -76,6 +78,8 @@
>> import org.ofbiz.widget.screen.ScreenRenderer;
>> import org.xml.sax.SAXException;
>>
>> +import com.sun.mail.smtp.SMTPAddressFailedException;
>> +
>
> Ick, bad, please don't do this.
I'm sorry, don't do what?