You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Peter Pentchev <ro...@ringlet.net> on 2006/02/11 19:35:31 UTC
[PATCH] Fix the build with BDB < 4.2 - DB_ENV->get_flags()
Hi,
The BDB code in Subversion tries to use the get_flags() member function
of DB_ENV; unfortunately, this function did not appear until BDB 4.2,
so for earlier versions messing with the internals of the DB_ENV
structure is, unfortunately, unavoidable.
[[[
Fix the build with BDB < 4.2 without DB_ENV->get_flags().
]]]
G'luck,
Peter
--
Peter Pentchev roam@ringlet.net roam@cnsys.bg roam@FreeBSD.org
PGP key: http://people.FreeBSD.org/~roam/roam.key.asc
Key fingerprint FDBA FD79 C26F 3C51 C95E DF9E ED18 B68D 1619 4553
If wishes were fishes, the antecedent of this conditional would be true.
Re: [PATCH] Fix the build with BDB < 4.2 - DB_ENV->get_flags()
Posted by Branko Čibej <br...@xbc.nu>.
Peter Pentchev wrote:
> On Sat, Feb 11, 2006 at 09:35:31PM +0200, Peter Pentchev wrote:
>
>> Hi,
>>
>> The BDB code in Subversion tries to use the get_flags() member function
>> of DB_ENV; unfortunately, this function did not appear until BDB 4.2,
>> so for earlier versions messing with the internals of the DB_ENV
>> structure is, unfortunately, unavoidable.
>>
>> [[[
>> Fix the build with BDB < 4.2 without DB_ENV->get_flags().
>> ]]]
>>
Thanks for the patch, but since I'm about to commit my own (slightly
different) fix for this bug. I hope you don't mind that I'll just ignore
yours.
-- Brane
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Fix the build with BDB < 4.2 - DB_ENV->get_flags()
Posted by Peter Pentchev <ro...@ringlet.net>.
On Sat, Feb 11, 2006 at 09:35:31PM +0200, Peter Pentchev wrote:
> Hi,
>
> The BDB code in Subversion tries to use the get_flags() member function
> of DB_ENV; unfortunately, this function did not appear until BDB 4.2,
> so for earlier versions messing with the internals of the DB_ENV
> structure is, unfortunately, unavoidable.
>
> [[[
> Fix the build with BDB < 4.2 without DB_ENV->get_flags().
> ]]]
[snip]
Eep! I just realized this breaks the logic, badly. Here's a fixed
patch.
G'luck,
Peter
--
Peter Pentchev roam@ringlet.net roam@cnsys.bg roam@FreeBSD.org
PGP key: http://people.FreeBSD.org/~roam/roam.key.asc
Key fingerprint FDBA FD79 C26F 3C51 C95E DF9E ED18 B68D 1619 4553
I am jealous of the first word in this sentence.