You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by sn...@apache.org on 2023/11/24 02:58:26 UTC
(pinot) 05/06: modifed test to ensure order of transformers.
This is an automated email from the ASF dual-hosted git repository.
snlee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
commit 05be5cfd9ade65d2785a412f6b0692f7ba0c0eb6
Author: Aishik <ai...@startree.ai>
AuthorDate: Thu Nov 23 23:14:26 2023 +0530
modifed test to ensure order of transformers.
---
.../local/recordtransformer/SpecialValueTransformer.java | 2 +-
.../local/recordtransformer/RecordTransformerTest.java | 16 +++++++++-------
2 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/SpecialValueTransformer.java b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/SpecialValueTransformer.java
index 26df94933a..3383803194 100644
--- a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/SpecialValueTransformer.java
+++ b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/SpecialValueTransformer.java
@@ -97,7 +97,7 @@ public class SpecialValueTransformer implements RecordTransformer {
negativeZeroNanSanitizedValues.add(nanTransformedValue);
}
}
- record.putValue(element,negativeZeroNanSanitizedValues.toArray());
+ record.putValue(element, negativeZeroNanSanitizedValues.toArray());
} else {
// Single-valued column.
Object zeroTransformedValue = transformNegativeZero(value);
diff --git a/pinot-segment-local/src/test/java/org/apache/pinot/segment/local/recordtransformer/RecordTransformerTest.java b/pinot-segment-local/src/test/java/org/apache/pinot/segment/local/recordtransformer/RecordTransformerTest.java
index 2685f8b6da..410fa19564 100644
--- a/pinot-segment-local/src/test/java/org/apache/pinot/segment/local/recordtransformer/RecordTransformerTest.java
+++ b/pinot-segment-local/src/test/java/org/apache/pinot/segment/local/recordtransformer/RecordTransformerTest.java
@@ -305,9 +305,9 @@ public class RecordTransformerTest {
Schema schema = new Schema.SchemaBuilder().addSingleValueDimension("svInt", DataType.INT)
.addSingleValueDimension("svDouble", DataType.DOUBLE)
.addSingleValueDimension("expressionTestColumn", DataType.INT)
- .addSingleValueDimension("svNaN", DataType.FLOAT).addMultiValueDimension("mvNaN",DataType.FLOAT)
+ .addSingleValueDimension("svNaN", DataType.FLOAT).addMultiValueDimension("mvNaN", DataType.FLOAT)
.addSingleValueDimension("emptyDimensionForNullValueTransformer", DataType.FLOAT)
- .addSingleValueDimension("svStringWithNullCharacters", DataType.STRING)
+ .addSingleValueDimension("svStringNull", DataType.STRING)
.addSingleValueDimension("indexableExtras", DataType.JSON)
.addDateTime("timeCol", DataType.TIMESTAMP, "1:MILLISECONDS:TIMESTAMP", "1:MILLISECONDS").build();
@@ -326,7 +326,7 @@ public class RecordTransformerTest {
List<RecordTransformer> currentListOfTransformers =
CompositeTransformer.getDefaultTransformers(tableConfig, schema);
- // Create a list of transformers to compare.
+ // Create a list of transformers in the original order to compare.
List<RecordTransformer> expectedListOfTransformers =
List.of(new ExpressionTransformer(tableConfig, schema), new FilterTransformer(tableConfig),
new SchemaConformingTransformer(tableConfig, schema), new DataTypeTransformer(tableConfig, schema),
@@ -352,14 +352,15 @@ public class RecordTransformerTest {
// Data for SpecialValue Transformer.
record.putValue("svNaN", Float.NaN);
- record.putValue("mvNaN",new Float[]{1.0f,Float.NaN,2.0f});
+ record.putValue("mvNaN", new Float[]{1.0f, Float.NaN, 2.0f});
// Data for sanitization transformer.
- record.putValue("svStringWithNullCharacters", "1\0002\0003");
+ record.putValue("svStringNull", null);
for (int i = 0; i < NUMBER_OF_TRANSFORMERS; i++) {
+ GenericRow copyRecord = record.copy();
GenericRow currentRecord = currentListOfTransformers.get(i).transform(record);
- GenericRow expectedRecord = expectedListOfTransformers.get(i).transform(record);
+ GenericRow expectedRecord = expectedListOfTransformers.get(i).transform(copyRecord);
assertEquals(currentRecord, expectedRecord);
record = expectedRecord;
}
@@ -652,7 +653,8 @@ public class RecordTransformerTest {
new Float[]{0.0f, 2.0f});
assertEquals(record.getValue("mvDoubleNaN"),
new Double[]{0.0d, 2.0d});
- assertEquals(new ArrayList<>(record.getNullValueFields()), new ArrayList<>(Arrays.asList("svFloatNaN","svDoubleNaN")));
+ assertEquals(new ArrayList<>(record.getNullValueFields()),
+ new ArrayList<>(Arrays.asList("svFloatNaN", "svDoubleNaN")));
}
// Test empty record
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org