[GitHub] [dolphinscheduler] shangeyao commented on pull request #11377: [Fix-11376][task plugin]Seatunnel Task cannot save successfully when …

[GitBox <gi...@apache.org>]

shangeyao commented on PR #11377:
URL: https://github.com/apache/dolphinscheduler/pull/11377#issuecomment-1210057008

   > After the modification, there is still a logical problem this time. I understand that it is to verify some parameters under specified conditions. It is recommended to modify it like this:
   > 
   > ```
   >         boolean result = super.checkParameters() && Objects.nonNull(deployMode);
   >         if (result && DeployModeEnum.local != deployMode) {
   >             result = Objects.nonNull(master);
   >             if (result && (MasterTypeEnum.SPARK == master || MasterTypeEnum.MESOS == master)) {
   >                 result = StringUtils.isNotBlank(masterUrl);
   >             }
   >         }
   >         return result;
   > ```
   
   After my test, I found that the two code segments have the same effect.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org