You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/27 16:30:13 UTC

[GitHub] [flink] yingshin opened a new pull request #13266: [FLINK-15719] fix mistake of reading state in scala lang.

yingshin opened a new pull request #13266:
URL: https://github.com/apache/flink/pull/13266


   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   give the right user guide to use state-processor api in scala language.
   
   
   ## Brief change log
   
   fix the code sample 
   
   
   ## Verifying this change
   
   This change is a trivial doc-fix without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): ( no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no )
     - The runtime per-record code paths (performance sensitive): ( no )
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no )
     - The S3 file system connector: (no )
   
   ## Documentation
   
     - Does this pull request introduce a new feature? ( no)
     - If yes, how is the feature documented? (not applicable)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #13266: [FLINK-15719] fix mistake of reading state in scala lang.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13266:
URL: https://github.com/apache/flink/pull/13266#issuecomment-682067939


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e3bd4b8fcc871f1d0b6f6154515dee6268e70fd1",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "e3bd4b8fcc871f1d0b6f6154515dee6268e70fd1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e3bd4b8fcc871f1d0b6f6154515dee6268e70fd1 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13266: [FLINK-15719] fix mistake of reading state in scala lang.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13266:
URL: https://github.com/apache/flink/pull/13266#issuecomment-682067939


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e3bd4b8fcc871f1d0b6f6154515dee6268e70fd1",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5938",
       "triggerID" : "e3bd4b8fcc871f1d0b6f6154515dee6268e70fd1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e3bd4b8fcc871f1d0b6f6154515dee6268e70fd1 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5938) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #13266: [FLINK-15719] fix mistake of reading state in scala lang.

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13266:
URL: https://github.com/apache/flink/pull/13266#issuecomment-682067939


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e3bd4b8fcc871f1d0b6f6154515dee6268e70fd1",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5938",
       "triggerID" : "e3bd4b8fcc871f1d0b6f6154515dee6268e70fd1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e3bd4b8fcc871f1d0b6f6154515dee6268e70fd1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5938) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #13266: [FLINK-15719] fix mistake of reading state in scala lang.

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13266:
URL: https://github.com/apache/flink/pull/13266#issuecomment-682058148


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit e3bd4b8fcc871f1d0b6f6154515dee6268e70fd1 (Thu Aug 27 16:33:14 UTC 2020)
   
   **Warnings:**
    * Documentation files were touched, but no `.zh.md` files: Update Chinese documentation or file Jira ticket.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] sjwiesman commented on a change in pull request #13266: [FLINK-15719] fix mistake of reading state in scala lang.

Posted by GitBox <gi...@apache.org>.
sjwiesman commented on a change in pull request #13266:
URL: https://github.com/apache/flink/pull/13266#discussion_r482314854



##########
File path: docs/dev/libs/state_processor_api.md
##########
@@ -321,34 +319,27 @@ public class ReaderFunction extends KeyedStateReaderFunction<Integer, KeyedState
 </div>
 <div data-lang="scala" markdown="1">
 {% highlight scala %}
-val keyedState = savepoint.readKeyedState("my-uid", new ReaderFunction)
-
-case class KeyedState(key: Int, value: Int, times: List[Long])
- 
-class ReaderFunction extends KeyedStateReaderFunction[Integer, KeyedState] {
- 
-  var state: ValueState[Integer] = _
-
+class ReaderFunction extends KeyedStateReaderFunction[java.lang.Integer, KeyedState] {

Review comment:
       ```suggestion
   class ReaderFunction extends KeyedStateReaderFunction[Int, KeyedState] {
   ```

##########
File path: docs/dev/libs/state_processor_api.md
##########
@@ -321,34 +319,27 @@ public class ReaderFunction extends KeyedStateReaderFunction<Integer, KeyedState
 </div>
 <div data-lang="scala" markdown="1">
 {% highlight scala %}
-val keyedState = savepoint.readKeyedState("my-uid", new ReaderFunction)
-
-case class KeyedState(key: Int, value: Int, times: List[Long])
- 
-class ReaderFunction extends KeyedStateReaderFunction[Integer, KeyedState] {
- 
-  var state: ValueState[Integer] = _
-
+class ReaderFunction extends KeyedStateReaderFunction[java.lang.Integer, KeyedState] {
+  var state: ValueState[Int] = _
   var updateTimes: ListState[Long] = _
- 
+
   @throws[Exception]
   override def open(parameters: Configuration): Unit = {
-     val stateDescriptor = new ValueStateDescriptor("state", Types.INT)
-     state = getRuntimeContext().getState(stateDescriptor)
+    val stateDescriptor = new ValueStateDescriptor("state", createTypeInformation[Int])
+    state = getRuntimeContext().getState(stateDescriptor)
 
-      val updateDescriptor = new ListStateDescriptor("times", Types.LONG)
-      updateTimes = getRuntimeContext().getListState(updateDescriptor)
-    }
- 
+    val updateDescriptor = new ListStateDescriptor("times", createTypeInformation[Long])
+    updateTimes = getRuntimeContext().getListState(updateDescriptor)
+  }
 
-  @throws[Exception]
-  override def processKey(
-    key: Int,
-    ctx: Context,
-    out: Collector[Keyedstate]): Unit = {
- 
-     val data = KeyedState(key, state.value(), updateTimes.get.asScala.toList)
-     out.collect(data)
+  override def readKey(key: java.lang.Integer,
+                       ctx: KeyedStateReaderFunction.Context,
+                       out: Collector[KeyedState]): Unit = {
+    val data = KeyedState(
+      key,
+      state.value(),
+      updateTimes.get().asScala.toList)

Review comment:
       ```suggestion
       val data = KeyedState(key, state.value, updateTimes.get.asScala.toList)
   ```

##########
File path: docs/dev/libs/state_processor_api.md
##########
@@ -321,34 +319,27 @@ public class ReaderFunction extends KeyedStateReaderFunction<Integer, KeyedState
 </div>
 <div data-lang="scala" markdown="1">
 {% highlight scala %}
-val keyedState = savepoint.readKeyedState("my-uid", new ReaderFunction)
-
-case class KeyedState(key: Int, value: Int, times: List[Long])
- 
-class ReaderFunction extends KeyedStateReaderFunction[Integer, KeyedState] {
- 
-  var state: ValueState[Integer] = _
-
+class ReaderFunction extends KeyedStateReaderFunction[java.lang.Integer, KeyedState] {
+  var state: ValueState[Int] = _
   var updateTimes: ListState[Long] = _
- 
+
   @throws[Exception]
   override def open(parameters: Configuration): Unit = {
-     val stateDescriptor = new ValueStateDescriptor("state", Types.INT)
-     state = getRuntimeContext().getState(stateDescriptor)
+    val stateDescriptor = new ValueStateDescriptor("state", createTypeInformation[Int])
+    state = getRuntimeContext().getState(stateDescriptor)
 
-      val updateDescriptor = new ListStateDescriptor("times", Types.LONG)
-      updateTimes = getRuntimeContext().getListState(updateDescriptor)
-    }
- 
+    val updateDescriptor = new ListStateDescriptor("times", createTypeInformation[Long])
+    updateTimes = getRuntimeContext().getListState(updateDescriptor)
+  }
 
-  @throws[Exception]
-  override def processKey(
-    key: Int,
-    ctx: Context,
-    out: Collector[Keyedstate]): Unit = {
- 
-     val data = KeyedState(key, state.value(), updateTimes.get.asScala.toList)
-     out.collect(data)
+  override def readKey(key: java.lang.Integer,
+                       ctx: KeyedStateReaderFunction.Context,
+                       out: Collector[KeyedState]): Unit = {

Review comment:
       ```suggestion
     override def readKey(key: Int, ctx: KeyedStateReaderFunction.Context, out: Collector[KeyedState]): Unit = {
   ```

##########
File path: docs/dev/libs/state_processor_api.md
##########
@@ -246,26 +246,24 @@ public class StatefulFunctionWithTime extends KeyedProcessFunction<Integer, Inte
 </div>
 <div data-lang="scala" markdown="1">
 {% highlight scala %}
-class StatefulFunctionWithTime extends KeyedProcessFunction[Integer, Integer, Void] {
- 
-   var state: ValueState[Integer] = _
- 
-   var updateTimes: ListState[Long] = _ 
+class StatefulFunctionWithTime extends KeyedProcessFunction[Int, Int, Void] {
+  var state: ValueState[Int] = _
+  var updateTimes: ListState[Long] = _
 
-   @throws[Exception]
-   override def open(parameters: Configuration): Unit = {
-      val stateDescriptor = new ValueStateDescriptor("state", Types.INT)
-      state = getRuntimeContext().getState(stateDescriptor)
+  @throws[Exception]
+  override def open(parameters: Configuration): Unit = {
+    val stateDescriptor = new ValueStateDescriptor("state", createTypeInformation[Int])
+    state = getRuntimeContext().getState(stateDescriptor)
 
-      val updateDescriptor = new ListStateDescriptor("times", Types.LONG)
-      updateTimes = getRuntimeContext().getListState(updateDescriptor)
-   }
- 
-   @throws[Exception]
-   override def processElement(value: Integer, ctx: KeyedProcessFunction[ Integer, Integer, Void ]#Context, out: Collector[Void]): Unit = {
-      state.update(value + 1)
-      updateTimes.add(System.currentTimeMillis)
-   }
+    val updateDescriptor = new ListStateDescriptor("times", createTypeInformation[Long])
+    updateTimes = getRuntimeContext().getListState(updateDescriptor)
+  }
+
+  @throws[Exception]
+  override def processElement(value: Int, ctx: KeyedProcessFunction[ Int, Int, Void ]#Context, out: Collector[Void]): Unit = {

Review comment:
       ```suggestion
     override def processElement(value: Int, ctx: KeyedProcessFunction[Int, Int, Void]#Context, out: Collector[Void]): Unit = {
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] sjwiesman closed pull request #13266: [FLINK-15719] fix mistake of reading state in scala lang.

Posted by GitBox <gi...@apache.org>.
sjwiesman closed pull request #13266:
URL: https://github.com/apache/flink/pull/13266


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org