[GitHub] [james-project] Arsnael commented on a change in pull request #248: [ADR] Applicative read repairs (POC mailbox & mailbox-counters)

[GitBox <gi...@apache.org>]

Arsnael commented on a change in pull request #248:
URL: https://github.com/apache/james-project/pull/248#discussion_r497948939



##########
File path: src/adr/0042-applicative-read-repairs.md
##########
@@ -54,7 +55,13 @@ Cassandra provides some alternative by itself:
  - Materialized view enables Cassandra to maintain a projection on the behalf of the application,
  coming with an expensive write cost, requiring synchronisation, not fit for complex denormalization
  (like the message one: the primary key of the originating table needs to appear in the materialized
- view primary key).
+ view primary key). Most of all, the updates are performed asynchronously. This mechanism is considered experimental.
+ - Cassandra BATCH suffers from the following downsides:
+   - A batch containing conditional updates can only operate within a single partition
+   - It is unadvised to update many partition in a single batch, and keep the cardinality low for performance reasons

Review comment:
       ```suggestion
      - It is unadvised to update many partitions in a single batch, and keep the cardinality low for performance reasons
   ```

##########
File path: src/adr/0042-applicative-read-repairs.md
##########
@@ -54,7 +55,13 @@ Cassandra provides some alternative by itself:
  - Materialized view enables Cassandra to maintain a projection on the behalf of the application,
  coming with an expensive write cost, requiring synchronisation, not fit for complex denormalization
  (like the message one: the primary key of the originating table needs to appear in the materialized
- view primary key).
+ view primary key). Most of all, the updates are performed asynchronously. This mechanism is considered experimental.
+ - Cassandra BATCH suffers from the following downsides:
+   - A batch containing conditional updates can only operate within a single partition
+   - It is unadvised to update many partition in a single batch, and keep the cardinality low for performance reasons
+
+BATCH could be a good option to keep to tables synchronized, but do not apply to mailboxes (conditional update) nor

Review comment:
       ```suggestion
   BATCH could be a good option to keep tables synchronized, but does not apply to mailboxes (conditional update) nor
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org