You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "dsuhinin (via GitHub)" <gi...@apache.org> on 2026/08/17 07:26:35 UTC

[PR] Extend user settings with additional configuration [airflow]

dsuhinin opened a new pull request, #71699:
URL: https://github.com/apache/airflow/pull/71699

   Right now every task instance opens on the Logs tab, and the app always lands on the Home dashboard. If you prefer something else, you're clicking your way there every single time. This adds two small, opt-in knobs so a deployment can set better defaults — and if you don't touch them, nothing changes.          
                                                                                                                                                                                                                                                                                                                             
     `default_landing_page` (defaults to home) sets what the root URL opens. Switch it to dags and / takes you straight to the Dag list. The Home dashboard is still there at /home, so you don't lose anything. A tiny LandingPage component just decides whether to show the dashboard or redirect, based on the value from /ui/config — no server-side routing.                                                                                                                                                                                                                                                                               
                                                                                                                                                                                                                                                                                                                             
     `default_task_instance_tab` sets which tab a task instance opens on (say, details). The index route reads the value and redirects there, keeping the query string and hash intact. Anything unknown or unset falls back to logs, so existing behavior and deep links stay exactly as they are. And if you're clicking task-to-task in the grid, your explicit tab choice still wins.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Extend user settings with additional configuration [airflow]

Posted by "dsuhinin (via GitHub)" <gi...@apache.org>.
dsuhinin commented on PR #71699:
URL: https://github.com/apache/airflow/pull/71699#issuecomment-5324823433

   > Also, for the translation keys, I think it would be better to have the translations handled by native contributors for each language. Would you mind reverting those changes from this PR?
   
   Yep, I can revert them without any problem, though it seems like AI could do it almost natively as well. In my view, having a translation available — even if it contains small errors — is more valuable than having none at all. What do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Extend user settings with additional configuration [airflow]

Posted by "dsuhinin (via GitHub)" <gi...@apache.org>.
dsuhinin commented on PR #71699:
URL: https://github.com/apache/airflow/pull/71699#issuecomment-5368490779

   @uranusjr @bbovenzi do you think guys that we can somehow try to move forward here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Extend user settings with additional configuration [airflow]

Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi merged PR #71699:
URL: https://github.com/apache/airflow/pull/71699


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Extend user settings with additional configuration [airflow]

Posted by "dsuhinin (via GitHub)" <gi...@apache.org>.
dsuhinin commented on PR #71699:
URL: https://github.com/apache/airflow/pull/71699#issuecomment-5338791327

   ok, I think now description should be fully up to date.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Extend user settings with additional configuration [airflow]

Posted by "dsuhinin (via GitHub)" <gi...@apache.org>.
dsuhinin commented on code in PR #71699:
URL: https://github.com/apache/airflow/pull/71699#discussion_r3854822235


##########
airflow-core/src/airflow/ui/src/utils/links.ts:
##########
@@ -19,6 +19,18 @@
 import type { TaskInstanceResponse } from "openapi/requests/types.gen";
 import { taskInstanceRoutes } from "src/router";
 
+export type TaskInstanceTab =

Review Comment:
   got it. Ill try to consolidate everything.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Extend user settings with additional configuration [airflow]

Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on PR #71699:
URL: https://github.com/apache/airflow/pull/71699#issuecomment-5338405984

   Am I missing something, or does the PR description not match the actual implementation?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Extend user settings with additional configuration [airflow]

Posted by "dsuhinin (via GitHub)" <gi...@apache.org>.
dsuhinin commented on PR #71699:
URL: https://github.com/apache/airflow/pull/71699#issuecomment-5338528259

   > Am I missing something, or does the PR description not match the actual implementation?
   
   
   emm, why? I've introduced 2 new settings into user setting page: `default_landing_page` and `default_task_instance_tab`. probably this is what is mentioned in a description and what is code about. can you please explain what is wrong?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Extend user settings with additional configuration [airflow]

Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on code in PR #71699:
URL: https://github.com/apache/airflow/pull/71699#discussion_r3831838827


##########
airflow-core/src/airflow/ui/src/pages/Dag/Overview/TaskLogPreview.tsx:
##########
@@ -73,7 +73,7 @@ export const TaskLogPreview = ({
               : translate("overview.failedLogs.showLogs")}
           </Button>
           <ClearTaskInstanceButton taskInstance={taskInstance} />
-          <RouterLink fontSize="sm" to={getTaskInstanceLink(taskInstance)}>
+          <RouterLink fontSize="sm" to={`${getTaskInstanceLink(taskInstance)}/logs`}>

Review Comment:
   We should update `getTaskInstanceLink(ti: TaskInstance, tab?: enum)`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Extend user settings with additional configuration [airflow]

Posted by "dsuhinin (via GitHub)" <gi...@apache.org>.
dsuhinin commented on code in PR #71699:
URL: https://github.com/apache/airflow/pull/71699#discussion_r3841730155


##########
airflow-core/src/airflow/ui/src/layouts/Nav/Nav.tsx:
##########
@@ -171,7 +171,7 @@ export const Nav = () => {
             />
           </Link>
         </Box>
-        <NavButton data-testid="nav-home-link" icon={FiHome} title={translate("nav.home")} to="/" />
+        <NavButton data-testid="nav-home-link" icon={FiHome} title={translate("nav.home")} to="/home" />

Review Comment:
   I believe it should be fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Extend user settings with additional configuration [airflow]

Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on code in PR #71699:
URL: https://github.com/apache/airflow/pull/71699#discussion_r3831826833


##########
airflow-core/src/airflow/ui/src/layouts/Nav/Nav.tsx:
##########
@@ -171,7 +171,7 @@ export const Nav = () => {
             />
           </Link>
         </Box>
-        <NavButton data-testid="nav-home-link" icon={FiHome} title={translate("nav.home")} to="/" />
+        <NavButton data-testid="nav-home-link" icon={FiHome} title={translate("nav.home")} to="/home" />

Review Comment:
   I think we need to redo this button. Remove "home" and replace it with "dashboard"
   
   Maybe a new icon too: https://react-icons.github.io/react-icons/search/#q=dashboard



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Extend user settings with additional configuration [airflow]

Posted by "dsuhinin (via GitHub)" <gi...@apache.org>.
dsuhinin commented on PR #71699:
URL: https://github.com/apache/airflow/pull/71699#issuecomment-5324680491

   > Could you also attach screenshots showing the UI before and after the changes? This would be helpful for reviewers to better understand the changes :)
   
   of course!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Extend user settings with additional configuration [airflow]

Posted by "dsuhinin (via GitHub)" <gi...@apache.org>.
dsuhinin commented on PR #71699:
URL: https://github.com/apache/airflow/pull/71699#issuecomment-5482385881

   > Thanks for all the back and forth!
   
   no problem at all! thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Extend user settings with additional configuration [airflow]

Posted by "dsuhinin (via GitHub)" <gi...@apache.org>.
dsuhinin commented on PR #71699:
URL: https://github.com/apache/airflow/pull/71699#issuecomment-5324791058

   > Could you also attach screenshots showing the UI before and after the changes? This would be helpful for reviewers to better understand the changes :)
   
   should be done. please take a look.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Extend user settings with additional configuration [airflow]

Posted by "dsuhinin (via GitHub)" <gi...@apache.org>.
dsuhinin commented on PR #71699:
URL: https://github.com/apache/airflow/pull/71699#issuecomment-5324862498

   @Lee-W @shahar1 guys, can I kindly ask you to check related translations? I remember you've already helped me with that in one of my previous PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Extend user settings with additional configuration [airflow]

Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on code in PR #71699:
URL: https://github.com/apache/airflow/pull/71699#discussion_r3845007462


##########
airflow-core/src/airflow/ui/src/utils/links.ts:
##########
@@ -19,6 +19,18 @@
 import type { TaskInstanceResponse } from "openapi/requests/types.gen";
 import { taskInstanceRoutes } from "src/router";
 
+export type TaskInstanceTab =

Review Comment:
   We have TaskInstanceTab tab declared here and in useUserSettings. But we already have `tab.ts` from #70699.
   
   Let's consolidate these sources of truth. Especially because the real source of truth is the router.ts page. We probably want the constant and enum type to live side-by-side and be used to power the router so that a future contributor doesn't break these settings by adding another tab without knowing how many other places they need to update.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Extend user settings with additional configuration [airflow]

Posted by "dsuhinin (via GitHub)" <gi...@apache.org>.
dsuhinin commented on code in PR #71699:
URL: https://github.com/apache/airflow/pull/71699#discussion_r3841731576


##########
airflow-core/src/airflow/ui/src/pages/Dag/Overview/TaskLogPreview.tsx:
##########
@@ -73,7 +73,7 @@ export const TaskLogPreview = ({
               : translate("overview.failedLogs.showLogs")}
           </Button>
           <ClearTaskInstanceButton taskInstance={taskInstance} />
-          <RouterLink fontSize="sm" to={getTaskInstanceLink(taskInstance)}>
+          <RouterLink fontSize="sm" to={`${getTaskInstanceLink(taskInstance)}/logs`}>

Review Comment:
   changed and fixed all the places.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Extend user settings with additional configuration [airflow]

Posted by "dsuhinin (via GitHub)" <gi...@apache.org>.
dsuhinin commented on PR #71699:
URL: https://github.com/apache/airflow/pull/71699#issuecomment-5333440648

   > Please move the translations to another PR. Its best if we can evaluate the code logic and the translation correctness separately.
   
   ok. reverted everything except: ru and eng. please take a look now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Extend user settings with additional configuration [airflow]

Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on PR #71699:
URL: https://github.com/apache/airflow/pull/71699#issuecomment-5339311565

   I would suggest dropping the Russian translation files. Most reviewers we have don’t read Russian, so bundling those changes in the same PR will significantly drag out the review process until we can find someone to review those parts. It would be better if this only touches the actual UI changes (and the en file, which is needed), and submit the translation changes in a later PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Extend user settings with additional configuration [airflow]

Posted by "dsuhinin (via GitHub)" <gi...@apache.org>.
dsuhinin commented on PR #71699:
URL: https://github.com/apache/airflow/pull/71699#issuecomment-5475643242

   @uranusjr @bbovenzi can you please take a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Extend user settings with additional configuration [airflow]

Posted by "dsuhinin (via GitHub)" <gi...@apache.org>.
dsuhinin commented on code in PR #71699:
URL: https://github.com/apache/airflow/pull/71699#discussion_r3855484239


##########
airflow-core/src/airflow/ui/src/utils/links.ts:
##########
@@ -19,6 +19,18 @@
 import type { TaskInstanceResponse } from "openapi/requests/types.gen";
 import { taskInstanceRoutes } from "src/router";
 
+export type TaskInstanceTab =

Review Comment:
   should be fixed. consolidate everything in `tab.ts` so now it is just one single source of truth.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Extend user settings with additional configuration [airflow]

Posted by "dsuhinin (via GitHub)" <gi...@apache.org>.
dsuhinin commented on code in PR #71699:
URL: https://github.com/apache/airflow/pull/71699#discussion_r3855484239


##########
airflow-core/src/airflow/ui/src/utils/links.ts:
##########
@@ -19,6 +19,18 @@
 import type { TaskInstanceResponse } from "openapi/requests/types.gen";
 import { taskInstanceRoutes } from "src/router";
 
+export type TaskInstanceTab =

Review Comment:
   should be fixed. consolidate everything in `tab.ts` so now it is just one source of truth.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Extend user settings with additional configuration [airflow]

Posted by "dsuhinin (via GitHub)" <gi...@apache.org>.
dsuhinin commented on PR #71699:
URL: https://github.com/apache/airflow/pull/71699#issuecomment-5339695746

   > I would suggest dropping the Russian translation files. Most reviewers we have don’t read Russian, so bundling those changes in the same PR will significantly drag out the review process until we can find someone to review those parts. It would be better if this only touches the actual UI changes (and the en file, which is needed), and submit the translation changes in a later PR.
   
   sure, removed it already.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Extend user settings with additional configuration [airflow]

Posted by "choo121600 (via GitHub)" <gi...@apache.org>.
choo121600 commented on PR #71699:
URL: https://github.com/apache/airflow/pull/71699#issuecomment-5322529383

   Could you also attach screenshots showing the UI before and after the changes?
   This would be helpful for reviewers to better understand the changes :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org