[GitHub] [incubator-zipkin-brave] virendraagarwal opened a new issue #919: Span not reporting http status 200 ok for successful api request

[GitBox <gi...@apache.org>]

virendraagarwal opened a new issue #919: Span not reporting http status 200 ok for successful api request
URL: https://github.com/apache/incubator-zipkin-brave/issues/919
 
 
   We are using Brave API for Tracing.
   We found one issue when a API request is successful its span data does not include http.status_code tag as 200 in case of error it is tagging the error.
   
   After debugging this method returns null in case status code is between 200 to 399
   Class Name : HttpParser
   
   @Nullable String maybeStatusAsString(int statusCode, int upperRange) {
       if (statusCode != 0 && (statusCode < 200 || statusCode > upperRange)) {
         return String.valueOf(statusCode);
       }
       return null;
     }
   
   Upper range hardcoded as 299 for success and 399 for error 
   Looks like an issue as multiple status codes will be missing through this implementation.
   Can you explain it in detail.
   
   Thanks
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@zipkin.apache.org
For additional commands, e-mail: dev-help@zipkin.apache.org