[GitHub] [arrow] nealrichardson commented on a diff in pull request #12980: ARROW-16281: [R] [CI] Bump versions with the release of 4.2

[GitBox <gi...@apache.org>]

nealrichardson commented on code in PR #12980:
URL: https://github.com/apache/arrow/pull/12980#discussion_r867031401


##########
ci/docker/linux-apt-lint.dockerfile:
##########
@@ -40,7 +40,7 @@ RUN apt-get update && \
     && apt-get clean \
     && rm -rf /var/lib/apt/lists/*
 
-ARG r=4.1
+ARG r=4.2
 RUN wget -qO- https://cloud.r-project.org/bin/linux/ubuntu/marutter_pubkey.asc | \
         tee -a /etc/apt/trusted.gpg.d/cran_ubuntu_key.asc && \
     # NOTE: R 3.5 and 3.6 are available in the repos with -cran35 suffix

Review Comment:
   I can't make a suggestion spanning this whole block, but delete this comment to say that only R >= 4.0 is available in this repo. 
   
   Maintaining this hack so that we could technically support R 3.5 or 3.6, [but only on Ubuntu 18.04 or earlier](https://cloud.r-project.org/bin/linux/ubuntu/olderreleasesREADME.html), is more harm than help, as you experienced in this PR. We don't have any jobs that do that. When we test older R versions, we either use `r-lib/actions/setup-r` or Docker images. 



##########
ci/docker/linux-apt-r.dockerfile:
##########
@@ -44,7 +44,7 @@ RUN apt-get update -y && \
     # R 3.4 is available without the suffix but only for trusty and xenial
     # TODO: make sure OS version and R version are valid together and conditionally set repo suffix
     # This is a hack to turn 3.6 into 35, and 4.0/4.1 into 40:
-    add-apt-repository 'deb https://cloud.r-project.org/bin/linux/ubuntu '$(lsb_release -cs)'-cran'$(echo "${r}" | tr -d . | tr 6 5 | tr 1 0)'/' && \
+    add-apt-repository 'deb https://cloud.r-project.org/bin/linux/ubuntu '$(lsb_release -cs)'-cran'$(echo "${r}" | tr -d . | tr 6 5 | tr 1-2 0)'/' && \

Review Comment:
   same as in the other dockerfile



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org