You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2009/01/23 22:55:59 UTC
[jira] Created: (HBASE-1150) HMsg carries safemode flag; remove
HMsg carries safemode flag; remove
----------------------------------
Key: HBASE-1150
URL: https://issues.apache.org/jira/browse/HBASE-1150
Project: Hadoop HBase
Issue Type: Bug
Reporter: stack
HMsg got a state flag on committ of HBASE-1121. This kinda pollutes the simple HMsg type -- a shell for carrying state as byte type -- to instead being a vehicle that carries state in byte and in a boolean that is only used on cluster start then never read again but is passed in all HMsgs anyways. Can we get rid of it when we integrate zk? Go to zk to figure if master is in safe mode?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1150) HMsg carries safemode flag; remove
Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Kellerman updated HBASE-1150:
---------------------------------
Issue Type: Sub-task (was: Bug)
Parent: HBASE-546
> HMsg carries safemode flag; remove
> ----------------------------------
>
> Key: HBASE-1150
> URL: https://issues.apache.org/jira/browse/HBASE-1150
> Project: Hadoop HBase
> Issue Type: Sub-task
> Reporter: stack
>
> HMsg got a state flag on committ of HBASE-1121. This kinda pollutes the simple HMsg type -- a shell for carrying state as byte type -- to instead being a vehicle that carries state in byte and in a boolean that is only used on cluster start then never read again but is passed in all HMsgs anyways. Can we get rid of it when we integrate zk? Go to zk to figure if master is in safe mode?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1150) HMsg carries safemode flag; remove
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-1150:
-------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Thanks for the patch Nitay.
> HMsg carries safemode flag; remove
> ----------------------------------
>
> Key: HBASE-1150
> URL: https://issues.apache.org/jira/browse/HBASE-1150
> Project: Hadoop HBase
> Issue Type: Sub-task
> Affects Versions: 0.20.0
> Reporter: stack
> Assignee: Nitay Joffe
> Fix For: 0.20.0
>
> Attachments: hbase-1150.patch
>
>
> HMsg got a state flag on committ of HBASE-1121. This kinda pollutes the simple HMsg type -- a shell for carrying state as byte type -- to instead being a vehicle that carries state in byte and in a boolean that is only used on cluster start then never read again but is passed in all HMsgs anyways. Can we get rid of it when we integrate zk? Go to zk to figure if master is in safe mode?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1150) HMsg carries safemode flag; remove
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nitay Joffe updated HBASE-1150:
-------------------------------
Attachment: hbase-1150.patch
The main logical change of this patch is this:
--- a/src/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
+++ b/src/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
@@ -380,7 +380,7 @@ public class HRegionServer implements HConstants, HRegionInterface, HBaseRPCErro
i++) {
LOG.info(msgs[i].toString());
if (safeMode.get()) {
- if (!msgs[i].isInSafeMode()) {
+ if (zooKeeperWrapper.checkOutOfSafeMode()) {
this.connection.unsetRootRegionLocation();
synchronized (safeMode) {
safeMode.set(false);
Everything else is just removing safeMode member from HMsg.
> HMsg carries safemode flag; remove
> ----------------------------------
>
> Key: HBASE-1150
> URL: https://issues.apache.org/jira/browse/HBASE-1150
> Project: Hadoop HBase
> Issue Type: Sub-task
> Reporter: stack
> Assignee: Nitay Joffe
> Attachments: hbase-1150.patch
>
>
> HMsg got a state flag on committ of HBASE-1121. This kinda pollutes the simple HMsg type -- a shell for carrying state as byte type -- to instead being a vehicle that carries state in byte and in a boolean that is only used on cluster start then never read again but is passed in all HMsgs anyways. Can we get rid of it when we integrate zk? Go to zk to figure if master is in safe mode?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HBASE-1150) HMsg carries safemode flag; remove
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nitay Joffe updated HBASE-1150:
-------------------------------
Fix Version/s: 0.20.0
Affects Version/s: 0.20.0
Status: Patch Available (was: Open)
> HMsg carries safemode flag; remove
> ----------------------------------
>
> Key: HBASE-1150
> URL: https://issues.apache.org/jira/browse/HBASE-1150
> Project: Hadoop HBase
> Issue Type: Sub-task
> Affects Versions: 0.20.0
> Reporter: stack
> Assignee: Nitay Joffe
> Fix For: 0.20.0
>
> Attachments: hbase-1150.patch
>
>
> HMsg got a state flag on committ of HBASE-1121. This kinda pollutes the simple HMsg type -- a shell for carrying state as byte type -- to instead being a vehicle that carries state in byte and in a boolean that is only used on cluster start then never read again but is passed in all HMsgs anyways. Can we get rid of it when we integrate zk? Go to zk to figure if master is in safe mode?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (HBASE-1150) HMsg carries safemode
flag; remove
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12690143#action_12690143 ]
Nitay Joffe edited comment on HBASE-1150 at 3/27/09 3:57 PM:
-------------------------------------------------------------
The main logical change of this patch is this:
{code}
--- a/src/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
+++ b/src/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
@@ -380,7 +380,7 @@ public class HRegionServer implements HConstants, HRegionInterface, HBaseRPCErro
i++) {
LOG.info(msgs[i].toString());
if (safeMode.get()) {
- if (!msgs[i].isInSafeMode()) {
+ if (zooKeeperWrapper.checkOutOfSafeMode()) {
this.connection.unsetRootRegionLocation();
synchronized (safeMode) {
safeMode.set(false);
{code}
Everything else is just removing safeMode member from HMsg.
was (Author: nitay):
The main logical change of this patch is this:
--- a/src/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
+++ b/src/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
@@ -380,7 +380,7 @@ public class HRegionServer implements HConstants, HRegionInterface, HBaseRPCErro
i++) {
LOG.info(msgs[i].toString());
if (safeMode.get()) {
- if (!msgs[i].isInSafeMode()) {
+ if (zooKeeperWrapper.checkOutOfSafeMode()) {
this.connection.unsetRootRegionLocation();
synchronized (safeMode) {
safeMode.set(false);
Everything else is just removing safeMode member from HMsg.
> HMsg carries safemode flag; remove
> ----------------------------------
>
> Key: HBASE-1150
> URL: https://issues.apache.org/jira/browse/HBASE-1150
> Project: Hadoop HBase
> Issue Type: Sub-task
> Affects Versions: 0.20.0
> Reporter: stack
> Assignee: Nitay Joffe
> Fix For: 0.20.0
>
> Attachments: hbase-1150.patch
>
>
> HMsg got a state flag on committ of HBASE-1121. This kinda pollutes the simple HMsg type -- a shell for carrying state as byte type -- to instead being a vehicle that carries state in byte and in a boolean that is only used on cluster start then never read again but is passed in all HMsgs anyways. Can we get rid of it when we integrate zk? Go to zk to figure if master is in safe mode?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HBASE-1150) HMsg carries safemode flag; remove
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-1150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nitay Joffe reassigned HBASE-1150:
----------------------------------
Assignee: Nitay Joffe
> HMsg carries safemode flag; remove
> ----------------------------------
>
> Key: HBASE-1150
> URL: https://issues.apache.org/jira/browse/HBASE-1150
> Project: Hadoop HBase
> Issue Type: Sub-task
> Reporter: stack
> Assignee: Nitay Joffe
>
> HMsg got a state flag on committ of HBASE-1121. This kinda pollutes the simple HMsg type -- a shell for carrying state as byte type -- to instead being a vehicle that carries state in byte and in a boolean that is only used on cluster start then never read again but is passed in all HMsgs anyways. Can we get rid of it when we integrate zk? Go to zk to figure if master is in safe mode?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.