You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "JiriOndrusek (via GitHub)" <gi...@apache.org> on 2023/10/09 09:52:11 UTC
[PR] Sql: Test SqlTest#testDefaultErrorCode fails with mssql [camel-quarkus]
JiriOndrusek opened a new pull request, #5416:
URL: https://github.com/apache/camel-quarkus/pull/5416
fixes https://github.com/apache/camel-quarkus/issues/5411
<!-- Uncomment and fill this section if your PR is not trivial
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Sql: Test SqlTest#testDefaultErrorCode fails with mssql [camel-quarkus]
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton merged PR #5416:
URL: https://github.com/apache/camel-quarkus/pull/5416
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Sql: Test SqlTest#testDefaultErrorCode fails with mssql [camel-quarkus]
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on code in PR #5416:
URL: https://github.com/apache/camel-quarkus/pull/5416#discussion_r1354300714
##########
integration-tests/sql/src/test/java/org/apache/camel/quarkus/component/sql/it/SqlTest.java:
##########
@@ -41,6 +42,9 @@
@QuarkusTestResource(DerbyTestResource.class)
class SqlTest {
+ @ConfigProperty(name = "quarkus.datasource.db-kind")
Review Comment:
It worked for me localy, so I thought that it is solved in the newest Qarkus -> using a rest is the solution. I'll change that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Sql: Test SqlTest#testDefaultErrorCode fails with mssql [camel-quarkus]
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on code in PR #5416:
URL: https://github.com/apache/camel-quarkus/pull/5416#discussion_r1351789331
##########
integration-tests/sql/src/test/java/org/apache/camel/quarkus/component/sql/it/SqlTest.java:
##########
@@ -41,6 +42,9 @@
@QuarkusTestResource(DerbyTestResource.class)
class SqlTest {
+ @ConfigProperty(name = "quarkus.datasource.db-kind")
Review Comment:
```
org.junit.platform.commons.JUnitException: @ConfigProperty is not supported in @QuarkusIntegrationTest tests. Offending field is org.apache.camel.quarkus.component.sql.it.SqlTest.dbKind
```
Maybe try resolving the db type by invoking a REST endpoint or something like that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Sql: Test SqlTest#testDefaultErrorCode fails with mssql [camel-quarkus]
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on code in PR #5416:
URL: https://github.com/apache/camel-quarkus/pull/5416#discussion_r1354541424
##########
integration-tests/sql/src/test/java/org/apache/camel/quarkus/component/sql/it/SqlTest.java:
##########
@@ -41,6 +42,9 @@
@QuarkusTestResource(DerbyTestResource.class)
class SqlTest {
+ @ConfigProperty(name = "quarkus.datasource.db-kind")
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org