You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Daniel Roudnitsky (Jira)" <ji...@apache.org> on 2024/09/30 14:22:00 UTC
[jira] [Updated] (HBASE-28771) Add support for non replica actions to AsyncRequestFutureImpl.isActionComplete
[ https://issues.apache.org/jira/browse/HBASE-28771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Roudnitsky updated HBASE-28771:
--------------------------------------
Resolution: Not A Problem
Status: Resolved (was: Patch Available)
Not needed for parent Jira + non replica actions don't necessarily have a result array so this approach does not work for all action types
> Add support for non replica actions to AsyncRequestFutureImpl.isActionComplete
> ------------------------------------------------------------------------------
>
> Key: HBASE-28771
> URL: https://issues.apache.org/jira/browse/HBASE-28771
> Project: HBase
> Issue Type: Sub-task
> Components: Client
> Affects Versions: 2.6.0, 2.5.10
> Reporter: Daniel Roudnitsky
> Assignee: Daniel Roudnitsky
> Priority: Minor
> Labels: pull-request-available
>
> The current isActionComplete method we have in AsyncRequestFutureImpl is only designed to support replica actions, it would be useful to have isActionComplete support non replica actions that could be reused for HBASE-27781 / [#6144|https://github.com/apache/hbase/pull/6144/files] and in other paths where non replica actions are being handled.
> Since isActionComplete currently only has one caller we can move the replica action check to the caller method instead of having the check be inside isActionComplete.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)