You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/03/10 00:33:46 UTC
[GitHub] [tvm] spectrometerHBH opened a new pull request #10557: [TIR] compact buffer region
spectrometerHBH opened a new pull request #10557:
URL: https://github.com/apache/tvm/pull/10557
The compacted buffer's shape should be at most the same as the original shape.
cc @junrushao1994
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #10557: [TIR] compact buffer region
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #10557:
URL: https://github.com/apache/tvm/pull/10557#issuecomment-1071954703
@spectrometerHBH we need to get this PR in for performance alignment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #10557: [TIR] compact buffer region
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #10557:
URL: https://github.com/apache/tvm/pull/10557#issuecomment-1063523182
Thanks for the fix! It's essential for AutoTIR performance!! Please add a regression test :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] wrongtest commented on a change in pull request #10557: [TIR] compact buffer region
Posted by GitBox <gi...@apache.org>.
wrongtest commented on a change in pull request #10557:
URL: https://github.com/apache/tvm/pull/10557#discussion_r824784743
##########
File path: src/tir/transforms/compact_buffer_region.cc
##########
@@ -53,12 +53,30 @@ Region SimplifyAndNarrowBufferRegionFromNDIntSet(const NDIntSet& nd_int_set,
for (size_t i = 0; i < nd_int_set.size(); ++i) {
const arith::IntSet& int_set = nd_int_set[i];
Range range = int_set.CoverRange(Range(/*begin=*/0, /*end=*/original_shape[i]));
- result.push_back(
- Range::FromMinExtent(analyzer->Simplify(range->min), analyzer->Simplify(range->extent)));
+ result.push_back(Range::FromMinExtent(
+ analyzer->Simplify(range->min), analyzer->Simplify(min(original_shape[i], range->extent))));
Review comment:
Whether we need `max(0, range->min)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #10557: [TIR] compact buffer region
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #10557:
URL: https://github.com/apache/tvm/pull/10557#issuecomment-1071954703
@spectrometerHBH we need to get this PR in for performance alignment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #10557: [TIR] compact buffer region
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #10557:
URL: https://github.com/apache/tvm/pull/10557#issuecomment-1064349866
@spectrometerHBH would you like to rebase? Looks like the CI is very flaky
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] spectrometerHBH commented on a change in pull request #10557: [TIR] compact buffer region
Posted by GitBox <gi...@apache.org>.
spectrometerHBH commented on a change in pull request #10557:
URL: https://github.com/apache/tvm/pull/10557#discussion_r824851602
##########
File path: src/tir/transforms/compact_buffer_region.cc
##########
@@ -53,12 +53,30 @@ Region SimplifyAndNarrowBufferRegionFromNDIntSet(const NDIntSet& nd_int_set,
for (size_t i = 0; i < nd_int_set.size(); ++i) {
const arith::IntSet& int_set = nd_int_set[i];
Range range = int_set.CoverRange(Range(/*begin=*/0, /*end=*/original_shape[i]));
- result.push_back(
- Range::FromMinExtent(analyzer->Simplify(range->min), analyzer->Simplify(range->extent)));
+ result.push_back(Range::FromMinExtent(
+ analyzer->Simplify(range->min), analyzer->Simplify(min(original_shape[i], range->extent))));
Review comment:
We can do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Hzfengsy merged pull request #10557: [TIR] compact buffer region
Posted by GitBox <gi...@apache.org>.
Hzfengsy merged pull request #10557:
URL: https://github.com/apache/tvm/pull/10557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org