[GitHub] [beam] j-arrow commented on a change in pull request #14743: [BEAM-12225] Replace AWS API used to list shards from DescribeStream to ListShards

[GitBox <gi...@apache.org>]

j-arrow commented on a change in pull request #14743:
URL: https://github.com/apache/beam/pull/14743#discussion_r645414935



##########
File path: sdks/java/io/kinesis/src/main/java/org/apache/beam/sdk/io/kinesis/SimplifiedKinesisClient.java
##########
@@ -61,18 +69,33 @@
   private static final int PERIOD_GRANULARITY_IN_SECONDS = 60;
   private static final String SUM_STATISTIC = "Sum";
   private static final String STREAM_NAME_DIMENSION = "StreamName";
-  private static final int LIST_SHARDS_DESCRIBE_STREAM_MAX_ATTEMPTS = 10;
-  private static final Duration LIST_SHARDS_DESCRIBE_STREAM_INITIAL_BACKOFF =
+  private static final int LIST_SHARDS_MAX_RESULTS = 1_000;
+  private static final Duration
+      SPACING_FOR_TIMESTAMP_LIST_SHARDS_REQUEST_TO_NOT_EXCEED_TRIM_HORIZON =

Review comment:
       This name is so long to better describe what it does. if it would be shorter, it would be hard to describe what it does without adding comment to it. As such, I think it is better way to use the one I have proposed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org