You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "dspangen (via GitHub)" <gi...@apache.org> on 2024/04/05 20:49:04 UTC
[I] Adding Project Loom Support [mina-sshd]
dspangen opened a new issue, #480:
URL: https://github.com/apache/mina-sshd/issues/480
### Description
Hi, I noticed there are quite a few uses of spinlocks (`synchronized` usage) within mina. Are there any plans to replace these with `ResourceLocks` to prevent thread pinning (as discussed in [JEP-444](https://openjdk.org/jeps/444))? Without it, it's not reasonable to use mina with virtual threads in all cases.
### Motivation
Scalability
### Alternatives considered
_No response_
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
Re: [I] Adding Project Loom Support [mina-sshd]
Posted by "tomaswolf (via GitHub)" <gi...@apache.org>.
tomaswolf closed issue #480: Adding Project Loom Support
URL: https://github.com/apache/mina-sshd/issues/480
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
Re: [I] Adding Project Loom Support [mina-sshd]
Posted by "tomaswolf (via GitHub)" <gi...@apache.org>.
tomaswolf commented on issue #480:
URL: https://github.com/apache/mina-sshd/issues/480#issuecomment-2042182161
No, there are currently no such plans. Also from JEP-444:
> In a future release we may be able to remove the first limitation above, namely pinning inside synchronized.
Object monitors are a very useful language feature; replacing them all by `ReentrantLock`s will complicate the code and reduce its readability considerably and gives rise to new possibilities to make mistakes.
Apache MINA SSHD is built on the asynchronous I/O model; it's not clear to me how easy or complicated it might be to adapt it to virtual threads such that it actually benefits from them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org