You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2017/07/10 09:47:11 UTC
Review Request 60738: HdfsResource can not handle S3 URL when
hbase.rootdir is set to S3 URL
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60738/
-----------------------------------------------------------
Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, and Vitalyi Brodetskyi.
Bugs: AMBARI-20950
https://issues.apache.org/jira/browse/AMBARI-20950
Repository: ambari
Description
-------
HBASE-17437 enables HBASE to put its rootdir on S3. Ambari calls HdfsResource
to create the dir for HBase, but it can not handle S3.
Fix should be similar to AMBARI-15157 for Hive.
Diffs
-----
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 68856ce
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 43c6036
Diff: https://reviews.apache.org/r/60738/diff/1/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 60738: HdfsResource can not handle S3 URL when
hbase.rootdir is set to S3 URL
Posted by Alejandro Fernandez <af...@hortonworks.com>.
> On July 10, 2017, 5:08 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
> > Lines 197 (patched)
> > <https://reviews.apache.org/r/60738/diff/1/?file=1772249#file1772249line197>
> >
> > This is already needed in HBase for 3.0
> > Please add a comment as well explaining why this was needed.
Typo, "This is also needed in HBase for 3.0"
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60738/#review180055
-----------------------------------------------------------
On July 10, 2017, 9:47 a.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60738/
> -----------------------------------------------------------
>
> (Updated July 10, 2017, 9:47 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20950
> https://issues.apache.org/jira/browse/AMBARI-20950
>
>
> Repository: ambari
>
>
> Description
> -------
>
> HBASE-17437 enables HBASE to put its rootdir on S3. Ambari calls HdfsResource
> to create the dir for HBase, but it can not handle S3.
> Fix should be similar to AMBARI-15157 for Hive.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 68856ce
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 43c6036
>
>
> Diff: https://reviews.apache.org/r/60738/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 60738: HdfsResource can not handle S3 URL when
hbase.rootdir is set to S3 URL
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60738/#review180055
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
Lines 197 (patched)
<https://reviews.apache.org/r/60738/#comment255062>
This is already needed in HBase for 3.0
Please add a comment as well explaining why this was needed.
- Alejandro Fernandez
On July 10, 2017, 9:47 a.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60738/
> -----------------------------------------------------------
>
> (Updated July 10, 2017, 9:47 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20950
> https://issues.apache.org/jira/browse/AMBARI-20950
>
>
> Repository: ambari
>
>
> Description
> -------
>
> HBASE-17437 enables HBASE to put its rootdir on S3. Ambari calls HdfsResource
> to create the dir for HBase, but it can not handle S3.
> Fix should be similar to AMBARI-15157 for Hive.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 68856ce
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 43c6036
>
>
> Diff: https://reviews.apache.org/r/60738/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 60738: HdfsResource can not handle S3 URL when
hbase.rootdir is set to S3 URL
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60738/#review180017
-----------------------------------------------------------
Ship it!
Ship It!
- Dmytro Sen
On Июль 10, 2017, 9:47 д.п., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60738/
> -----------------------------------------------------------
>
> (Updated Июль 10, 2017, 9:47 д.п.)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20950
> https://issues.apache.org/jira/browse/AMBARI-20950
>
>
> Repository: ambari
>
>
> Description
> -------
>
> HBASE-17437 enables HBASE to put its rootdir on S3. Ambari calls HdfsResource
> to create the dir for HBase, but it can not handle S3.
> Fix should be similar to AMBARI-15157 for Hive.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 68856ce
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 43c6036
>
>
> Diff: https://reviews.apache.org/r/60738/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 60738: HdfsResource can not handle S3 URL when
hbase.rootdir is set to S3 URL
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60738/#review180016
-----------------------------------------------------------
Ship it!
Ship It!
- Vitalyi Brodetskyi
On Липень 10, 2017, 9:47 до полудня, Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60738/
> -----------------------------------------------------------
>
> (Updated Липень 10, 2017, 9:47 до полудня)
>
>
> Review request for Ambari, Dmitro Lisnichenko, Dmytro Sen, and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-20950
> https://issues.apache.org/jira/browse/AMBARI-20950
>
>
> Repository: ambari
>
>
> Description
> -------
>
> HBASE-17437 enables HBASE to put its rootdir on S3. Ambari calls HdfsResource
> to create the dir for HBase, but it can not handle S3.
> Fix should be similar to AMBARI-15157 for Hive.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py 68856ce
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py 43c6036
>
>
> Diff: https://reviews.apache.org/r/60738/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>