[GitHub] [superset] geido commented on pull request #19579: fix: missing home label on welcome page

[GitBox <gi...@apache.org>]

geido commented on PR #19579:
URL: https://github.com/apache/superset/pull/19579#issuecomment-1091599252

   > oh wait, i see that @geido just made this change recently. can you provide more context here?
   
   @etr2460 there must have been some merging mistake here. The idea was to replace the flex with display none as this stylesheet is loaded earlier than the emotion styles, which was causing the logo to change in size while the page was loading. The emotion styles would take care of overriding the display none with the flex. However, this shouldn't affect the "Home" text which seems to be the case here. Let me have a deeper look and see what happened.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org