You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by ol...@apache.org on 2007/03/05 19:31:26 UTC
svn commit: r514774 - in /jakarta/httpcomponents/httpcore/trunk: build.xml
contrib/
Author: olegk
Date: Mon Mar 5 10:31:25 2007
New Revision: 514774
URL: http://svn.apache.org/viewvc?view=rev&rev=514774
Log:
Removed all contrib related targets from the Ant build file. I assume full responsibility for this atrocity
Modified:
jakarta/httpcomponents/httpcore/trunk/build.xml
jakarta/httpcomponents/httpcore/trunk/contrib/ (props changed)
Modified: jakarta/httpcomponents/httpcore/trunk/build.xml
URL: http://svn.apache.org/viewvc/jakarta/httpcomponents/httpcore/trunk/build.xml?view=diff&rev=514774&r1=514773&r2=514774
==============================================================================
--- jakarta/httpcomponents/httpcore/trunk/build.xml (original)
+++ jakarta/httpcomponents/httpcore/trunk/build.xml Mon Mar 5 10:31:25 2007
@@ -50,8 +50,6 @@
External dependencies for which there is no default location:
junit.jar - for test and clover targets
clover.jar - for clover target
- commons.cli.jar - for contrib-bench
- spring.jar - for contrib-spring
-->
<property name="local.properties" location="../project/build.properties" />
<property file="${local.properties}" />
@@ -196,13 +194,11 @@
-->
<target name="compile-all"
- depends="compile-src,compile-tests,compile-examples,
- compile-contrib,compile-contrib-bench,compile-contrib-spring"
+ depends="compile-src,compile-tests,compile-examples"
description="compiles everything, not from scratch"
/>
<target name="clean-compile"
- depends="clean-src,clean-tests,clean-examples,
- clean-contrib,clean-contrib-bench,clean-contrib-spring"
+ depends="clean-src,clean-tests,clean-examples"
description="cleans intermediate files from compilation"
/>
<target name="compile-all-fs"
@@ -239,24 +235,6 @@
/>
-<target name="package-addon"
- depends="dist-init,compile-src,
- compile-examples,compile-contrib,
- compile-contrib-bench,compile-contrib-spring"
- description="builds the JAR with HttpCore examples and contributions"
->
- <jar destfile="${dist.core.home}/${jar.core.addon.name}">
- <!-- manifest? -->
- <fileset dir="${build.core.main.xmpls}" includes="**" />
- <fileset dir="${build.core.main.contr}" includes="**" />
- </jar>
-</target>
-<target name="package-addon-fs"
- depends="clean-examples,clean-contrib,package-addon"
- description="builds the JAR with HttpCore examples and contributions, compiling them from scratch"
-/>
-
-
<!-- Clover always needs a recompile to instrument the source code.
clean-build enforces the recompilation, clover-init prepares
the Ant environment for Clover instrumentation.
@@ -312,65 +290,6 @@
<bottom>Copyright (c) 2005-2007 - Apache Software Foundation</bottom>
</javadoc>
</target>
-
-
-<target name="javadoc-addon"
- description="generates JavaDoc including examples and contributions"
->
- <mkdir dir="${dist.core.api}" />
- <javadoc destdir="${dist.core.api}"
- access="${javadoc.access}"
- version="true"
- author="true"
- windowtitle="${comp.core.title} (Version ${comp.core.version})"
- >
- <packageset dir="${comp.core.main.src}">
- <include name="org/apache/http/**" />
- </packageset>
- <packageset dir="${comp.core.nio.src}">
- <include name="org/apache/http/**" />
- </packageset>
- <packageset dir="${comp.core.main.xmpls}">
- <include name="org/apache/http/**" />
- </packageset>
- <packageset dir="${comp.core.nio.xmpls}">
- <include name="org/apache/http/**" />
- </packageset>
- <packageset dir="${comp.core.main.contr}">
- <include name="org/apache/http/**" />
- </packageset>
-
- <group title="API">
- <package name="org.apache.http" />
- <package name="org.apache.http.entity" />
- <package name="org.apache.http.io" />
- <package name="org.apache.http.message" />
- <package name="org.apache.http.params" />
- <package name="org.apache.http.protocol" />
- <package name="org.apache.http.util*" />
- <package name="org.apache.http.nio*" />
- </group>
- <group title="Implementation">
- <package name="org.apache.http.impl*" />
- </group>
- <group title="Examples">
- <package name="org.apache.http.examples*" />
- </group>
- <group title="Contributions (unsupported)">
- <package name="org.apache.http.contrib*" />
- </group>
-
- <classpath>
- <pathelement location="${commons.cli.jar}" />
- <pathelement location="${spring.jar}" />
- </classpath>
- <link href="${javadoc.j2sdk.link}"/>
-
- <doctitle>${comp.core.title}</doctitle>
- <bottom>Copyright (c) 2005-2007 - Apache Software Foundation</bottom>
- </javadoc>
-</target>
-
<!-- generic and helper targets =========================================== -->
Propchange: jakarta/httpcomponents/httpcore/trunk/contrib/
------------------------------------------------------------------------------
--- svn:ignore (added)
+++ svn:ignore Mon Mar 5 10:31:25 2007
@@ -0,0 +1,4 @@
+
+.classpath
+.project
+bin
Re: svn commit: r514774 - in /jakarta/httpcomponents/httpcore/trunk:
build.xml contrib/
Posted by Roland Weber <ht...@dubioso.net>.
Hi Oleg,
>>> Removed all contrib related targets from the Ant build file.
>> And how am I supposed to detect build breaks in contrib code now?
>
> Just do not. I personally do not see the sky come crashing down if the
> contrib stuff is broken temporarily. Those of us who use modern IDEs
> will eventually pick up and fix the breakage.
It is the most frequent, but not the only example where I need
the contrib targets. I need them to review contrib code, I need
them to write contrib code, and I need them to run contrib code
such as your benchmark. That change has effectively locked me
out of the contrib part of our code base.
When I set out to revamp the Ant build files last year, it was
for one reason, and one reason only: to make sure that it has
_all_ the targets I expect of a decent build process, so that I
would not have to maintain a second, extended one locally. Now
you're forcing me back into that situation.
The build files were already prepared to compile contrib code in
the main module when I suggested that move last August.[1] All that
was needed is an update of a single line in module-main/build.xml
defining the base location:
<property name="comp.core.main.contr"
location="${comp.core.home}/src/contrib"/>
<!-- @@@ contrib should be moved to module-main,[...]
If you had replaced ${comp.core.home} with ${comp.core.main.home},
or waited for me to do it, everything should have worked. Instead,
you sift through the build files and rip out everything I had put
in place to make the contrib code accessible in my environment.
This change was utterly destructive. It is not urgent since I won't
be coding anytime soon, but please revert it when you find the time.
cheers,
Roland
[1] http://issues.apache.org/jira/browse/HTTPASYNC-5#action_12429272
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
Re: svn commit: r514774 - in
/jakarta/httpcomponents/httpcore/trunk: build.xml contrib/
Posted by Oleg Kalnichevski <ol...@apache.org>.
On Sun, 2007-03-11 at 11:49 +0100, Roland Weber wrote:
> Hi Oleg,
>
> > Removed all contrib related targets from the Ant build file.
>
> And how am I supposed to detect build breaks in contrib code now?
Just do not. I personally do not see the sky come crashing down if the
contrib stuff is broken temporarily. Those of us who use modern IDEs
will eventually pick up and fix the breakage.
Oleg
> My typical check-that-everything-compiles call is:
>
> ant clean-build package-src package-addon javadoc-addon
>
> where package-addon would build examples and contrib code.
>
> cheers,
> Roland
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
Re: svn commit: r514774 - in /jakarta/httpcomponents/httpcore/trunk:
build.xml contrib/
Posted by Roland Weber <ht...@dubioso.net>.
Hi Oleg,
> Removed all contrib related targets from the Ant build file.
And how am I supposed to detect build breaks in contrib code now?
My typical check-that-everything-compiles call is:
ant clean-build package-src package-addon javadoc-addon
where package-addon would build examples and contrib code.
cheers,
Roland
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org