You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Chris Westin <cw...@yahoo.com> on 2014/12/17 01:23:46 UTC

Review Request 29129: DRILL-1385: bytecode rewriting to move holder values to locals

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29129/
-----------------------------------------------------------

Review request for drill and Jacques Nadeau.


Bugs: DRILL-1385
    https://issues.apache.org/jira/browse/DRILL-1385


Repository: drill-git


Description
-------

DRILL-1385: bytecode rewriting to move holder values to locals; see diff for longer list of work


Diffs
-----


Diff: https://reviews.apache.org/r/29129/diff/


Testing
-------

Maven Install
TPCH SF100
Functional Passing - New (but got a verification failure in joinCSVParquet.q - not sure about this one)


File Attachments
----------------

patch - reviewboard refuses to upload diff
  https://reviews.apache.org/media/uploaded/files/2014/12/17/ccbd0221-4947-43ee-880f-f6dd501b5b50__drill-1385.1.patch.txt


Thanks,

Chris Westin


Re: Review Request 29129: DRILL-1385: bytecode rewriting to move holder values to locals

Posted by Chris Westin <cw...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29129/
-----------------------------------------------------------

(Updated Dec. 17, 2014, 2:27 a.m.)


Review request for drill and Jacques Nadeau.


Changes
-------

added github link


Bugs: DRILL-1385
    https://issues.apache.org/jira/browse/DRILL-1385


Repository: drill-git


Description (updated)
-------

DRILL-1385: bytecode rewriting to move holder values to locals; see diff for longer list of work

To see this in my github fork, see the sr1 branch https://github.com/cwestin/incubator-drill/tree/sr1


Diffs
-----


Diff: https://reviews.apache.org/r/29129/diff/


Testing
-------

Maven Install
TPCH SF100
Functional Passing - New (but got a verification failure in joinCSVParquet.q - not sure about this one)


File Attachments
----------------

patch - reviewboard refuses to upload diff
  https://reviews.apache.org/media/uploaded/files/2014/12/17/ccbd0221-4947-43ee-880f-f6dd501b5b50__drill-1385.1.patch.txt


Thanks,

Chris Westin