You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/04/11 17:41:46 UTC
[GitHub] [incubator-nuttx] antmerlino opened a new pull request #3522: stm32h7: Allow OTGHS to use internal FS PHY
antmerlino opened a new pull request #3522:
URL: https://github.com/apache/incubator-nuttx/pull/3522
## Summary
Prior to this change, the OTGHS peripheral's PHYSEL bit was always left in it's default state of 0 (External ULPI). This change adds a Kconfig option to switch between having an External ULPI, or using the built-in Full-Speed PHY.
## Impact
Users who were using the OTGHS with an external ULPI, probably no one, will have to select the STM32H7_EXTERNAL_ULPI option.
## Testing
Ran OTGHS CDCACM console using the OTGHS peripheral with the built-in FS PHY.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #3522: stm32h7: Allow OTGHS to use internal FS PHY
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #3522:
URL: https://github.com/apache/incubator-nuttx/pull/3522#issuecomment-818275683
@antmerlino - there is now a conflict, would you please rebase and address @acassis comment in the config file. The force push,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #3522: stm32h7: Allow OTGHS to use internal FS PHY
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #3522:
URL: https://github.com/apache/incubator-nuttx/pull/3522#issuecomment-818365854
> > @antmerlino - there is now a conflict, would you please rebase and address @acassis comment in the config file. The force push,
>
> @davids5 Rebased and force pushed.
>
> @acassis I've tried to address your concerns in the Kconfig help. Let me know if that covers it.
Ok! This is fine!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #3522: stm32h7: Allow OTGHS to use internal FS PHY
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #3522:
URL: https://github.com/apache/incubator-nuttx/pull/3522#issuecomment-818077053
Oh no, you didn't. It was in the bool msg in the menuconfig:
"No External ULPI hardware on board. OTG_HS1 is limited to Full-Speed using internal OTGFS PHY"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on pull request #3522: stm32h7: Allow OTGHS to use internal FS PHY
Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #3522:
URL: https://github.com/apache/incubator-nuttx/pull/3522#issuecomment-817790220
> @antmerlino will it work for OTS_HS1 and OTS_HS2?
The Data Sheet says:
2× USB OTG interfaces (1FS, 1HS/FS)
The devices embed two USB OTG high-speed (up to 480 Mbit/s) device/host/OTG peripheral. OTG-HS1 supports both full-speed and high-speed operations, while OTG-HS2 supports only full-speed operations. They both integrate the transceivers for full-speed operation (12 Mbit/s). **OTG-HS1 features a UTMI low-pin interface (ULPI) for high-speed operation (480 Mbit/s). When using the USB OTG-HS1 in HS mode, an external PHY device connected to the ULPI is required.**
> "No External ULPI, fallback to Full-Speed using internal OTGFS PHY"
"No External ULPI hardware on board. OTG_HS1 is limited to Full-Speed using internal OTGFS PHY"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] antmerlino commented on pull request #3522: stm32h7: Allow OTGHS to use internal FS PHY
Posted by GitBox <gi...@apache.org>.
antmerlino commented on pull request #3522:
URL: https://github.com/apache/incubator-nuttx/pull/3522#issuecomment-818062857
>
>
> @antmerlino will it work for OTS_HS1 and OTS_HS2?
> I think it is important to include the information that OTGHS will work only in FS in this case, maybe:
> "No External ULPI, fallback to Full-Speed using internal OTGFS PHY"
@acassis When you say "it is important to include the information..." How are you intending for this information to be presented?
1. Kconfig
2. Compile Time error
3. Run-time error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #3522: stm32h7: Allow OTGHS to use internal FS PHY
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #3522:
URL: https://github.com/apache/incubator-nuttx/pull/3522#issuecomment-818075982
> > @antmerlino will it work for OTS_HS1 and OTS_HS2?
> > I think it is important to include the information that OTGHS will work only in FS in this case, maybe:
> > "No External ULPI, fallback to Full-Speed using internal OTGFS PHY"
>
> @acassis When you say "it is important to include the information..." How are you intending for this information to be presented?
>
> 1. Kconfig
>
> 2. Compile Time error
>
> 3. Run-time error
I think you found it, thank you! ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] antmerlino commented on a change in pull request #3522: stm32h7: Allow OTGHS to use internal FS PHY
Posted by GitBox <gi...@apache.org>.
antmerlino commented on a change in pull request #3522:
URL: https://github.com/apache/incubator-nuttx/pull/3522#discussion_r611886384
##########
File path: arch/arm/src/stm32h7/Kconfig
##########
@@ -764,6 +764,27 @@ config STM32H7_UART8
endmenu # STM32H7 U[S]ART Selection
endmenu # STM32H7 Peripheral Selection
+menu "OTG_HS Configuration"
+ depends on STM32H7_OTGHS
+
+choice
+ prompt "ULPI Selection"
+ default STM32H7_OTGHS_NO_ULPI
+
+config STM32H7_OTGHS_NO_ULPI
+ bool "No External ULPI"
+ ---help---
+ Select to use the built-in full-speed PHY
+
+config STM32H7_OTGHS_EXTERNAL_ULPI
+ bool "External ULPI"
+ ---help---
+ Select to enable the presence of an external ULPI PHY
Review comment:
@davids5 done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3522: stm32h7: Allow OTGHS to use internal FS PHY
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #3522:
URL: https://github.com/apache/incubator-nuttx/pull/3522
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis edited a comment on pull request #3522: stm32h7: Allow OTGHS to use internal FS PHY
Posted by GitBox <gi...@apache.org>.
acassis edited a comment on pull request #3522:
URL: https://github.com/apache/incubator-nuttx/pull/3522#issuecomment-817379378
@antmerlino will it work for OTS_HS1 and OTS_HS2?
I think it is important to include the information that OTGHS will work only in FS in this case, maybe:
"No External ULPI, fallback to Full-Speed using internal OTGFS PHY"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #3522: stm32h7: Allow OTGHS to use internal FS PHY
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #3522:
URL: https://github.com/apache/incubator-nuttx/pull/3522#issuecomment-817379378
@antmerlino will it work for OTS_HS1 and OTS_HS2?
I think it is important to include the information that OTGHS will work in only in FS in this case, maybe:
"No External ULPI, fallback to Full-Speed using internal OTGFS PHY"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #3522: stm32h7: Allow OTGHS to use internal FS PHY
Posted by GitBox <gi...@apache.org>.
davids5 commented on a change in pull request #3522:
URL: https://github.com/apache/incubator-nuttx/pull/3522#discussion_r611610588
##########
File path: arch/arm/src/stm32h7/Kconfig
##########
@@ -764,6 +764,27 @@ config STM32H7_UART8
endmenu # STM32H7 U[S]ART Selection
endmenu # STM32H7 Peripheral Selection
+menu "OTG_HS Configuration"
+ depends on STM32H7_OTGHS
+
+choice
+ prompt "ULPI Selection"
+ default STM32H7_OTGHS_NO_ULPI
+
+config STM32H7_OTGHS_NO_ULPI
+ bool "No External ULPI"
+ ---help---
+ Select to use the built-in full-speed PHY
+
+config STM32H7_OTGHS_EXTERNAL_ULPI
+ bool "External ULPI"
+ ---help---
+ Select to enable the presence of an external ULPI PHY
Review comment:
```suggestion
Select to indicate the presence of an external ULPI PHY and use it.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] antmerlino commented on pull request #3522: stm32h7: Allow OTGHS to use internal FS PHY
Posted by GitBox <gi...@apache.org>.
antmerlino commented on pull request #3522:
URL: https://github.com/apache/incubator-nuttx/pull/3522#issuecomment-818305180
>
>
> @antmerlino - there is now a conflict, would you please rebase and address @acassis comment in the config file. The force push,
@davids5 Rebased and force pushed.
@acassis I've tried to address your concerns in the Kconfig help. Let me know if that covers it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org