You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Andrea Turli <no...@github.com> on 2016/07/26 15:23:24 UTC
[jclouds/jclouds-examples] refactor maven structure (#88)
first stab at the maven structure
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-examples/pull/88
-- Commit Summary --
* refactor maven structure
-- File Changes --
M blobstore-basics/pom.xml (18)
M blobstore-basics/src/main/java/org/jclouds/examples/blobstore/basics/MainApp.java (15)
M blobstore-hdfs/pom.xml (20)
M blobstore-karaf-shell/pom.xml (11)
M blobstore-largeblob/pom.xml (25)
M blobstore-largeblob/src/main/java/org/jclouds/examples/blobstore/largeblob/MainApp.java (12)
M blobstore-uploader/pom.xml (15)
M camel-notifications/pom.xml (258)
M chef-basics/pom.xml (30)
M chef-basics/src/main/java/org/apache/jclouds/examples/chef/basics/MainApp.java (5)
M cloudwatch-basics/pom.xml (10)
M compute-basics/pom.xml (80)
M compute-basics/src/main/java/org/jclouds/examples/compute/basics/MainApp.java (89)
M compute-basics/src/main/resources/logback.xml (4)
M glacier/pom.xml (8)
M glacier/src/main/java/org/jclouds/examples/glacier/MainApp.java (6)
M google-lb/pom.xml (75)
M google-lb/src/main/java/org/jclouds/examples/google/lb/MainApp.java (28)
M openstack/pom.xml (28)
M openstack/src/main/java/org/jclouds/examples/openstack/identity/CreateTenantAndUser.java (15)
M pom.xml (245)
M rackspace/pom.xml (71)
M rackspace/src/main/java/org/jclouds/examples/rackspace/autoscale/Constants.java (10)
M rackspace/src/main/java/org/jclouds/examples/rackspace/clouddatabases/CreateDatabase.java (11)
M rackspace/src/main/java/org/jclouds/examples/rackspace/clouddatabases/CreateUser.java (12)
-- Patch Links --
https://github.com/jclouds/jclouds-examples/pull/88.patch
https://github.com/jclouds/jclouds-examples/pull/88.diff
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/88
Re: [jclouds/jclouds-examples] refactor maven structure (#88)
Posted by Andrew Gaul <no...@github.com>.
jclouds-examples is a dumpster fire; thanks for looking into this! This pull request has a lot going on -- can you break out repairing bit rot into separate smaller commits? You can also make this smaller by consistently using the parent pom `jclouds.version` property. I made some progress in 4a778a13ddf94f8dc6b6e17cbe5f5347bb38f670 and ddb0cfbd40c8cd37a68a49b51adb8bb721f2b0c0 but more work remains. Some of these modules are so old that we should just remove them: blobstore-clojure, blobstore-scala-filesystem, camel-notifications, compute-clojure, deploy-war-via-ant, minecraft-compute, and play-compute. Others seem like we can make them to work: cloudwatch-basics, ec2-computeservice-spot, ec2-createlamp, and ec2-windows.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/88#issuecomment-236855853
Re: [jclouds/jclouds-examples] refactor maven structure (#88)
Posted by Andrew Phillips <no...@github.com>.
> Should this be added as post-step in the release guide?
Sounds like a good idea. Better still, how about a "small shell script" to automatically upgrade things? ;-)
Or more seriously, a step in the script that at least replaces the version number in the examples POM and _attempts_ to compile the examples?
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/88#issuecomment-236577288
Re: [jclouds/jclouds-examples] refactor maven structure (#88)
Posted by Andrew Phillips <no...@github.com>.
> can be to try to keep jclouds-examples in sync with latest release instead of the bleeding edge master. wdyt?
I think that was exactly the intention, and that we've simply fallen behind ;-) So definitely a +1 on that from me.
Many thanks for helping get this back up-to-date!
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/88#issuecomment-236172507
Re: [jclouds/jclouds-examples] refactor maven structure (#88)
Posted by Ignasi Barrera <no...@github.com>.
Yes, +1 to keep all examples using the latest stable release.
Should this be added as post-step in the release guide?
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/88#issuecomment-236519479
Re: [jclouds/jclouds-examples] refactor maven structure (#88)
Posted by Andrew Gaul <no...@github.com>.
> @@ -20,34 +20,34 @@
> <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
> <modelVersion>4.0.0</modelVersion>
> + <parent>
> + <groupId>org.apache.jclouds.examples</groupId>
> + <artifactId>jclouds-examples</artifactId>
> + <version>2.0.0-SNAPSHOT</version>
Prefer 1.9.2.
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/88/files/2c5f42952e1ff512d3ad209e1e62712200349ced#r73118330
Re: [jclouds/jclouds-examples] refactor maven structure (#88)
Posted by Andrea Turli <no...@github.com>.
Closed #88.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/88#event-1527961463
Re: [jclouds/jclouds-examples] refactor maven structure (#88)
Posted by Andrew Phillips <no...@github.com>.
> @@ -20,34 +20,34 @@
> <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
> <modelVersion>4.0.0</modelVersion>
> + <parent>
> + <groupId>org.apache.jclouds.examples</groupId>
> + <artifactId>jclouds-examples</artifactId>
> + <version>2.0.0-SNAPSHOT</version>
@andreaturli From what I recall, the idea originally was that the examples would be built against the **latest stable release**, so that users could see how to use a released version, rather than looking at how things work "on the bleeding edge."
Curious if we have any specific reason to move away from that?
/cc @nacx @andrewgaul
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/88/files/2c5f42952e1ff512d3ad209e1e62712200349ced#r72728078
Re: [jclouds/jclouds-examples] refactor maven structure (#88)
Posted by Andrea Turli <no...@github.com>.
thx @demobox I didn't know about the original intention.
Although I think it is a good idea, I think it doesn't work terribly well long term, most of the examples are referencing very old jclouds releases and they are not really helpful for new users.
I think a half way solution can be to try to keep jclouds-examples in sync with latest release instead of the bleeding edge master. wdyt?
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/88#issuecomment-236116735
Re: [jclouds/jclouds-examples] refactor maven structure (#88)
Posted by Andrea Turli <no...@github.com>.
closing as https://github.com/jclouds/jclouds-examples/pull/92 supercedes it
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/88#issuecomment-374141186
Re: [jclouds/jclouds-examples] refactor maven structure (#88)
Posted by Andrea Turli <no...@github.com>.
Agreed @andrewgaul, jclouds-examples as-is is not useful.
I'll try to open several subsequent PR to fix the project, maybe one maven module for each PR?
---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-examples/pull/88#issuecomment-236940307