[GitHub] [ranger] mneethiraj commented on a diff in pull request #223: RANGER-4043: Fix 'getent group' command when enumerate groups is enabled

["mneethiraj (via GitHub)" <gi...@apache.org>]

mneethiraj commented on code in PR #223:
URL: https://github.com/apache/ranger/pull/223#discussion_r1124884277


##########
ugsync/src/main/java/org/apache/ranger/unixusersync/process/UnixUserGroupBuilder.java:
##########
@@ -538,7 +538,7 @@ private void buildUnixGroupList(String allGroupsCmd, String groupCmd, boolean us
 
 			for (String group : groups) {
 				String command = String.format(groupCmd, group);
-				String[] cmd = new String[]{"bash", "-c", command + " '" + group + "'"};
+				String[] cmd = new String[]{"bash", "-c", command};

Review Comment:
   It looks like this fix would be needed in line #507 as well. @fateh288  - can you please review?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ranger.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org