You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/03/01 20:31:05 UTC
[GitHub] [beam] jrmccluskey opened a new pull request #16978: [BEAM-14012] Add go fmt to Github Actions
jrmccluskey opened a new pull request #16978:
URL: https://github.com/apache/beam/pull/16978
Adds a `go fmt` check to the Go GitHub actions, failing the build if a formatter run alters the code.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jrmccluskey commented on pull request #16978: [BEAM-14012] Add go fmt to Github Actions
Posted by GitBox <gi...@apache.org>.
jrmccluskey commented on pull request #16978:
URL: https://github.com/apache/beam/pull/16978#issuecomment-1055841352
PR #16973 should be merged first so we don't start with red builds once this is in though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a change in pull request #16978: [BEAM-14012] Add go fmt to Github Actions
Posted by GitBox <gi...@apache.org>.
damccorm commented on a change in pull request #16978:
URL: https://github.com/apache/beam/pull/16978#discussion_r817131036
##########
File path: .github/workflows/go_tests.yml
##########
@@ -49,5 +49,7 @@ jobs:
flags: go
files: ./sdks/go/pkg/coverage.txt
name: go-unittests
+ - name: Run fmt
+ run: cd sdks/go/pkg/beam && go fmt ./...; git diff-index --quiet HEAD || (echo "Run go fmt before checking in changes" && exit 1)
Review comment:
Rather than using `cd`, you can specify a working-directory (see https://github.com/apache/beam/blob/b07840e925b910fffee85d3bcdb67468965b7770/.github/workflows/python_tests.yml#L77-L79 for an example). Its not a bad idea to update the rest of the file, but I'll leave that to your discretion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jrmccluskey commented on pull request #16978: [BEAM-14012] Add go fmt to Github Actions
Posted by GitBox <gi...@apache.org>.
jrmccluskey commented on pull request #16978:
URL: https://github.com/apache/beam/pull/16978#issuecomment-1055840342
R: @damccorm @lostluck
I think I understand how this works now on a very basic level (which is why I added the exit code 1 output for vet too.) For some reason fmt was always returning exit code 1 on its own though, which is why we don't actually care if it executes here and continue on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck merged pull request #16978: [BEAM-14012] Add go fmt to Github Actions
Posted by GitBox <gi...@apache.org>.
lostluck merged pull request #16978:
URL: https://github.com/apache/beam/pull/16978
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org